From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Cc: linux-media@vger.kernel.org,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH 6/6] pxa_camera: fix smatch warning
Date: Thu, 7 Feb 2019 16:11:40 +0200 [thread overview]
Message-ID: <20190207141137.mgzm3cmj2wwlvq6z@paasikivi.fi.intel.com> (raw)
In-Reply-To: <20190207091338.55705-7-hverkuil-cisco@xs4all.nl>
On Thu, Feb 07, 2019 at 10:13:38AM +0100, Hans Verkuil wrote:
> drivers/media/platform/pxa_camera.c:2400 pxa_camera_probe() error: we previously assumed 'pcdev->pdata' could be null (see line 2397)
>
> First check if platform data is provided, then check if DT data is provided,
> and if neither is provided just return with -ENODEV.
>
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
--
Sakari Ailus
sakari.ailus@linux.intel.com
next prev parent reply other threads:[~2019-02-07 14:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-07 9:13 [PATCH 0/6] sparse/smatch fixes Hans Verkuil
2019-02-07 9:13 ` [PATCH 1/6] hdpvr: fix smatch warning Hans Verkuil
2019-02-07 9:13 ` [PATCH 2/6] vim2m: " Hans Verkuil
2019-02-07 9:13 ` [PATCH 3/6] uvc: " Hans Verkuil
2019-02-07 14:57 ` Kieran Bingham
2019-02-07 15:41 ` Laurent Pinchart
2019-02-07 16:35 ` Hans Verkuil
2019-02-07 9:13 ` [PATCH 4/6] vsp1: " Hans Verkuil
2019-02-12 13:48 ` Kieran Bingham
2019-02-12 16:31 ` Laurent Pinchart
2019-02-07 9:13 ` [PATCH 5/6] omap3isp: fix sparse warning Hans Verkuil
2019-02-07 9:18 ` Hans Verkuil
2019-02-07 14:23 ` Sakari Ailus
2019-02-07 15:45 ` Laurent Pinchart
2019-02-07 9:13 ` [PATCH 6/6] pxa_camera: fix smatch warning Hans Verkuil
2019-02-07 14:11 ` Sakari Ailus [this message]
2019-02-07 14:38 ` [PATCH 7/6] omap4iss: fix sparse warning Hans Verkuil
2019-02-07 14:51 ` Sakari Ailus
2019-02-07 15:47 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190207141137.mgzm3cmj2wwlvq6z@paasikivi.fi.intel.com \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).