linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: linux-media@vger.kernel.org
Cc: laurent.pinchart@ideasonboard.com
Subject: [PATCH 0/2] omap3isp: Control streaming on directly connected subdevs only
Date: Mon, 12 Aug 2019 11:32:25 +0300	[thread overview]
Message-ID: <20190812083227.11838-1-sakari.ailus@linux.intel.com> (raw)

Hi folks,

The omap3isp driver controlled the streaming state of all subdevs in the
pipeline, including those further up in the pipeline. Should there be more
than two subdevs (or drivers) there, this would cause s_stream op to be
called multiple times (and possibly at the wrong time).

Fix it.

Sakari Ailus (2):
  omap3isp: Set device on omap3isp subdevs
  omap3isp: Don't set streaming state on random subdevs

 drivers/media/platform/omap3isp/isp.c        | 8 ++++++++
 drivers/media/platform/omap3isp/ispccdc.c    | 1 +
 drivers/media/platform/omap3isp/ispccp2.c    | 1 +
 drivers/media/platform/omap3isp/ispcsi2.c    | 1 +
 drivers/media/platform/omap3isp/isppreview.c | 1 +
 drivers/media/platform/omap3isp/ispresizer.c | 1 +
 drivers/media/platform/omap3isp/ispstat.c    | 2 ++
 7 files changed, 15 insertions(+)

-- 
2.20.1


             reply	other threads:[~2019-08-12  8:35 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12  8:32 Sakari Ailus [this message]
2019-08-12  8:32 ` [PATCH 1/2] omap3isp: Set device on omap3isp subdevs Sakari Ailus
2019-08-12 22:39   ` Laurent Pinchart
2019-08-12  8:32 ` [PATCH 2/2] omap3isp: Don't set streaming state on random subdevs Sakari Ailus
2019-08-12 22:40   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190812083227.11838-1-sakari.ailus@linux.intel.com \
    --to=sakari.ailus@linux.intel.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).