linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] omap3isp: Set device on omap3isp subdevs
Date: Tue, 13 Aug 2019 01:39:36 +0300	[thread overview]
Message-ID: <20190812223936.GL5006@pendragon.ideasonboard.com> (raw)
In-Reply-To: <20190812083227.11838-2-sakari.ailus@linux.intel.com>

Hi Sakari,

Thank you for the patch.

On Mon, Aug 12, 2019 at 11:32:26AM +0300, Sakari Ailus wrote:
> The omap3isp driver registered subdevs without the dev field being set. Do
> that now.
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

The change looks fine, so

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

What are the implications of not setting the dev field ?

> ---
>  drivers/media/platform/omap3isp/ispccdc.c    | 1 +
>  drivers/media/platform/omap3isp/ispccp2.c    | 1 +
>  drivers/media/platform/omap3isp/ispcsi2.c    | 1 +
>  drivers/media/platform/omap3isp/isppreview.c | 1 +
>  drivers/media/platform/omap3isp/ispresizer.c | 1 +
>  drivers/media/platform/omap3isp/ispstat.c    | 2 ++
>  6 files changed, 7 insertions(+)
> 
> diff --git a/drivers/media/platform/omap3isp/ispccdc.c b/drivers/media/platform/omap3isp/ispccdc.c
> index 261ad1175f98..9297281402f5 100644
> --- a/drivers/media/platform/omap3isp/ispccdc.c
> +++ b/drivers/media/platform/omap3isp/ispccdc.c
> @@ -2605,6 +2605,7 @@ int omap3isp_ccdc_register_entities(struct isp_ccdc_device *ccdc,
>  	int ret;
>  
>  	/* Register the subdev and video node. */
> +	ccdc->subdev.dev = vdev->mdev->dev;
>  	ret = v4l2_device_register_subdev(vdev, &ccdc->subdev);
>  	if (ret < 0)
>  		goto error;
> diff --git a/drivers/media/platform/omap3isp/ispccp2.c b/drivers/media/platform/omap3isp/ispccp2.c
> index 2dea423ffc0e..3cf9a32c1d9e 100644
> --- a/drivers/media/platform/omap3isp/ispccp2.c
> +++ b/drivers/media/platform/omap3isp/ispccp2.c
> @@ -1034,6 +1034,7 @@ int omap3isp_ccp2_register_entities(struct isp_ccp2_device *ccp2,
>  	int ret;
>  
>  	/* Register the subdev and video nodes. */
> +	ccp2->subdev.dev = vdev->mdev->dev;
>  	ret = v4l2_device_register_subdev(vdev, &ccp2->subdev);
>  	if (ret < 0)
>  		goto error;
> diff --git a/drivers/media/platform/omap3isp/ispcsi2.c b/drivers/media/platform/omap3isp/ispcsi2.c
> index da66ea65be5d..9977702d57ff 100644
> --- a/drivers/media/platform/omap3isp/ispcsi2.c
> +++ b/drivers/media/platform/omap3isp/ispcsi2.c
> @@ -1201,6 +1201,7 @@ int omap3isp_csi2_register_entities(struct isp_csi2_device *csi2,
>  	int ret;
>  
>  	/* Register the subdev and video nodes. */
> +	csi2->subdev.dev = vdev->mdev->dev;
>  	ret = v4l2_device_register_subdev(vdev, &csi2->subdev);
>  	if (ret < 0)
>  		goto error;
> diff --git a/drivers/media/platform/omap3isp/isppreview.c b/drivers/media/platform/omap3isp/isppreview.c
> index 6ea6aeafd751..94fc9cf01436 100644
> --- a/drivers/media/platform/omap3isp/isppreview.c
> +++ b/drivers/media/platform/omap3isp/isppreview.c
> @@ -2228,6 +2228,7 @@ int omap3isp_preview_register_entities(struct isp_prev_device *prev,
>  	int ret;
>  
>  	/* Register the subdev and video nodes. */
> +	prev->subdev.dev = vdev->mdev->dev;
>  	ret = v4l2_device_register_subdev(vdev, &prev->subdev);
>  	if (ret < 0)
>  		goto error;
> diff --git a/drivers/media/platform/omap3isp/ispresizer.c b/drivers/media/platform/omap3isp/ispresizer.c
> index b281cae036b3..d5cce8b8af97 100644
> --- a/drivers/media/platform/omap3isp/ispresizer.c
> +++ b/drivers/media/platform/omap3isp/ispresizer.c
> @@ -1684,6 +1684,7 @@ int omap3isp_resizer_register_entities(struct isp_res_device *res,
>  	int ret;
>  
>  	/* Register the subdev and video nodes. */
> +	res->subdev.dev = vdev->mdev->dev;
>  	ret = v4l2_device_register_subdev(vdev, &res->subdev);
>  	if (ret < 0)
>  		goto error;
> diff --git a/drivers/media/platform/omap3isp/ispstat.c b/drivers/media/platform/omap3isp/ispstat.c
> index 46a42c5dc1cc..bb1578d6eaf6 100644
> --- a/drivers/media/platform/omap3isp/ispstat.c
> +++ b/drivers/media/platform/omap3isp/ispstat.c
> @@ -1029,6 +1029,8 @@ void omap3isp_stat_unregister_entities(struct ispstat *stat)
>  int omap3isp_stat_register_entities(struct ispstat *stat,
>  				    struct v4l2_device *vdev)
>  {
> +	stat->subdev.dev = vdev->mdev->dev;
> +
>  	return v4l2_device_register_subdev(vdev, &stat->subdev);
>  }
>  
> -- 
> 2.20.1
> 

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2019-08-12 22:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-12  8:32 [PATCH 0/2] omap3isp: Control streaming on directly connected subdevs only Sakari Ailus
2019-08-12  8:32 ` [PATCH 1/2] omap3isp: Set device on omap3isp subdevs Sakari Ailus
2019-08-12 22:39   ` Laurent Pinchart [this message]
2019-08-12  8:32 ` [PATCH 2/2] omap3isp: Don't set streaming state on random subdevs Sakari Ailus
2019-08-12 22:40   ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190812223936.GL5006@pendragon.ideasonboard.com \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).