linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nícolas F. R. A. Prado" <nfraprado@protonmail.com>
To: Helen Koike <helen.koike@collabora.com>
Cc: linux-media@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH 1/3] media: vimc: Support multiple buscodes for each pixelformat
Date: Sat, 08 Feb 2020 20:36:50 +0000	[thread overview]
Message-ID: <20200208203639.nxxzgh6j6z7yagzc@ArchWay.local> (raw)
In-Reply-To: <1d32848b-3009-1748-2823-5b91404c6426@collabora.com>

Hi Helen,
thanks for the review.

Just one comment below.

On Wed, Feb 05, 2020 at 11:17:31AM -0300, Helen Koike wrote:
>
> Hi Nícolas,
>
> Thanks for the patch, just some minor nits:
>
> On 2/2/20 1:50 PM, Nícolas F. R. A. Prado wrote:
> > diff --git a/drivers/media/platform/vimc/vimc-common.h b/drivers/media/platform/vimc/vimc-common.h
> > index 87eb8259c2a8..132a5889f1ea 100644
> > --- a/drivers/media/platform/vimc/vimc-common.h
> > +++ b/drivers/media/platform/vimc/vimc-common.h
> > @@ -69,7 +69,7 @@ do {                                                                      \
> >   * V4L2_PIX_FMT_* fourcc pixelformat and its bytes per pixel (bpp)
> >   */
> >  struct vimc_pix_map {
> > -   unsigned int code;
> > +   unsigned int code[3];
>
> why 3?

On my patch I'm using at most 2.
I chose 3 so that it would be easier to add more formats, but I guess it doesn't
really make sense, since it's wasting memory and that value can be increased
when it's necessary.
So I should change it to 2, right?

> Regards,
> Helen

Thanks,
Nícolas


  reply	other threads:[~2020-02-08 20:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-02 15:50 [PATCH 0/3] media: vimc: Add support for GBR and BGR formats on source pad of debayer Nícolas F. R. A. Prado
2020-02-02 15:50 ` [PATCH 1/3] media: vimc: Support multiple buscodes for each pixelformat Nícolas F. R. A. Prado
2020-02-05 14:17   ` Helen Koike
2020-02-08 20:36     ` Nícolas F. R. A. Prado [this message]
2020-02-02 15:50 ` [PATCH 2/3] media: vimc: Add GBR media bus code Nícolas F. R. A. Prado
2020-02-05 14:17   ` Helen Koike
2020-02-09 14:00     ` Nícolas F. R. A. Prado
2020-02-02 15:50 ` [PATCH 3/3] media: vimc: deb: Add support for GBR and BGR bus formats on source pad Nícolas F. R. A. Prado
2020-02-05 14:17   ` Helen Koike
2020-02-09 17:09 ` [PATCH 0/3] media: vimc: Add support for GBR and BGR formats on source pad of debayer Ezequiel Garcia
2020-02-09 18:26   ` Nícolas F. R. A. Prado

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200208203639.nxxzgh6j6z7yagzc@ArchWay.local \
    --to=nfraprado@protonmail.com \
    --cc=helen.koike@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkcamp@lists.libreplanetbr.org \
    --cc=mchehab@kernel.org \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).