From: Helen Koike <helen.koike@collabora.com>
To: "Nícolas F. R. A. Prado" <nfraprado@protonmail.com>,
linux-media@vger.kernel.org
Cc: Shuah Khan <skhan@linuxfoundation.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil@xs4all.nl>,
linux-kernel@vger.kernel.org, lkcamp@lists.libreplanetbr.org
Subject: Re: [PATCH 2/3] media: vimc: Add GBR media bus code
Date: Wed, 5 Feb 2020 11:17:35 -0300 [thread overview]
Message-ID: <c88d21cb-29e0-9fac-c584-d010fd9a4aa3@collabora.com> (raw)
In-Reply-To: <20200202155019.1029993-3-nfraprado@protonmail.com>
Hi Nícolas,
Thank you for the patch.
On 2/2/20 1:50 PM, Nícolas F. R. A. Prado wrote:
> Add missing GBR888_1X24 media bus code in the vimc_pix_map_list. Since
> there is no pixel format for it, use the pixelformat for RGB.
>
> Co-developed-by: Vitor Massaru Iha <vitor@massaru.org>
> Signed-off-by: Vitor Massaru Iha <vitor@massaru.org>
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@protonmail.com>
> ---
> drivers/media/platform/vimc/vimc-common.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vimc/vimc-common.c b/drivers/media/platform/vimc/vimc-common.c
> index 55797e5ab2b1..591a50f63766 100644
> --- a/drivers/media/platform/vimc/vimc-common.c
> +++ b/drivers/media/platform/vimc/vimc-common.c
> @@ -25,7 +25,7 @@ static const struct vimc_pix_map vimc_pix_map_list[] = {
> .bayer = false,
> },
> {
> - .code = {MEDIA_BUS_FMT_RGB888_1X24},
> + .code = {MEDIA_BUS_FMT_RGB888_1X24, MEDIA_BUS_FMT_GBR888_1X24},
Could you add spaces around the curly brackets here too?
I was also thinking that all the MEDIA_BUS_FMT_RGB888_* and MEDIA_BUS_FMT_GBR888_* variants
could be added here (to be verified).
Thanks
Helen
> .pixelformat = V4L2_PIX_FMT_RGB24,
> .bpp = 3,
> .bayer = false,
>
next prev parent reply other threads:[~2020-02-05 14:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-02 15:50 [PATCH 0/3] media: vimc: Add support for GBR and BGR formats on source pad of debayer Nícolas F. R. A. Prado
2020-02-02 15:50 ` [PATCH 1/3] media: vimc: Support multiple buscodes for each pixelformat Nícolas F. R. A. Prado
2020-02-05 14:17 ` Helen Koike
2020-02-08 20:36 ` Nícolas F. R. A. Prado
2020-02-02 15:50 ` [PATCH 2/3] media: vimc: Add GBR media bus code Nícolas F. R. A. Prado
2020-02-05 14:17 ` Helen Koike [this message]
2020-02-09 14:00 ` Nícolas F. R. A. Prado
2020-02-02 15:50 ` [PATCH 3/3] media: vimc: deb: Add support for GBR and BGR bus formats on source pad Nícolas F. R. A. Prado
2020-02-05 14:17 ` Helen Koike
2020-02-09 17:09 ` [PATCH 0/3] media: vimc: Add support for GBR and BGR formats on source pad of debayer Ezequiel Garcia
2020-02-09 18:26 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c88d21cb-29e0-9fac-c584-d010fd9a4aa3@collabora.com \
--to=helen.koike@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=lkcamp@lists.libreplanetbr.org \
--cc=mchehab@kernel.org \
--cc=nfraprado@protonmail.com \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).