linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity
@ 2015-08-04  9:37 Josh Wu
  2015-08-04 11:22 ` Laurent Pinchart
  0 siblings, 1 reply; 6+ messages in thread
From: Josh Wu @ 2015-08-04  9:37 UTC (permalink / raw)
  To: Linux Media Mailing List, Guennadi Liakhovetski, linux-arm-kernel
  Cc: Laurent Pinchart, Josh Wu

This patch will get the DT parameters of vsync/hsync/pixclock polarity, and
pass to driver.

Also add a debug information for test purpose.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
---

Changes in v3:
- add embedded sync dt property support.

Changes in v2:
- rewrite the debug message and add pix clock polarity setup thanks to
  Laurent.
- update the commit log.

 drivers/media/platform/soc_camera/atmel-isi.c | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c
index fead841..4efc939 100644
--- a/drivers/media/platform/soc_camera/atmel-isi.c
+++ b/drivers/media/platform/soc_camera/atmel-isi.c
@@ -1061,6 +1061,11 @@ static int isi_camera_set_bus_param(struct soc_camera_device *icd)
 	if (common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
 		cfg1 |= ISI_CFG1_PIXCLK_POL_ACTIVE_FALLING;
 
+	dev_dbg(icd->parent, "vsync active %s, hsync active %s, sampling on pix clock %s edge\n",
+		common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW ? "low" : "high",
+		common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? "low" : "high",
+		common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING ? "falling" : "rising");
+
 	if (isi->pdata.has_emb_sync)
 		cfg1 |= ISI_CFG1_EMB_SYNC;
 	if (isi->pdata.full_mode)
@@ -1148,6 +1153,16 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi,
 		return -EINVAL;
 	}
 
+	if (ep.bus.parallel.flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
+		isi->pdata.hsync_act_low = true;
+	if (ep.bus.parallel.flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
+		isi->pdata.vsync_act_low = true;
+	if (ep.bus.parallel.flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
+		isi->pdata.pclk_act_falling = true;
+
+	if (ep.bus_type == V4L2_MBUS_BT656)
+		isi->pdata.has_emb_sync = true;
+
 	return 0;
 }
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity
  2015-08-04  9:37 [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity Josh Wu
@ 2015-08-04 11:22 ` Laurent Pinchart
  2015-09-18  9:20   ` Nicolas Ferre
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2015-08-04 11:22 UTC (permalink / raw)
  To: Josh Wu; +Cc: Linux Media Mailing List, Guennadi Liakhovetski, linux-arm-kernel

Hi Josh,

Thank you for the patch.

On Tuesday 04 August 2015 17:37:49 Josh Wu wrote:
> This patch will get the DT parameters of vsync/hsync/pixclock polarity, and
> pass to driver.
> 
> Also add a debug information for test purpose.
> 
> Signed-off-by: Josh Wu <josh.wu@atmel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> 
> Changes in v3:
> - add embedded sync dt property support.
> 
> Changes in v2:
> - rewrite the debug message and add pix clock polarity setup thanks to
>   Laurent.
> - update the commit log.
> 
>  drivers/media/platform/soc_camera/atmel-isi.c | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
> b/drivers/media/platform/soc_camera/atmel-isi.c index fead841..4efc939
> 100644
> --- a/drivers/media/platform/soc_camera/atmel-isi.c
> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> @@ -1061,6 +1061,11 @@ static int isi_camera_set_bus_param(struct
> soc_camera_device *icd) if (common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
>  		cfg1 |= ISI_CFG1_PIXCLK_POL_ACTIVE_FALLING;
> 
> +	dev_dbg(icd->parent, "vsync active %s, hsync active %s, sampling on pix
> clock %s edge\n", +		common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW ? "low" :
> "high",
> +		common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? "low" : "high",
> +		common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING ? "falling" : "rising");
> +
>  	if (isi->pdata.has_emb_sync)
>  		cfg1 |= ISI_CFG1_EMB_SYNC;
>  	if (isi->pdata.full_mode)
> @@ -1148,6 +1153,16 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi,
>  		return -EINVAL;
>  	}
> 
> +	if (ep.bus.parallel.flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
> +		isi->pdata.hsync_act_low = true;
> +	if (ep.bus.parallel.flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
> +		isi->pdata.vsync_act_low = true;
> +	if (ep.bus.parallel.flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
> +		isi->pdata.pclk_act_falling = true;
> +
> +	if (ep.bus_type == V4L2_MBUS_BT656)
> +		isi->pdata.has_emb_sync = true;
> +
>  	return 0;
>  }

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity
  2015-08-04 11:22 ` Laurent Pinchart
@ 2015-09-18  9:20   ` Nicolas Ferre
  2015-09-18  9:44     ` Guennadi Liakhovetski
  0 siblings, 1 reply; 6+ messages in thread
From: Nicolas Ferre @ 2015-09-18  9:20 UTC (permalink / raw)
  To: Laurent Pinchart, Guennadi Liakhovetski,
	Linux Media Mailing List, Mauro Carvalho Chehab
  Cc: Josh Wu, linux-arm-kernel

Le 04/08/2015 13:22, Laurent Pinchart a écrit :
> Hi Josh,
> 
> Thank you for the patch.
> 
> On Tuesday 04 August 2015 17:37:49 Josh Wu wrote:
>> This patch will get the DT parameters of vsync/hsync/pixclock polarity, and
>> pass to driver.
>>
>> Also add a debug information for test purpose.
>>
>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

Guennadi, Mauro,

I don't see this patch in Linux-next and I'm not so used to
http://git.linuxtv.org but didn't find it either.

Well in fact it's just a lengthy version of "ping" ;-)

Bye,

>> ---
>>
>> Changes in v3:
>> - add embedded sync dt property support.
>>
>> Changes in v2:
>> - rewrite the debug message and add pix clock polarity setup thanks to
>>   Laurent.
>> - update the commit log.
>>
>>  drivers/media/platform/soc_camera/atmel-isi.c | 15 +++++++++++++++
>>  1 file changed, 15 insertions(+)
>>
>> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
>> b/drivers/media/platform/soc_camera/atmel-isi.c index fead841..4efc939
>> 100644
>> --- a/drivers/media/platform/soc_camera/atmel-isi.c
>> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
>> @@ -1061,6 +1061,11 @@ static int isi_camera_set_bus_param(struct
>> soc_camera_device *icd) if (common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
>>  		cfg1 |= ISI_CFG1_PIXCLK_POL_ACTIVE_FALLING;
>>
>> +	dev_dbg(icd->parent, "vsync active %s, hsync active %s, sampling on pix
>> clock %s edge\n", +		common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW ? "low" :
>> "high",
>> +		common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? "low" : "high",
>> +		common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING ? "falling" : "rising");
>> +
>>  	if (isi->pdata.has_emb_sync)
>>  		cfg1 |= ISI_CFG1_EMB_SYNC;
>>  	if (isi->pdata.full_mode)
>> @@ -1148,6 +1153,16 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi,
>>  		return -EINVAL;
>>  	}
>>
>> +	if (ep.bus.parallel.flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
>> +		isi->pdata.hsync_act_low = true;
>> +	if (ep.bus.parallel.flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
>> +		isi->pdata.vsync_act_low = true;
>> +	if (ep.bus.parallel.flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
>> +		isi->pdata.pclk_act_falling = true;
>> +
>> +	if (ep.bus_type == V4L2_MBUS_BT656)
>> +		isi->pdata.has_emb_sync = true;
>> +
>>  	return 0;
>>  }
> 


-- 
Nicolas Ferre

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity
  2015-09-18  9:20   ` Nicolas Ferre
@ 2015-09-18  9:44     ` Guennadi Liakhovetski
  2015-09-18 11:13       ` Josh Wu
  0 siblings, 1 reply; 6+ messages in thread
From: Guennadi Liakhovetski @ 2015-09-18  9:44 UTC (permalink / raw)
  To: Nicolas Ferre
  Cc: Laurent Pinchart, Linux Media Mailing List,
	Mauro Carvalho Chehab, Josh Wu, linux-arm-kernel

Hi Nicolas,

Patch handling is on my todo for the coming weekend...

Thanks
Guennadi

On Fri, 18 Sep 2015, Nicolas Ferre wrote:

> Le 04/08/2015 13:22, Laurent Pinchart a écrit :
> > Hi Josh,
> > 
> > Thank you for the patch.
> > 
> > On Tuesday 04 August 2015 17:37:49 Josh Wu wrote:
> >> This patch will get the DT parameters of vsync/hsync/pixclock polarity, and
> >> pass to driver.
> >>
> >> Also add a debug information for test purpose.
> >>
> >> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> > 
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> 
> Guennadi, Mauro,
> 
> I don't see this patch in Linux-next and I'm not so used to
> http://git.linuxtv.org but didn't find it either.
> 
> Well in fact it's just a lengthy version of "ping" ;-)
> 
> Bye,
> 
> >> ---
> >>
> >> Changes in v3:
> >> - add embedded sync dt property support.
> >>
> >> Changes in v2:
> >> - rewrite the debug message and add pix clock polarity setup thanks to
> >>   Laurent.
> >> - update the commit log.
> >>
> >>  drivers/media/platform/soc_camera/atmel-isi.c | 15 +++++++++++++++
> >>  1 file changed, 15 insertions(+)
> >>
> >> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
> >> b/drivers/media/platform/soc_camera/atmel-isi.c index fead841..4efc939
> >> 100644
> >> --- a/drivers/media/platform/soc_camera/atmel-isi.c
> >> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> >> @@ -1061,6 +1061,11 @@ static int isi_camera_set_bus_param(struct
> >> soc_camera_device *icd) if (common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
> >>  		cfg1 |= ISI_CFG1_PIXCLK_POL_ACTIVE_FALLING;
> >>
> >> +	dev_dbg(icd->parent, "vsync active %s, hsync active %s, sampling on pix
> >> clock %s edge\n", +		common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW ? "low" :
> >> "high",
> >> +		common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? "low" : "high",
> >> +		common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING ? "falling" : "rising");
> >> +
> >>  	if (isi->pdata.has_emb_sync)
> >>  		cfg1 |= ISI_CFG1_EMB_SYNC;
> >>  	if (isi->pdata.full_mode)
> >> @@ -1148,6 +1153,16 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi,
> >>  		return -EINVAL;
> >>  	}
> >>
> >> +	if (ep.bus.parallel.flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
> >> +		isi->pdata.hsync_act_low = true;
> >> +	if (ep.bus.parallel.flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
> >> +		isi->pdata.vsync_act_low = true;
> >> +	if (ep.bus.parallel.flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
> >> +		isi->pdata.pclk_act_falling = true;
> >> +
> >> +	if (ep.bus_type == V4L2_MBUS_BT656)
> >> +		isi->pdata.has_emb_sync = true;
> >> +
> >>  	return 0;
> >>  }
> > 
> 
> 
> -- 
> Nicolas Ferre
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity
  2015-09-18  9:44     ` Guennadi Liakhovetski
@ 2015-09-18 11:13       ` Josh Wu
  2015-09-18 11:21         ` Guennadi Liakhovetski
  0 siblings, 1 reply; 6+ messages in thread
From: Josh Wu @ 2015-09-18 11:13 UTC (permalink / raw)
  To: Guennadi Liakhovetski, Nicolas Ferre
  Cc: Laurent Pinchart, Linux Media Mailing List,
	Mauro Carvalho Chehab, linux-arm-kernel

Hi, Guennadi

On 9/18/2015 5:44 PM, Guennadi Liakhovetski wrote:
> Hi Nicolas,
>
> Patch handling is on my todo for the coming weekend...

Beside this patch, Atmel-isi still have server other patches in the 
patchwork for a long time. So some patch may need to rebase.

Just for your convenience I create a branch here: 
https://github.com/JoshWu/linux-at91/commits/atmel-isi-v4.3,
which collected all the Atmel-isi patches that still not merged. You can 
take it as a reference.

Of cause, if you want I can sent out a pull request for it. thanks.

Best Regards,
Josh Wu
>
> Thanks
> Guennadi
>
> On Fri, 18 Sep 2015, Nicolas Ferre wrote:
>
>> Le 04/08/2015 13:22, Laurent Pinchart a écrit :
>>> Hi Josh,
>>>
>>> Thank you for the patch.
>>>
>>> On Tuesday 04 August 2015 17:37:49 Josh Wu wrote:
>>>> This patch will get the DT parameters of vsync/hsync/pixclock polarity, and
>>>> pass to driver.
>>>>
>>>> Also add a debug information for test purpose.
>>>>
>>>> Signed-off-by: Josh Wu <josh.wu@atmel.com>
>>> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>> Guennadi, Mauro,
>>
>> I don't see this patch in Linux-next and I'm not so used to
>> http://git.linuxtv.org but didn't find it either.
>>
>> Well in fact it's just a lengthy version of "ping" ;-)
>>
>> Bye,
>>
>>>> ---
>>>>
>>>> Changes in v3:
>>>> - add embedded sync dt property support.
>>>>
>>>> Changes in v2:
>>>> - rewrite the debug message and add pix clock polarity setup thanks to
>>>>    Laurent.
>>>> - update the commit log.
>>>>
>>>>   drivers/media/platform/soc_camera/atmel-isi.c | 15 +++++++++++++++
>>>>   1 file changed, 15 insertions(+)
>>>>
>>>> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
>>>> b/drivers/media/platform/soc_camera/atmel-isi.c index fead841..4efc939
>>>> 100644
>>>> --- a/drivers/media/platform/soc_camera/atmel-isi.c
>>>> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
>>>> @@ -1061,6 +1061,11 @@ static int isi_camera_set_bus_param(struct
>>>> soc_camera_device *icd) if (common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
>>>>   		cfg1 |= ISI_CFG1_PIXCLK_POL_ACTIVE_FALLING;
>>>>
>>>> +	dev_dbg(icd->parent, "vsync active %s, hsync active %s, sampling on pix
>>>> clock %s edge\n", +		common_flags & V4L2_MBUS_VSYNC_ACTIVE_LOW ? "low" :
>>>> "high",
>>>> +		common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? "low" : "high",
>>>> +		common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING ? "falling" : "rising");
>>>> +
>>>>   	if (isi->pdata.has_emb_sync)
>>>>   		cfg1 |= ISI_CFG1_EMB_SYNC;
>>>>   	if (isi->pdata.full_mode)
>>>> @@ -1148,6 +1153,16 @@ static int atmel_isi_parse_dt(struct atmel_isi *isi,
>>>>   		return -EINVAL;
>>>>   	}
>>>>
>>>> +	if (ep.bus.parallel.flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
>>>> +		isi->pdata.hsync_act_low = true;
>>>> +	if (ep.bus.parallel.flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
>>>> +		isi->pdata.vsync_act_low = true;
>>>> +	if (ep.bus.parallel.flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
>>>> +		isi->pdata.pclk_act_falling = true;
>>>> +
>>>> +	if (ep.bus_type == V4L2_MBUS_BT656)
>>>> +		isi->pdata.has_emb_sync = true;
>>>> +
>>>>   	return 0;
>>>>   }
>>
>> -- 
>> Nicolas Ferre
>>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity
  2015-09-18 11:13       ` Josh Wu
@ 2015-09-18 11:21         ` Guennadi Liakhovetski
  0 siblings, 0 replies; 6+ messages in thread
From: Guennadi Liakhovetski @ 2015-09-18 11:21 UTC (permalink / raw)
  To: Josh Wu
  Cc: Nicolas Ferre, Laurent Pinchart, Linux Media Mailing List,
	Mauro Carvalho Chehab, linux-arm-kernel

Hi Josh,

On Fri, 18 Sep 2015, Josh Wu wrote:

> Hi, Guennadi
> 
> On 9/18/2015 5:44 PM, Guennadi Liakhovetski wrote:
> > Hi Nicolas,
> > 
> > Patch handling is on my todo for the coming weekend...
> 
> Beside this patch, Atmel-isi still have server other patches in the patchwork
> for a long time. So some patch may need to rebase.
> 
> Just for your convenience I create a branch here:
> https://github.com/JoshWu/linux-at91/commits/atmel-isi-v4.3,

Thanks, that will help!

> which collected all the Atmel-isi patches that still not merged. You can take
> it as a reference.
> 
> Of cause, if you want I can sent out a pull request for it. thanks.

No need, the branch info above should be enough.

Thanks
Guennadi

> 
> Best Regards,
> Josh Wu
> > 
> > Thanks
> > Guennadi
> > 
> > On Fri, 18 Sep 2015, Nicolas Ferre wrote:
> > 
> > > Le 04/08/2015 13:22, Laurent Pinchart a écrit :
> > > > Hi Josh,
> > > > 
> > > > Thank you for the patch.
> > > > 
> > > > On Tuesday 04 August 2015 17:37:49 Josh Wu wrote:
> > > > > This patch will get the DT parameters of vsync/hsync/pixclock
> > > > > polarity, and
> > > > > pass to driver.
> > > > > 
> > > > > Also add a debug information for test purpose.
> > > > > 
> > > > > Signed-off-by: Josh Wu <josh.wu@atmel.com>
> > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Guennadi, Mauro,
> > > 
> > > I don't see this patch in Linux-next and I'm not so used to
> > > http://git.linuxtv.org but didn't find it either.
> > > 
> > > Well in fact it's just a lengthy version of "ping" ;-)
> > > 
> > > Bye,
> > > 
> > > > > ---
> > > > > 
> > > > > Changes in v3:
> > > > > - add embedded sync dt property support.
> > > > > 
> > > > > Changes in v2:
> > > > > - rewrite the debug message and add pix clock polarity setup thanks to
> > > > >    Laurent.
> > > > > - update the commit log.
> > > > > 
> > > > >   drivers/media/platform/soc_camera/atmel-isi.c | 15 +++++++++++++++
> > > > >   1 file changed, 15 insertions(+)
> > > > > 
> > > > > diff --git a/drivers/media/platform/soc_camera/atmel-isi.c
> > > > > b/drivers/media/platform/soc_camera/atmel-isi.c index fead841..4efc939
> > > > > 100644
> > > > > --- a/drivers/media/platform/soc_camera/atmel-isi.c
> > > > > +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> > > > > @@ -1061,6 +1061,11 @@ static int isi_camera_set_bus_param(struct
> > > > > soc_camera_device *icd) if (common_flags &
> > > > > V4L2_MBUS_PCLK_SAMPLE_FALLING)
> > > > >   		cfg1 |= ISI_CFG1_PIXCLK_POL_ACTIVE_FALLING;
> > > > > 
> > > > > +	dev_dbg(icd->parent, "vsync active %s, hsync active %s,
> > > > > sampling on pix
> > > > > clock %s edge\n", +		common_flags &
> > > > > V4L2_MBUS_VSYNC_ACTIVE_LOW ? "low" :
> > > > > "high",
> > > > > +		common_flags & V4L2_MBUS_HSYNC_ACTIVE_LOW ? "low" :
> > > > > "high",
> > > > > +		common_flags & V4L2_MBUS_PCLK_SAMPLE_FALLING ?
> > > > > "falling" : "rising");
> > > > > +
> > > > >   	if (isi->pdata.has_emb_sync)
> > > > >   		cfg1 |= ISI_CFG1_EMB_SYNC;
> > > > >   	if (isi->pdata.full_mode)
> > > > > @@ -1148,6 +1153,16 @@ static int atmel_isi_parse_dt(struct atmel_isi
> > > > > *isi,
> > > > >   		return -EINVAL;
> > > > >   	}
> > > > > 
> > > > > +	if (ep.bus.parallel.flags & V4L2_MBUS_HSYNC_ACTIVE_LOW)
> > > > > +		isi->pdata.hsync_act_low = true;
> > > > > +	if (ep.bus.parallel.flags & V4L2_MBUS_VSYNC_ACTIVE_LOW)
> > > > > +		isi->pdata.vsync_act_low = true;
> > > > > +	if (ep.bus.parallel.flags & V4L2_MBUS_PCLK_SAMPLE_FALLING)
> > > > > +		isi->pdata.pclk_act_falling = true;
> > > > > +
> > > > > +	if (ep.bus_type == V4L2_MBUS_BT656)
> > > > > +		isi->pdata.has_emb_sync = true;
> > > > > +
> > > > >   	return 0;
> > > > >   }
> > > 
> > > -- 
> > > Nicolas Ferre
> > > 
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2015-09-18 11:21 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-08-04  9:37 [PATCH v3] media: atmel-isi: parse the DT parameters for vsync/hsync/pixclock polarity Josh Wu
2015-08-04 11:22 ` Laurent Pinchart
2015-09-18  9:20   ` Nicolas Ferre
2015-09-18  9:44     ` Guennadi Liakhovetski
2015-09-18 11:13       ` Josh Wu
2015-09-18 11:21         ` Guennadi Liakhovetski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).