linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] Fix broken for loop in libv4l
@ 2020-04-08 17:17 Hans Petter Selasky
  2020-04-14  8:43 ` Hans Verkuil
  0 siblings, 1 reply; 2+ messages in thread
From: Hans Petter Selasky @ 2020-04-08 17:17 UTC (permalink / raw)
  To: linux-media

Hi,

This is one in a series of patches. Is this the right place to post 
patches for libv4l ?

Signed-off-by: Hans Petter Selasky <hps@selasky.org>
---
  lib/libv4lconvert/rgbyuv.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/libv4lconvert/rgbyuv.c b/lib/libv4lconvert/rgbyuv.c
index 79bc0bdb..b54b4577 100644
--- a/lib/libv4lconvert/rgbyuv.c
+++ b/lib/libv4lconvert/rgbyuv.c
@@ -893,7 +893,7 @@ void v4lconvert_nv12_to_yuv420(const unsigned char 
*src, unsigned char *dest,
  	}

  	for (i = 0; i < height; i++)
-		for (j = 0; i < width; j++) {
+		for (j = 0; j < width; j++) {
  			*ydst++ = *ysrc++;
  			if (((i % 2) == 0) && ((j % 2) == 0)) {
  				*udst++ = *uvsrc++;
-- 
2.25.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix broken for loop in libv4l
  2020-04-08 17:17 [PATCH] Fix broken for loop in libv4l Hans Petter Selasky
@ 2020-04-14  8:43 ` Hans Verkuil
  0 siblings, 0 replies; 2+ messages in thread
From: Hans Verkuil @ 2020-04-14  8:43 UTC (permalink / raw)
  To: Hans Petter Selasky, linux-media

On 08/04/2020 19:17, Hans Petter Selasky wrote:
> Hi,
> 
> This is one in a series of patches. Is this the right place to post 
> patches for libv4l ?

Yes, this is the right place.

I've applied this patch. Amazing that this hasn't been discovered before.

Thanks!

	Hans

> 
> Signed-off-by: Hans Petter Selasky <hps@selasky.org>
> ---
>   lib/libv4lconvert/rgbyuv.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/libv4lconvert/rgbyuv.c b/lib/libv4lconvert/rgbyuv.c
> index 79bc0bdb..b54b4577 100644
> --- a/lib/libv4lconvert/rgbyuv.c
> +++ b/lib/libv4lconvert/rgbyuv.c
> @@ -893,7 +893,7 @@ void v4lconvert_nv12_to_yuv420(const unsigned char 
> *src, unsigned char *dest,
>   	}
> 
>   	for (i = 0; i < height; i++)
> -		for (j = 0; i < width; j++) {
> +		for (j = 0; j < width; j++) {
>   			*ydst++ = *ysrc++;
>   			if (((i % 2) == 0) && ((j % 2) == 0)) {
>   				*udst++ = *uvsrc++;
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-04-14  8:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-08 17:17 [PATCH] Fix broken for loop in libv4l Hans Petter Selasky
2020-04-14  8:43 ` Hans Verkuil

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).