* [PATCH] v4l: ti-vpe: fix devm_ioremap_resource() return value checking
@ 2014-03-18 10:41 Bartlomiej Zolnierkiewicz
2014-03-20 8:39 ` Archit Taneja
0 siblings, 1 reply; 2+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-03-18 10:41 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Archit Taneja, Hans Verkuil, linux-media, linux-kernel
devm_ioremap_resource() returns a pointer to the remapped memory or
an ERR_PTR() encoded error code on failure. Fix the checks inside
csc_create() and sc_create() accordingly.
Cc: Archit Taneja <archit@ti.com>
Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
---
Compile tested only.
drivers/media/platform/ti-vpe/csc.c | 4 ++--
drivers/media/platform/ti-vpe/sc.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Index: b/drivers/media/platform/ti-vpe/csc.c
===================================================================
--- a/drivers/media/platform/ti-vpe/csc.c 2014-03-14 16:45:25.848724010 +0100
+++ b/drivers/media/platform/ti-vpe/csc.c 2014-03-18 11:01:36.595182833 +0100
@@ -187,9 +187,9 @@ struct csc_data *csc_create(struct platf
}
csc->base = devm_ioremap_resource(&pdev->dev, csc->res);
- if (!csc->base) {
+ if (IS_ERR(csc->base)) {
dev_err(&pdev->dev, "failed to ioremap\n");
- return ERR_PTR(-ENOMEM);
+ return csc->base;
}
return csc;
Index: b/drivers/media/platform/ti-vpe/sc.c
===================================================================
--- a/drivers/media/platform/ti-vpe/sc.c 2014-03-14 16:45:25.848724010 +0100
+++ b/drivers/media/platform/ti-vpe/sc.c 2014-03-18 11:02:09.555182273 +0100
@@ -302,9 +302,9 @@ struct sc_data *sc_create(struct platfor
}
sc->base = devm_ioremap_resource(&pdev->dev, sc->res);
- if (!sc->base) {
+ if (IS_ERR(sc->base)) {
dev_err(&pdev->dev, "failed to ioremap\n");
- return ERR_PTR(-ENOMEM);
+ return sc->base;
}
return sc;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] v4l: ti-vpe: fix devm_ioremap_resource() return value checking
2014-03-18 10:41 [PATCH] v4l: ti-vpe: fix devm_ioremap_resource() return value checking Bartlomiej Zolnierkiewicz
@ 2014-03-20 8:39 ` Archit Taneja
0 siblings, 0 replies; 2+ messages in thread
From: Archit Taneja @ 2014-03-20 8:39 UTC (permalink / raw)
To: Bartlomiej Zolnierkiewicz, Mauro Carvalho Chehab
Cc: Hans Verkuil, linux-media, linux-kernel
Hi,
On Tuesday 18 March 2014 04:11 PM, Bartlomiej Zolnierkiewicz wrote:
> devm_ioremap_resource() returns a pointer to the remapped memory or
> an ERR_PTR() encoded error code on failure. Fix the checks inside
> csc_create() and sc_create() accordingly.
>
> Cc: Archit Taneja <archit@ti.com>
> Cc: Hans Verkuil <hans.verkuil@cisco.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> Compile tested only.
Thanks for the patch.
It looks like this wasn't patch created using git-format-patch. I can
convert it if needed.
Tested-by: Archit Taneja<archit@ti.com>
Thanks,
Archit
>
> drivers/media/platform/ti-vpe/csc.c | 4 ++--
> drivers/media/platform/ti-vpe/sc.c | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> Index: b/drivers/media/platform/ti-vpe/csc.c
> ===================================================================
> --- a/drivers/media/platform/ti-vpe/csc.c 2014-03-14 16:45:25.848724010 +0100
> +++ b/drivers/media/platform/ti-vpe/csc.c 2014-03-18 11:01:36.595182833 +0100
> @@ -187,9 +187,9 @@ struct csc_data *csc_create(struct platf
> }
>
> csc->base = devm_ioremap_resource(&pdev->dev, csc->res);
> - if (!csc->base) {
> + if (IS_ERR(csc->base)) {
> dev_err(&pdev->dev, "failed to ioremap\n");
> - return ERR_PTR(-ENOMEM);
> + return csc->base;
> }
>
> return csc;
> Index: b/drivers/media/platform/ti-vpe/sc.c
> ===================================================================
> --- a/drivers/media/platform/ti-vpe/sc.c 2014-03-14 16:45:25.848724010 +0100
> +++ b/drivers/media/platform/ti-vpe/sc.c 2014-03-18 11:02:09.555182273 +0100
> @@ -302,9 +302,9 @@ struct sc_data *sc_create(struct platfor
> }
>
> sc->base = devm_ioremap_resource(&pdev->dev, sc->res);
> - if (!sc->base) {
> + if (IS_ERR(sc->base)) {
> dev_err(&pdev->dev, "failed to ioremap\n");
> - return ERR_PTR(-ENOMEM);
> + return sc->base;
> }
>
> return sc;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-03-20 8:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-18 10:41 [PATCH] v4l: ti-vpe: fix devm_ioremap_resource() return value checking Bartlomiej Zolnierkiewicz
2014-03-20 8:39 ` Archit Taneja
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).