* [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices
@ 2014-04-11 7:15 Jean Delvare
2014-04-11 14:10 ` Greg Kroah-Hartman
2014-04-13 12:28 ` Hans de Goede
0 siblings, 2 replies; 3+ messages in thread
From: Jean Delvare @ 2014-04-11 7:15 UTC (permalink / raw)
To: Hans de Goede, Mauro Carvalho Chehab, Luca Risolia, Greg Kroah-Hartman
Cc: linux-media, linux-usb, devel
The sn9c102 driver is deprecated. It was moved to staging in
anticipation of its removal in a future kernel version. However, USB
devices 0C45:6024 and 0C45:6025 are still handled by sn9c102 when
both sn9c102 and gspca_sonixb are enabled.
We must migrate all the users of these devices to the gspca_sonixb
driver now, so that it gets sufficient testing before the sn9c102
driver is finally phased out.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
Cc: Luca Risolia <luca.risolia@studio.unibo.it>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
I consider this a bug fix, I believe it should go upstream ASAP.
drivers/media/usb/gspca/sonixb.c | 2 --
drivers/staging/media/sn9c102/sn9c102_devtable.h | 2 --
2 files changed, 4 deletions(-)
--- linux-3.15-rc0.orig/drivers/media/usb/gspca/sonixb.c 2014-04-11 08:57:26.932408285 +0200
+++ linux-3.15-rc0/drivers/media/usb/gspca/sonixb.c 2014-04-11 09:02:32.151943578 +0200
@@ -1430,10 +1430,8 @@ static const struct usb_device_id device
{USB_DEVICE(0x0c45, 0x600d), SB(PAS106, 101)},
{USB_DEVICE(0x0c45, 0x6011), SB(OV6650, 101)},
{USB_DEVICE(0x0c45, 0x6019), SB(OV7630, 101)},
-#if !IS_ENABLED(CONFIG_USB_SN9C102)
{USB_DEVICE(0x0c45, 0x6024), SB(TAS5130CXX, 102)},
{USB_DEVICE(0x0c45, 0x6025), SB(TAS5130CXX, 102)},
-#endif
{USB_DEVICE(0x0c45, 0x6027), SB(OV7630, 101)}, /* Genius Eye 310 */
{USB_DEVICE(0x0c45, 0x6028), SB(PAS202, 102)},
{USB_DEVICE(0x0c45, 0x6029), SB(PAS106, 102)},
--- linux-3.15-rc0.orig/drivers/staging/media/sn9c102/sn9c102_devtable.h 2014-04-11 08:57:26.932408285 +0200
+++ linux-3.15-rc0/drivers/staging/media/sn9c102/sn9c102_devtable.h 2014-04-11 09:02:32.151943578 +0200
@@ -48,10 +48,8 @@ static const struct usb_device_id sn9c10
{ SN9C102_USB_DEVICE(0x0c45, 0x600d, BRIDGE_SN9C102), },
/* { SN9C102_USB_DEVICE(0x0c45, 0x6011, BRIDGE_SN9C102), }, OV6650 */
{ SN9C102_USB_DEVICE(0x0c45, 0x6019, BRIDGE_SN9C102), },
-#endif
{ SN9C102_USB_DEVICE(0x0c45, 0x6024, BRIDGE_SN9C102), },
{ SN9C102_USB_DEVICE(0x0c45, 0x6025, BRIDGE_SN9C102), },
-#if !defined CONFIG_USB_GSPCA_SONIXB && !defined CONFIG_USB_GSPCA_SONIXB_MODULE
{ SN9C102_USB_DEVICE(0x0c45, 0x6028, BRIDGE_SN9C102), },
{ SN9C102_USB_DEVICE(0x0c45, 0x6029, BRIDGE_SN9C102), },
{ SN9C102_USB_DEVICE(0x0c45, 0x602a, BRIDGE_SN9C102), },
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices
2014-04-11 7:15 [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices Jean Delvare
@ 2014-04-11 14:10 ` Greg Kroah-Hartman
2014-04-13 12:28 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Greg Kroah-Hartman @ 2014-04-11 14:10 UTC (permalink / raw)
To: Jean Delvare
Cc: Hans de Goede, Mauro Carvalho Chehab, Luca Risolia, devel,
linux-usb, linux-media
On Fri, Apr 11, 2014 at 09:15:32AM +0200, Jean Delvare wrote:
> The sn9c102 driver is deprecated. It was moved to staging in
> anticipation of its removal in a future kernel version. However, USB
> devices 0C45:6024 and 0C45:6025 are still handled by sn9c102 when
> both sn9c102 and gspca_sonixb are enabled.
>
> We must migrate all the users of these devices to the gspca_sonixb
> driver now, so that it gets sufficient testing before the sn9c102
> driver is finally phased out.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> Cc: Luca Risolia <luca.risolia@studio.unibo.it>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> I consider this a bug fix, I believe it should go upstream ASAP.
>
Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices
2014-04-11 7:15 [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices Jean Delvare
2014-04-11 14:10 ` Greg Kroah-Hartman
@ 2014-04-13 12:28 ` Hans de Goede
1 sibling, 0 replies; 3+ messages in thread
From: Hans de Goede @ 2014-04-13 12:28 UTC (permalink / raw)
To: Jean Delvare, Mauro Carvalho Chehab, Luca Risolia, Greg Kroah-Hartman
Cc: linux-media, linux-usb, devel
Hi,
On 04/11/2014 09:15 AM, Jean Delvare wrote:
> The sn9c102 driver is deprecated. It was moved to staging in
> anticipation of its removal in a future kernel version. However, USB
> devices 0C45:6024 and 0C45:6025 are still handled by sn9c102 when
> both sn9c102 and gspca_sonixb are enabled.
>
> We must migrate all the users of these devices to the gspca_sonixb
> driver now, so that it gets sufficient testing before the sn9c102
> driver is finally phased out.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Hans de Goede <hdegoede@redhat.com>
> Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>
> Cc: Luca Risolia <luca.risolia@studio.unibo.it>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> I consider this a bug fix, I believe it should go upstream ASAP.
Agreed:
Acked-by: Hans de Goede <hdegoede@redhat.com>
Mauro, can you pick this up directly, or do you want a pull-req from me
for this?
Regards,
Hans
>
> drivers/media/usb/gspca/sonixb.c | 2 --
> drivers/staging/media/sn9c102/sn9c102_devtable.h | 2 --
> 2 files changed, 4 deletions(-)
>
> --- linux-3.15-rc0.orig/drivers/media/usb/gspca/sonixb.c 2014-04-11 08:57:26.932408285 +0200
> +++ linux-3.15-rc0/drivers/media/usb/gspca/sonixb.c 2014-04-11 09:02:32.151943578 +0200
> @@ -1430,10 +1430,8 @@ static const struct usb_device_id device
> {USB_DEVICE(0x0c45, 0x600d), SB(PAS106, 101)},
> {USB_DEVICE(0x0c45, 0x6011), SB(OV6650, 101)},
> {USB_DEVICE(0x0c45, 0x6019), SB(OV7630, 101)},
> -#if !IS_ENABLED(CONFIG_USB_SN9C102)
> {USB_DEVICE(0x0c45, 0x6024), SB(TAS5130CXX, 102)},
> {USB_DEVICE(0x0c45, 0x6025), SB(TAS5130CXX, 102)},
> -#endif
> {USB_DEVICE(0x0c45, 0x6027), SB(OV7630, 101)}, /* Genius Eye 310 */
> {USB_DEVICE(0x0c45, 0x6028), SB(PAS202, 102)},
> {USB_DEVICE(0x0c45, 0x6029), SB(PAS106, 102)},
> --- linux-3.15-rc0.orig/drivers/staging/media/sn9c102/sn9c102_devtable.h 2014-04-11 08:57:26.932408285 +0200
> +++ linux-3.15-rc0/drivers/staging/media/sn9c102/sn9c102_devtable.h 2014-04-11 09:02:32.151943578 +0200
> @@ -48,10 +48,8 @@ static const struct usb_device_id sn9c10
> { SN9C102_USB_DEVICE(0x0c45, 0x600d, BRIDGE_SN9C102), },
> /* { SN9C102_USB_DEVICE(0x0c45, 0x6011, BRIDGE_SN9C102), }, OV6650 */
> { SN9C102_USB_DEVICE(0x0c45, 0x6019, BRIDGE_SN9C102), },
> -#endif
> { SN9C102_USB_DEVICE(0x0c45, 0x6024, BRIDGE_SN9C102), },
> { SN9C102_USB_DEVICE(0x0c45, 0x6025, BRIDGE_SN9C102), },
> -#if !defined CONFIG_USB_GSPCA_SONIXB && !defined CONFIG_USB_GSPCA_SONIXB_MODULE
> { SN9C102_USB_DEVICE(0x0c45, 0x6028, BRIDGE_SN9C102), },
> { SN9C102_USB_DEVICE(0x0c45, 0x6029, BRIDGE_SN9C102), },
> { SN9C102_USB_DEVICE(0x0c45, 0x602a, BRIDGE_SN9C102), },
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-13 12:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-11 7:15 [PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices Jean Delvare
2014-04-11 14:10 ` Greg Kroah-Hartman
2014-04-13 12:28 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).