* [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename
@ 2014-04-09 11:54 Krzysztof Kozlowski
2014-04-23 20:57 ` David Rientjes
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2014-04-09 11:54 UTC (permalink / raw)
To: Kyungmin Park, Andrzej Hajda, Mauro Carvalho Chehab, linux-media,
linux-kernel
Cc: Sylwester Nawrocki, Krzysztof Kozlowski
Fix build error after v4l2_of_get_next_endpoint rename (fd9fdb78a9bf:
"[media] of: move graph helpers from drivers/media/v4l2-core..."):
drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_get_platform_data’:
drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:2: error: implicit declaration of function ‘v4l2_of_get_next_endpoint’ [-Werror=implicit-function-declaration]
drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:10: warning: assignment makes pointer from integer without a cast [enabled by default]
Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
index a4459301b5f8..ee0f57e01b56 100644
--- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
+++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
@@ -1616,7 +1616,7 @@ static int s5c73m3_get_platform_data(struct s5c73m3 *state)
if (ret < 0)
return -EINVAL;
- node_ep = v4l2_of_get_next_endpoint(node, NULL);
+ node_ep = of_graph_get_next_endpoint(node, NULL);
if (!node_ep) {
dev_warn(dev, "no endpoint defined for node: %s\n",
node->full_name);
--
1.8.3.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename
2014-04-09 11:54 [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename Krzysztof Kozlowski
@ 2014-04-23 20:57 ` David Rientjes
2014-04-23 21:46 ` Sylwester Nawrocki
0 siblings, 1 reply; 3+ messages in thread
From: David Rientjes @ 2014-04-23 20:57 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Kyungmin Park, Andrzej Hajda, Mauro Carvalho Chehab, linux-media,
linux-kernel, Sylwester Nawrocki, Linus Torvalds, Grant Likely,
Rob Herring
[-- Attachment #1: Type: TEXT/PLAIN, Size: 1537 bytes --]
On Wed, 9 Apr 2014, Krzysztof Kozlowski wrote:
> Fix build error after v4l2_of_get_next_endpoint rename (fd9fdb78a9bf:
> "[media] of: move graph helpers from drivers/media/v4l2-core..."):
>
> drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_get_platform_data’:
> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:2: error: implicit declaration of function ‘v4l2_of_get_next_endpoint’ [-Werror=implicit-function-declaration]
> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:10: warning: assignment makes pointer from integer without a cast [enabled by default]
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> index a4459301b5f8..ee0f57e01b56 100644
> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
> @@ -1616,7 +1616,7 @@ static int s5c73m3_get_platform_data(struct s5c73m3 *state)
> if (ret < 0)
> return -EINVAL;
>
> - node_ep = v4l2_of_get_next_endpoint(node, NULL);
> + node_ep = of_graph_get_next_endpoint(node, NULL);
> if (!node_ep) {
> dev_warn(dev, "no endpoint defined for node: %s\n",
> node->full_name);
Acked-by: David Rientjes <rientjes@google.com>
The build error that this patch fixes is still present in Linus's tree,
and there's been no response to it in two weeks. Any chance of this
getting merged?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename
2014-04-23 20:57 ` David Rientjes
@ 2014-04-23 21:46 ` Sylwester Nawrocki
0 siblings, 0 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2014-04-23 21:46 UTC (permalink / raw)
To: David Rientjes
Cc: Krzysztof Kozlowski, Kyungmin Park, Andrzej Hajda,
Mauro Carvalho Chehab, linux-media, linux-kernel,
Sylwester Nawrocki, Linus Torvalds, Grant Likely, Rob Herring
On 04/23/2014 10:57 PM, David Rientjes wrote:
> On Wed, 9 Apr 2014, Krzysztof Kozlowski wrote:
>
>> Fix build error after v4l2_of_get_next_endpoint rename (fd9fdb78a9bf:
>> "[media] of: move graph helpers from drivers/media/v4l2-core..."):
>>
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c: In function ‘s5c73m3_get_platform_data’:
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:2: error: implicit declaration of function ‘v4l2_of_get_next_endpoint’ [-Werror=implicit-function-declaration]
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c:1619:10: warning: assignment makes pointer from integer without a cast [enabled by default]
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>> drivers/media/i2c/s5c73m3/s5c73m3-core.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> index a4459301b5f8..ee0f57e01b56 100644
>> --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c
>> @@ -1616,7 +1616,7 @@ static int s5c73m3_get_platform_data(struct s5c73m3 *state)
>> if (ret < 0)
>> return -EINVAL;
>>
>> - node_ep = v4l2_of_get_next_endpoint(node, NULL);
>> + node_ep = of_graph_get_next_endpoint(node, NULL);
>> if (!node_ep) {
>> dev_warn(dev, "no endpoint defined for node: %s\n",
>> node->full_name);
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> The build error that this patch fixes is still present in Linus's tree,
> and there's been no response to it in two weeks. Any chance of this
> getting merged?
I expect a patch fixing this issue to be sent in next batch of the media
fixes from Mauro. It has been queued in the media tree:
http://git.linuxtv.org/cgit.cgi/media_tree.git/commit/?h=fixes&id=41f484d12c0105ce01ea79acdc094fff9124491b
Thanks,
Sylwester
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-23 21:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-09 11:54 [PATCH] [media] V4L: s5c73m3: Fix build after v4l2_of_get_next_endpoint rename Krzysztof Kozlowski
2014-04-23 20:57 ` David Rientjes
2014-04-23 21:46 ` Sylwester Nawrocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).