* [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue
@ 2014-05-22 23:11 Chaitanya
2014-05-23 7:10 ` Dan Carpenter
0 siblings, 1 reply; 4+ messages in thread
From: Chaitanya @ 2014-05-22 23:11 UTC (permalink / raw)
To: Luca Risolia, Mauro Carvalho Chehab, Greg Kroah-Hartman
Cc: linux-usb, linux-media, devel, linux-kernel
Fixed the ERROR thrown off by checkpatch.pl.
Signed-off-by: Chaitanya Hazarey <c@24.io>
---
drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c
b/drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c
index a30bbc4..725de85 100644
--- a/drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c
+++ b/drivers/staging/media/sn9c102/sn9c102_tas5130d1b.c
@@ -23,7 +23,7 @@
#include "sn9c102_devtable.h"
-static int tas5130d1b_init(struct sn9c102_device* cam)
+static int tas5130d1b_init(struct sn9c102_device *cam)
{
int err;
@@ -36,8 +36,8 @@ static int tas5130d1b_init(struct sn9c102_device* cam)
}
-static int tas5130d1b_set_ctrl(struct sn9c102_device* cam,
- const struct v4l2_control* ctrl)
+static int tas5130d1b_set_ctrl(struct sn9c102_device *cam,
+ const struct v4l2_control *ctrl)
{
int err = 0;
@@ -56,10 +56,10 @@ static int tas5130d1b_set_ctrl(struct sn9c102_device* cam,
}
-static int tas5130d1b_set_crop(struct sn9c102_device* cam,
- const struct v4l2_rect* rect)
+static int tas5130d1b_set_crop(struct sn9c102_device *cam,
+ const struct v4l2_rect *rect)
{
- struct sn9c102_sensor* s = sn9c102_get_sensor(cam);
+ struct sn9c102_sensor *s = sn9c102_get_sensor(cam);
u8 h_start = (u8)(rect->left - s->cropcap.bounds.left) + 104,
v_start = (u8)(rect->top - s->cropcap.bounds.top) + 12;
int err = 0;
@@ -76,8 +76,8 @@ static int tas5130d1b_set_crop(struct sn9c102_device* cam,
}
-static int tas5130d1b_set_pix_format(struct sn9c102_device* cam,
- const struct v4l2_pix_format* pix)
+static int tas5130d1b_set_pix_format(struct sn9c102_device *cam,
+ const struct v4l2_pix_format *pix)
{
int err = 0;
@@ -146,7 +146,7 @@ static const struct sn9c102_sensor tas5130d1b = {
};
-int sn9c102_probe_tas5130d1b(struct sn9c102_device* cam)
+int sn9c102_probe_tas5130d1b(struct sn9c102_device *cam)
{
const struct usb_device_id tas5130d1b_id_table[] = {
{ USB_DEVICE(0x0c45, 0x6024), },
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue
2014-05-22 23:11 [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue Chaitanya
@ 2014-05-23 7:10 ` Dan Carpenter
2014-05-23 16:59 ` Chaitanya Hazarey
0 siblings, 1 reply; 4+ messages in thread
From: Dan Carpenter @ 2014-05-23 7:10 UTC (permalink / raw)
To: Chaitanya
Cc: Luca Risolia, Mauro Carvalho Chehab, Greg Kroah-Hartman, devel,
linux-usb, linux-kernel, linux-media
On Thu, May 22, 2014 at 04:11:38PM -0700, Chaitanya wrote:
> Fixed the ERROR thrown off by checkpatch.pl.
>
Put the error message here, or say what it was.
> Signed-off-by: Chaitanya Hazarey <c@24.io>
Could you change your email client so it has your last in the From:
header?
This patch doesn't apply. Read this:
https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt
regards,
dan carpenter
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue
2014-05-23 7:10 ` Dan Carpenter
@ 2014-05-23 16:59 ` Chaitanya Hazarey
2014-05-23 17:11 ` Hans Verkuil
0 siblings, 1 reply; 4+ messages in thread
From: Chaitanya Hazarey @ 2014-05-23 16:59 UTC (permalink / raw)
To: Dan Carpenter
Cc: Luca Risolia, Mauro Carvalho Chehab, Greg Kroah-Hartman, devel,
linux-usb, linux-kernel, linux-media
Hey Dan,
Sorry my bad, will resubmit the patch in a proper manner with the
required corrections.
Thanks for looking into this.
Thanks,
Chaitanya
On Fri, May 23, 2014 at 12:10 AM, Dan Carpenter
<dan.carpenter@oracle.com> wrote:
> On Thu, May 22, 2014 at 04:11:38PM -0700, Chaitanya wrote:
>> Fixed the ERROR thrown off by checkpatch.pl.
>>
>
> Put the error message here, or say what it was.
>
>> Signed-off-by: Chaitanya Hazarey <c@24.io>
>
> Could you change your email client so it has your last in the From:
> header?
>
> This patch doesn't apply. Read this:
> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt
>
> regards,
> dan carpenter
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue
2014-05-23 16:59 ` Chaitanya Hazarey
@ 2014-05-23 17:11 ` Hans Verkuil
0 siblings, 0 replies; 4+ messages in thread
From: Hans Verkuil @ 2014-05-23 17:11 UTC (permalink / raw)
To: Chaitanya Hazarey, Dan Carpenter
Cc: Luca Risolia, Mauro Carvalho Chehab, Greg Kroah-Hartman, devel,
linux-usb, linux-kernel, linux-media
On 05/23/2014 06:59 PM, Chaitanya Hazarey wrote:
> Hey Dan,
>
> Sorry my bad, will resubmit the patch in a proper manner with the
> required corrections.
>
Don't bother. This patch: http://comments.gmane.org/gmane.linux.drivers.driver-project.devel/48570
has just been merged and that has the same fixes as your patch.
But thanks anyway :-)
Regards,
Hans
> Thanks for looking into this.
>
> Thanks,
>
> Chaitanya
>
> On Fri, May 23, 2014 at 12:10 AM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
>> On Thu, May 22, 2014 at 04:11:38PM -0700, Chaitanya wrote:
>>> Fixed the ERROR thrown off by checkpatch.pl.
>>>
>>
>> Put the error message here, or say what it was.
>>
>>> Signed-off-by: Chaitanya Hazarey <c@24.io>
>>
>> Could you change your email client so it has your last in the From:
>> header?
>>
>> This patch doesn't apply. Read this:
>> https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/Documentation/email-clients.txt
>>
>> regards,
>> dan carpenter
>>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-05-23 17:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-05-22 23:11 [PATCH] Staging: Media: sn9c102: Fixed a pointer declaration coding style issue Chaitanya
2014-05-23 7:10 ` Dan Carpenter
2014-05-23 16:59 ` Chaitanya Hazarey
2014-05-23 17:11 ` Hans Verkuil
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).