* [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant
@ 2014-07-11 12:56 Antonio Ospite
2014-07-14 10:27 ` Hans de Goede
0 siblings, 1 reply; 5+ messages in thread
From: Antonio Ospite @ 2014-07-11 12:56 UTC (permalink / raw)
To: linux-media; +Cc: Antonio Ospite, Hans de Goede
Signed-off-by: Antonio Ospite <ao2@ao2.it>
---
drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c
index 49d209b..6ac93d8 100644
--- a/drivers/media/usb/gspca/stv06xx/stv06xx.c
+++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c
@@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev,
{
int ret = -EINVAL;
- if (len == 1 && data[0] == 0x80) {
+ if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) {
input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1);
input_sync(gspca_dev->input_dev);
ret = 0;
}
- if (len == 1 && data[0] == 0x88) {
+ if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) {
input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0);
input_sync(gspca_dev->input_dev);
ret = 0;
--
2.0.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant
2014-07-11 12:56 [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant Antonio Ospite
@ 2014-07-14 10:27 ` Hans de Goede
2014-10-28 14:39 ` Antonio Ospite
0 siblings, 1 reply; 5+ messages in thread
From: Hans de Goede @ 2014-07-14 10:27 UTC (permalink / raw)
To: Antonio Ospite, linux-media
Hi,
On 07/11/2014 02:56 PM, Antonio Ospite wrote:
> Signed-off-by: Antonio Ospite <ao2@ao2.it>
Thanks, I've added this to my tree and send a pull-req for it
to Mauro.
Regards,
Hans
> ---
> drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> index 49d209b..6ac93d8 100644
> --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c
> +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev,
> {
> int ret = -EINVAL;
>
> - if (len == 1 && data[0] == 0x80) {
> + if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) {
> input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1);
> input_sync(gspca_dev->input_dev);
> ret = 0;
> }
>
> - if (len == 1 && data[0] == 0x88) {
> + if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) {
> input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0);
> input_sync(gspca_dev->input_dev);
> ret = 0;
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant
2014-07-14 10:27 ` Hans de Goede
@ 2014-10-28 14:39 ` Antonio Ospite
2015-01-06 20:59 ` Antonio Ospite
0 siblings, 1 reply; 5+ messages in thread
From: Antonio Ospite @ 2014-10-28 14:39 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-media
On Mon, 14 Jul 2014 12:27:57 +0200
Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 07/11/2014 02:56 PM, Antonio Ospite wrote:
> > Signed-off-by: Antonio Ospite <ao2@ao2.it>
>
> Thanks, I've added this to my tree and send a pull-req for it
> to Mauro.
>
Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost.
Here is the patchwork link in case you want to pick the change for 3.19:
https://patchwork.linuxtv.org/patch/24732/
Thanks,
Antonio
> Regards,
>
> Hans
>
> > ---
> > drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > index 49d209b..6ac93d8 100644
> > --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev,
> > {
> > int ret = -EINVAL;
> >
> > - if (len == 1 && data[0] == 0x80) {
> > + if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) {
> > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1);
> > input_sync(gspca_dev->input_dev);
> > ret = 0;
> > }
> >
> > - if (len == 1 && data[0] == 0x88) {
> > + if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) {
> > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0);
> > input_sync(gspca_dev->input_dev);
> > ret = 0;
> >
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant
2014-10-28 14:39 ` Antonio Ospite
@ 2015-01-06 20:59 ` Antonio Ospite
2015-01-15 10:54 ` Hans de Goede
0 siblings, 1 reply; 5+ messages in thread
From: Antonio Ospite @ 2015-01-06 20:59 UTC (permalink / raw)
To: Hans de Goede; +Cc: linux-media
On Tue, 28 Oct 2014 15:39:41 +0100
Antonio Ospite <ao2@ao2.it> wrote:
> On Mon, 14 Jul 2014 12:27:57 +0200
> Hans de Goede <hdegoede@redhat.com> wrote:
>
> > Hi,
> >
> > On 07/11/2014 02:56 PM, Antonio Ospite wrote:
> > > Signed-off-by: Antonio Ospite <ao2@ao2.it>
> >
> > Thanks, I've added this to my tree and send a pull-req for it
> > to Mauro.
> >
>
> Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost.
>
> Here is the patchwork link in case you want to pick the change for 3.19:
> https://patchwork.linuxtv.org/patch/24732/
>
Ping.
Still missing in 3.19-rc3.
Can we have it for 3.20?
Thanks,
Antonio
> > Regards,
> >
> > Hans
> >
> > > ---
> > > drivers/media/usb/gspca/stv06xx/stv06xx.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/media/usb/gspca/stv06xx/stv06xx.c b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > > index 49d209b..6ac93d8 100644
> > > --- a/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > > +++ b/drivers/media/usb/gspca/stv06xx/stv06xx.c
> > > @@ -505,13 +505,13 @@ static int sd_int_pkt_scan(struct gspca_dev *gspca_dev,
> > > {
> > > int ret = -EINVAL;
> > >
> > > - if (len == 1 && data[0] == 0x80) {
> > > + if (len == 1 && (data[0] == 0x80 || data[0] == 0x10)) {
> > > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 1);
> > > input_sync(gspca_dev->input_dev);
> > > ret = 0;
> > > }
> > >
> > > - if (len == 1 && data[0] == 0x88) {
> > > + if (len == 1 && (data[0] == 0x88 || data[0] == 0x11)) {
> > > input_report_key(gspca_dev->input_dev, KEY_CAMERA, 0);
> > > input_sync(gspca_dev->input_dev);
> > > ret = 0;
> > >
>
>
> --
> Antonio Ospite
> http://ao2.it
>
> A: Because it messes up the order in which people normally read text.
> See http://en.wikipedia.org/wiki/Posting_style
> Q: Why is top-posting such a bad thing?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Antonio Ospite
http://ao2.it
A: Because it messes up the order in which people normally read text.
See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant
2015-01-06 20:59 ` Antonio Ospite
@ 2015-01-15 10:54 ` Hans de Goede
0 siblings, 0 replies; 5+ messages in thread
From: Hans de Goede @ 2015-01-15 10:54 UTC (permalink / raw)
To: Antonio Ospite; +Cc: linux-media
Hi,
On 06-01-15 21:59, Antonio Ospite wrote:
> On Tue, 28 Oct 2014 15:39:41 +0100
> Antonio Ospite <ao2@ao2.it> wrote:
>
>> On Mon, 14 Jul 2014 12:27:57 +0200
>> Hans de Goede <hdegoede@redhat.com> wrote:
>>
>>> Hi,
>>>
>>> On 07/11/2014 02:56 PM, Antonio Ospite wrote:
>>>> Signed-off-by: Antonio Ospite <ao2@ao2.it>
>>>
>>> Thanks, I've added this to my tree and send a pull-req for it
>>> to Mauro.
>>>
>>
>> Hi Hans, I still don't see the change in 3.18-rc2, maybe it got lost.
>>
>> Here is the patchwork link in case you want to pick the change for 3.19:
>> https://patchwork.linuxtv.org/patch/24732/
>>
>
> Ping.
>
> Still missing in 3.19-rc3.
Yes, weird, I had it in a pull-req for 3.17:
http://git.linuxtv.org/cgit.cgi/hgoede/gspca.git/log/?h=media-for_v3.17
Anyways I've queued it up for 3.20 now.
Regards,
Hans
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-01-15 10:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-11 12:56 [PATCH] gspca_stv06xx: enable button found on some Quickcam Express variant Antonio Ospite
2014-07-14 10:27 ` Hans de Goede
2014-10-28 14:39 ` Antonio Ospite
2015-01-06 20:59 ` Antonio Ospite
2015-01-15 10:54 ` Hans de Goede
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).