* [PATCH] [media] imageon-bridge: Add module license information
@ 2015-07-28 5:39 Mike Looijmans
2015-07-28 7:14 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Mike Looijmans @ 2015-07-28 5:39 UTC (permalink / raw)
To: linux-media; +Cc: dragos.bogdan, mchehab, lars, Mike Looijmans
Comment header specifies GPL-2, so add a MODULE_LICENSE("GPL v2").
This fixes the driver failing to load when built as module:
imageon_bridge: module license 'unspecified' taints kernel.
imageon_bridge: Unknown symbol ...
As an extra service, also add a description.
Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
---
drivers/media/platform/imageon-bridge.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/imageon-bridge.c b/drivers/media/platform/imageon-bridge.c
index 9550695..a69b6da 100644
--- a/drivers/media/platform/imageon-bridge.c
+++ b/drivers/media/platform/imageon-bridge.c
@@ -317,3 +317,6 @@ static struct platform_driver imageon_bridge_driver = {
.remove = imageon_bridge_remove,
};
module_platform_driver(imageon_bridge_driver);
+
+MODULE_DESCRIPTION("Imageon video bridge");
+MODULE_LICENSE("GPL v2");
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] imageon-bridge: Add module license information
2015-07-28 5:39 [PATCH] [media] imageon-bridge: Add module license information Mike Looijmans
@ 2015-07-28 7:14 ` Hans Verkuil
2015-07-28 7:47 ` Lars-Peter Clausen
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2015-07-28 7:14 UTC (permalink / raw)
To: Mike Looijmans, linux-media; +Cc: dragos.bogdan, mchehab, lars
On 07/28/2015 07:39 AM, Mike Looijmans wrote:
> Comment header specifies GPL-2, so add a MODULE_LICENSE("GPL v2").
> This fixes the driver failing to load when built as module:
> imageon_bridge: module license 'unspecified' taints kernel.
> imageon_bridge: Unknown symbol ...
> As an extra service, also add a description.
>
> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
> ---
> drivers/media/platform/imageon-bridge.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/media/platform/imageon-bridge.c b/drivers/media/platform/imageon-bridge.c
> index 9550695..a69b6da 100644
> --- a/drivers/media/platform/imageon-bridge.c
> +++ b/drivers/media/platform/imageon-bridge.c
> @@ -317,3 +317,6 @@ static struct platform_driver imageon_bridge_driver = {
> .remove = imageon_bridge_remove,
> };
> module_platform_driver(imageon_bridge_driver);
> +
> +MODULE_DESCRIPTION("Imageon video bridge");
> +MODULE_LICENSE("GPL v2");
>
Lovely, but unfortunately the imageon driver is not part of the official linux kernel.
So we can't do anything with this patch.
Regards,
Hans
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] [media] imageon-bridge: Add module license information
2015-07-28 7:14 ` Hans Verkuil
@ 2015-07-28 7:47 ` Lars-Peter Clausen
0 siblings, 0 replies; 3+ messages in thread
From: Lars-Peter Clausen @ 2015-07-28 7:47 UTC (permalink / raw)
To: Hans Verkuil, Mike Looijmans, linux-media; +Cc: dragos.bogdan, mchehab
On 07/28/2015 09:14 AM, Hans Verkuil wrote:
> On 07/28/2015 07:39 AM, Mike Looijmans wrote:
>> Comment header specifies GPL-2, so add a MODULE_LICENSE("GPL v2").
>> This fixes the driver failing to load when built as module:
>> imageon_bridge: module license 'unspecified' taints kernel.
>> imageon_bridge: Unknown symbol ...
>> As an extra service, also add a description.
>>
>> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl>
>> ---
>> drivers/media/platform/imageon-bridge.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/media/platform/imageon-bridge.c b/drivers/media/platform/imageon-bridge.c
>> index 9550695..a69b6da 100644
>> --- a/drivers/media/platform/imageon-bridge.c
>> +++ b/drivers/media/platform/imageon-bridge.c
>> @@ -317,3 +317,6 @@ static struct platform_driver imageon_bridge_driver = {
>> .remove = imageon_bridge_remove,
>> };
>> module_platform_driver(imageon_bridge_driver);
>> +
>> +MODULE_DESCRIPTION("Imageon video bridge");
>> +MODULE_LICENSE("GPL v2");
>>
>
> Lovely, but unfortunately the imageon driver is not part of the official linux kernel.
>
> So we can't do anything with this patch.
I've applied the patch, thanks. Hopefully the driver will find its way
upstream soon.
- Lars
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-07-28 7:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-28 5:39 [PATCH] [media] imageon-bridge: Add module license information Mike Looijmans
2015-07-28 7:14 ` Hans Verkuil
2015-07-28 7:47 ` Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).