* [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning
@ 2015-09-06 10:08 Geert Uytterhoeven
2015-09-07 1:49 ` Josh Wu
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-09-06 10:08 UTC (permalink / raw)
To: Josh Wu, Guennadi Liakhovetski, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel, Geert Uytterhoeven
If CONFIG_PM=n:
drivers/media/platform/soc_camera/atmel-isi.c:1044: warning: ‘atmel_isi_runtime_suspend’ defined but not used
drivers/media/platform/soc_camera/atmel-isi.c:1054: warning: ‘atmel_isi_runtime_resume’ defined but not used
Protect the unused functions by #ifdef CONFIG_PM to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
Resend with correct suject
---
drivers/media/platform/soc_camera/atmel-isi.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c
index 90701726a06a2e5c..ccf30ccbe389233f 100644
--- a/drivers/media/platform/soc_camera/atmel-isi.c
+++ b/drivers/media/platform/soc_camera/atmel-isi.c
@@ -1040,6 +1040,7 @@ err_alloc_ctx:
return ret;
}
+#ifdef CONFIG_PM
static int atmel_isi_runtime_suspend(struct device *dev)
{
struct soc_camera_host *soc_host = to_soc_camera_host(dev);
@@ -1058,6 +1059,7 @@ static int atmel_isi_runtime_resume(struct device *dev)
return clk_prepare_enable(isi->pclk);
}
+#endif /* CONFIG_PM */
static const struct dev_pm_ops atmel_isi_dev_pm_ops = {
SET_RUNTIME_PM_OPS(atmel_isi_runtime_suspend,
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning
2015-09-06 10:08 [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning Geert Uytterhoeven
@ 2015-09-07 1:49 ` Josh Wu
0 siblings, 0 replies; 2+ messages in thread
From: Josh Wu @ 2015-09-07 1:49 UTC (permalink / raw)
To: Geert Uytterhoeven, Guennadi Liakhovetski, Mauro Carvalho Chehab
Cc: linux-media, linux-kernel
Hi, Geert Uytterhoeven
Thanks for the patch.
On 9/6/2015 6:08 PM, Geert Uytterhoeven wrote:
> If CONFIG_PM=n:
>
> drivers/media/platform/soc_camera/atmel-isi.c:1044: warning: ‘atmel_isi_runtime_suspend’ defined but not used
> drivers/media/platform/soc_camera/atmel-isi.c:1054: warning: ‘atmel_isi_runtime_resume’ defined but not used
>
> Protect the unused functions by #ifdef CONFIG_PM to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Josh Wu <josh.wu@atmel.com>
Best Regards,
Josh Wu
> ---
> Resend with correct suject
> ---
> drivers/media/platform/soc_camera/atmel-isi.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/platform/soc_camera/atmel-isi.c b/drivers/media/platform/soc_camera/atmel-isi.c
> index 90701726a06a2e5c..ccf30ccbe389233f 100644
> --- a/drivers/media/platform/soc_camera/atmel-isi.c
> +++ b/drivers/media/platform/soc_camera/atmel-isi.c
> @@ -1040,6 +1040,7 @@ err_alloc_ctx:
> return ret;
> }
>
> +#ifdef CONFIG_PM
> static int atmel_isi_runtime_suspend(struct device *dev)
> {
> struct soc_camera_host *soc_host = to_soc_camera_host(dev);
> @@ -1058,6 +1059,7 @@ static int atmel_isi_runtime_resume(struct device *dev)
>
> return clk_prepare_enable(isi->pclk);
> }
> +#endif /* CONFIG_PM */
>
> static const struct dev_pm_ops atmel_isi_dev_pm_ops = {
> SET_RUNTIME_PM_OPS(atmel_isi_runtime_suspend,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-07 1:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-06 10:08 [PATCH] [media] atmel-isi: Protect PM-only functions to kill warning Geert Uytterhoeven
2015-09-07 1:49 ` Josh Wu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).