linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/9] media: rc: nuvoton-cir: remove unneeded lock
@ 2015-10-29 21:19 Heiner Kallweit
  0 siblings, 0 replies; only message in thread
From: Heiner Kallweit @ 2015-10-29 21:19 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: linux-media

chip_major / chip_minor are accessed sequentially in probe only.
Therefore no lock is needed.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
---
 drivers/media/rc/nuvoton-cir.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/media/rc/nuvoton-cir.c b/drivers/media/rc/nuvoton-cir.c
index 3d9a4cf..4d8e12f 100644
--- a/drivers/media/rc/nuvoton-cir.c
+++ b/drivers/media/rc/nuvoton-cir.c
@@ -227,7 +227,6 @@ static void cir_wake_dump_regs(struct nvt_dev *nvt)
 /* detect hardware features */
 static int nvt_hw_detect(struct nvt_dev *nvt)
 {
-	unsigned long flags;
 	u8 chip_major, chip_minor;
 	char chip_id[12];
 	bool chip_unknown = false;
@@ -279,10 +278,8 @@ static int nvt_hw_detect(struct nvt_dev *nvt)
 
 	nvt_efm_disable(nvt);
 
-	spin_lock_irqsave(&nvt->nvt_lock, flags);
 	nvt->chip_major = chip_major;
 	nvt->chip_minor = chip_minor;
-	spin_unlock_irqrestore(&nvt->nvt_lock, flags);
 
 	return 0;
 }
-- 
2.6.2



^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2015-10-29 21:23 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-29 21:19 [PATCH 2/9] media: rc: nuvoton-cir: remove unneeded lock Heiner Kallweit

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).