* Re: [v5 3/4] dt-bindings: arm: add Magicbox M16S bindings
[not found] ` <tencent_529DC7E641BA7022B2C1C7C0E7427C2CB805@qq.com>
@ 2022-07-25 16:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-25 16:31 UTC (permalink / raw)
To: Zhang Ning, martin.blumenstingl, narmstrong, linux-amlogic,
robh+dt, krzysztof.kozlowski+dt, sean, devicetree, linux-media
On 25/07/2022 01:17, Zhang Ning wrote:
> Add the board binding for Magicbox M16S Tv Box
>
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
Don't forget proper mail titles (PATCH and prefix). git format-patch
solves the first, git log --oneline gives you hint about second. So this
should be:
[PATCH v5 3/4] dt-bindings: arm: amlogic: add Magicbox M16S bindings
> ---
> Documentation/devicetree/bindings/arm/amlogic.yaml | 1 +
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v5 4/4] arm64: dts: meson: Add MagicBox M16S support
[not found] ` <tencent_9D885D188E51B537DB904A774CEC35E4180A@qq.com>
@ 2022-07-25 16:32 ` Krzysztof Kozlowski
[not found] ` <tencent_1B5B069917D86370ED4136BDD2C413240D08@qq.com>
0 siblings, 1 reply; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-25 16:32 UTC (permalink / raw)
To: Zhang Ning, martin.blumenstingl, narmstrong, linux-amlogic,
robh+dt, krzysztof.kozlowski+dt, sean, devicetree, linux-media
On 25/07/2022 01:17, Zhang Ning wrote:
> MagicBox M16S or MagicBox 3Pro is popular Tv box in China.
> with spec:
>
> - Amlogic S912-H (S912 with dolby and dts)
> - 2G ddr3
> - 16G emmc
> - Marvell sd8897 BT/wifi module
> - 100M ethernet
> - IR reciever
> - 4K HDMI
> - AV out
> - Rest hole
> - 5V2A power input
> - white LED
>
> it's q201_v1 according u-boot log.
> and it's almost same as Q201 reference design.
>
> add a simple dts to support this Tv box.
>
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
> ---
> arch/arm64/boot/dts/amlogic/Makefile | 1 +
> .../dts/amlogic/meson-gxm-magicbox-m16s.dts | 40 +++++++++++++++++++
> 2 files changed, 41 insertions(+)
> create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
>
> diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
> index 8773211df50e..e0907fb41829 100644
> --- a/arch/arm64/boot/dts/amlogic/Makefile
> +++ b/arch/arm64/boot/dts/amlogic/Makefile
> @@ -44,6 +44,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-libretech-cc.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-khadas-vim2.dtb
> +dtb-$(CONFIG_ARCH_MESON) += meson-gxm-magicbox-m16s.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-mecool-kiii-pro.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-minix-neo-u9h.dtb
> dtb-$(CONFIG_ARCH_MESON) += meson-gxm-nexbox-a1.dtb
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
> new file mode 100644
> index 000000000000..69e72687ac9c
> --- /dev/null
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
> @@ -0,0 +1,40 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Copyright (c) 2022 Zhang Ning <zhangn1985@qq.com>
> + */
> +
> +/dts-v1/;
> +
> +#include "meson-gxm.dtsi"
> +#include "meson-gx-p23x-q20x.dtsi"
> +#include <dt-bindings/input/input.h>
> +
> +/ {
> + compatible = "magicbox,m16s", "amlogic,s912", "amlogic,meson-gxm";
> + model = "MagicBox M16S";
> +
> + gpio-keys-polled {
Just gpio-keys (or even "keys").
> + compatible = "gpio-keys-polled";
> + #address-cells = <1>;
> + #size-cells = <0>;
Address/size cells are not correct.
> + poll-interval = <100>;
> +
> + button-power {
> + label = "power";
> + linux,code = <KEY_POWER>;
> + gpios = <&gpio_ao GPIOAO_2 GPIO_ACTIVE_LOW>;
> + };
> + };
> +};
Missing blank line.
> +ðmac {
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v5 4/4] arm64: dts: meson: Add MagicBox M16S support
[not found] ` <tencent_1B5B069917D86370ED4136BDD2C413240D08@qq.com>
@ 2022-07-26 6:48 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2022-07-26 6:48 UTC (permalink / raw)
To: Zhang Ning
Cc: martin.blumenstingl, narmstrong, linux-amlogic, robh+dt,
krzysztof.kozlowski+dt, sean, devicetree, linux-media
On 26/07/2022 02:04, Zhang Ning wrote:
>>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-magicbox-m16s.dts
>>> @@ -0,0 +1,40 @@
>>> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
>>> +/*
>>> + * Copyright (c) 2022 Zhang Ning <zhangn1985@qq.com>
>>> + */
>>> +
>>> +/dts-v1/;
>>> +
>>> +#include "meson-gxm.dtsi"
>>> +#include "meson-gx-p23x-q20x.dtsi"
>>> +#include <dt-bindings/input/input.h>
>>> +
>>> +/ {
>>> + compatible = "magicbox,m16s", "amlogic,s912", "amlogic,meson-gxm";
>>> + model = "MagicBox M16S";
>>> +
>>> + gpio-keys-polled {
>>
>> Just gpio-keys (or even "keys").
> I see all dts for amlogic platform are using gpio-keys-polled, could I
> keep current name?
Node names should be generic.
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [v5 2/4] media: rc: add keymap for MagicBox M16S remote
[not found] ` <tencent_5AC39B81CB85E258763BA8CD8774E9045806@qq.com>
@ 2022-07-26 7:42 ` Sean Young
0 siblings, 0 replies; 4+ messages in thread
From: Sean Young @ 2022-07-26 7:42 UTC (permalink / raw)
To: Zhang Ning
Cc: martin.blumenstingl, narmstrong, linux-amlogic, robh+dt,
krzysztof.kozlowski+dt, devicetree, linux-media
On Mon, Jul 25, 2022 at 07:17:02AM +0800, Zhang Ning wrote:
> MagicBox M16S Tv box shipped with a simple NEC remote.
> it has a key labeled "M", used as Magic key in vendor OS.
> This has mapped to KEY_MUTE.
Please put this commit in the source code next to the key definition.
This doesn't belong in the commit message.
Thanks
Sean
>
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
> ---
> drivers/media/rc/keymaps/Makefile | 1 +
> drivers/media/rc/keymaps/rc-magicbox.c | 53 ++++++++++++++++++++++++++
> include/media/rc-map.h | 1 +
> 3 files changed, 55 insertions(+)
> create mode 100644 drivers/media/rc/keymaps/rc-magicbox.c
>
> diff --git a/drivers/media/rc/keymaps/Makefile b/drivers/media/rc/keymaps/Makefile
> index f513ff5caf4e..02c1c2150f03 100644
> --- a/drivers/media/rc/keymaps/Makefile
> +++ b/drivers/media/rc/keymaps/Makefile
> @@ -71,6 +71,7 @@ obj-$(CONFIG_RC_MAP) += \
> rc-kworld-plus-tv-analog.o \
> rc-leadtek-y04g0051.o \
> rc-lme2510.o \
> + rc-magicbox.o \
> rc-manli.o \
> rc-mecool-kiii-pro.o \
> rc-mecool-kii-pro.o \
> diff --git a/drivers/media/rc/keymaps/rc-magicbox.c b/drivers/media/rc/keymaps/rc-magicbox.c
> new file mode 100644
> index 000000000000..b4fc1856a9e7
> --- /dev/null
> +++ b/drivers/media/rc/keymaps/rc-magicbox.c
> @@ -0,0 +1,53 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// Copyright (C) 2022 Zhang Ning <zhangn1985@qq.com>
> +
> +/*
> + * Keytable for the MagicBox M16S remote control
> + */
> +
> +#include <media/rc-map.h>
> +#include <linux/module.h>
> +
> +static struct rc_map_table magicbox[] = {
> + { 0x9f57, KEY_POWER },
> + { 0x9f8a, KEY_MUTE }, // M
> +
> + { 0x9f43, KEY_UP },
> + { 0x9f0a, KEY_DOWN },
> + { 0x9f06, KEY_LEFT },
> + { 0x9f0e, KEY_RIGHT },
> + { 0x9f02, KEY_OK },
> +
> + { 0x9f47, KEY_HOME },
> + { 0x9f4f, KEY_BACK },
> + { 0x9f16, KEY_MENU },
> +
> + { 0x9fff, KEY_VOLUMEDOWN },
> + { 0x9f5d, KEY_VOLUMEUP },
> +};
> +
> +static struct rc_map_list magicbox_map = {
> + .map = {
> + .scan = magicbox,
> + .size = ARRAY_SIZE(magicbox),
> + .rc_proto = RC_PROTO_NEC,
> + .name = RC_MAP_MAGICBOX,
> + }
> +};
> +
> +static int __init init_rc_map_magicbox(void)
> +{
> + return rc_map_register(&magicbox_map);
> +}
> +
> +static void __exit exit_rc_map_magicbox(void)
> +{
> + rc_map_unregister(&magicbox_map);
> +}
> +
> +module_init(init_rc_map_magicbox)
> +module_exit(exit_rc_map_magicbox)
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Zhang Ning <zhangn1985@qq.com>");
> diff --git a/include/media/rc-map.h b/include/media/rc-map.h
> index 793b54342dff..656217b8e91b 100644
> --- a/include/media/rc-map.h
> +++ b/include/media/rc-map.h
> @@ -277,6 +277,7 @@ struct rc_map *rc_map_get(const char *name);
> #define RC_MAP_KWORLD_PLUS_TV_ANALOG "rc-kworld-plus-tv-analog"
> #define RC_MAP_LEADTEK_Y04G0051 "rc-leadtek-y04g0051"
> #define RC_MAP_LME2510 "rc-lme2510"
> +#define RC_MAP_MAGICBOX "rc-magicbox"
> #define RC_MAP_MANLI "rc-manli"
> #define RC_MAP_MECOOL_KII_PRO "rc-mecool-kii-pro"
> #define RC_MAP_MECOOL_KIII_PRO "rc-mecool-kiii-pro"
> --
> 2.35.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-26 7:43 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220724231704.132472-1-zhangn1985@qq.com>
[not found] ` <tencent_529DC7E641BA7022B2C1C7C0E7427C2CB805@qq.com>
2022-07-25 16:31 ` [v5 3/4] dt-bindings: arm: add Magicbox M16S bindings Krzysztof Kozlowski
[not found] ` <tencent_9D885D188E51B537DB904A774CEC35E4180A@qq.com>
2022-07-25 16:32 ` [v5 4/4] arm64: dts: meson: Add MagicBox M16S support Krzysztof Kozlowski
[not found] ` <tencent_1B5B069917D86370ED4136BDD2C413240D08@qq.com>
2022-07-26 6:48 ` Krzysztof Kozlowski
[not found] ` <tencent_5AC39B81CB85E258763BA8CD8774E9045806@qq.com>
2022-07-26 7:42 ` [v5 2/4] media: rc: add keymap for MagicBox M16S remote Sean Young
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).