From: Nicolas Dufresne <nicolas@ndufresne.ca>
To: Tomasz Figa <tfiga@chromium.org>
Cc: "Hans Verkuil" <hverkuil@xs4all.nl>,
"Linux Media Mailing List" <linux-media@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Pawel Osciak" <posciak@chromium.org>,
"Alexandre Courbot" <acourbot@chromium.org>,
"Kamil Debski" <kamil@wypas.org>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Jeongtae Park" <jtp.park@samsung.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>,
"Andrew-CT Chen (陳智迪)" <andrew-ct.chen@mediatek.com>,
"Stanimir Varbanov" <stanimir.varbanov@linaro.org>,
"Todor Tomov" <todor.tomov@linaro.org>,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
dave.stevenson@raspberrypi.org,
"Ezequiel Garcia" <ezequiel@collabora.com>,
"Maxime Jourdan" <maxi.jourdan@wanadoo.fr>
Subject: Re: [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface
Date: Mon, 15 Apr 2019 08:30:03 -0400 [thread overview]
Message-ID: <6ae8b9daa0cf406ab604e802bbb6d46736266bd5.camel@ndufresne.ca> (raw)
In-Reply-To: <CAAFQd5BmDvou6qdaw6uSAWTyLBXeTH8RvnBi7dCGCRdedvHPMg@mail.gmail.com>
Le lundi 15 avril 2019 à 17:56 +0900, Tomasz Figa a écrit :
> > Sounds like we need something similar to the SOURCE_CHANGE event
> > mechanism if we want to allow dynamic bitrate control which would
> > require re-allocation of the capture buffer queue. (Or any other
> > runtime control on our encoders, which is really expected to be
> > supported these days).
>
> Sounds like it. Or we could just assume that one needs to stop both
> queues to do a resolution change, since most codes would anyway reset
> the stream (e.g. send PPS/SPS, etc. for H.264) to change the
> resolution. Not sure if that assumption always holds, though.
I think for resolution/profile/level changes you have a good point, as
you said, we need to start a new stream (new header, new IDR). Maybe
then we should simply require the driver to allocate enough buffer to
support the highest bitrate for the selected resoltion/profile/level?
Though, this could create situation where we waste a lot of memory. On
the other side, if you need to reallocate your buffers on bitrate
change, it might create a visible freeze.
Nicolas
next prev parent reply other threads:[~2019-04-15 12:30 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 10:04 [PATCH v3 0/2] Document memory-to-memory video codec interfaces Tomasz Figa
2019-01-24 10:04 ` [PATCH v3 1/2] media: docs-rst: Document memory-to-memory video decoder interface Tomasz Figa
2019-01-29 13:11 ` Hans Verkuil
2019-01-31 10:45 ` Hans Verkuil
2019-01-31 12:30 ` Hans Verkuil
2019-01-31 12:38 ` Hans Verkuil
2019-01-31 12:44 ` Philipp Zabel
2019-01-31 13:19 ` Hans Verkuil
2019-02-07 8:51 ` Tomasz Figa
2019-04-05 10:59 ` Philipp Zabel
2019-04-05 11:21 ` Hans Verkuil
2019-04-09 10:28 ` Tomasz Figa
2019-04-09 16:57 ` Philipp Zabel
2019-04-10 9:29 ` Hans Verkuil
2019-01-24 10:04 ` [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface Tomasz Figa
2019-01-29 13:52 ` Hans Verkuil
2019-03-14 13:57 ` Hans Verkuil
2019-04-05 8:12 ` Tomasz Figa
2019-04-05 10:03 ` Hans Verkuil
2019-04-08 9:23 ` Tomasz Figa
2019-04-08 11:11 ` Hans Verkuil
2019-04-09 9:35 ` Tomasz Figa
2019-04-10 8:50 ` Hans Verkuil
2019-04-10 16:05 ` Nicolas Dufresne
2019-04-15 8:56 ` Tomasz Figa
2019-04-15 12:30 ` Nicolas Dufresne [this message]
2019-04-05 5:53 ` Tomasz Figa
2019-04-05 7:09 ` Hans Verkuil
2019-03-21 10:10 ` Hans Verkuil
2019-04-08 6:59 ` Tomasz Figa
2019-04-08 7:43 ` Hans Verkuil
2019-04-08 9:35 ` Tomasz Figa
2019-03-25 13:12 ` Hans Verkuil
2019-03-25 16:33 ` Hans Verkuil
2019-04-08 8:40 ` Tomasz Figa
2019-04-08 8:36 ` Tomasz Figa
2019-04-08 8:43 ` Hans Verkuil
2019-04-09 7:11 ` Tomasz Figa
2019-04-09 9:37 ` Hans Verkuil
2019-04-09 9:43 ` Tomasz Figa
2019-05-22 8:43 ` Tomasz Figa
2019-05-22 8:51 ` Hans Verkuil
2019-05-22 14:16 ` Michael Tretter
2019-04-30 17:34 ` Michael Tretter
2019-05-14 8:12 ` Tomasz Figa
2019-05-16 8:37 ` Michael Tretter
2019-05-16 8:48 ` Tomasz Figa
2019-01-24 10:38 ` [PATCH v3 0/2] Document memory-to-memory video codec interfaces Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ae8b9daa0cf406ab604e802bbb6d46736266bd5.camel@ndufresne.ca \
--to=nicolas@ndufresne.ca \
--cc=a.hajda@samsung.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=ezequiel@collabora.com \
--cc=hverkuil@xs4all.nl \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxi.jourdan@wanadoo.fr \
--cc=mchehab@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=posciak@chromium.org \
--cc=stanimir.varbanov@linaro.org \
--cc=tfiga@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).