From: Hans Verkuil <hverkuil@xs4all.nl>
To: Tomasz Figa <tfiga@chromium.org>, linux-media@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
"Mauro Carvalho Chehab" <mchehab@kernel.org>,
"Pawel Osciak" <posciak@chromium.org>,
"Alexandre Courbot" <acourbot@chromium.org>,
"Kamil Debski" <kamil@wypas.org>,
"Andrzej Hajda" <a.hajda@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Jeongtae Park" <jtp.park@samsung.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Tiffany Lin (林慧珊)" <tiffany.lin@mediatek.com>,
"Andrew-CT Chen (陳智迪)" <andrew-ct.chen@mediatek.com>,
"Stanimir Varbanov" <stanimir.varbanov@linaro.org>,
"Todor Tomov" <todor.tomov@linaro.org>,
"Nicolas Dufresne" <nicolas@ndufresne.ca>,
"Paul Kocialkowski" <paul.kocialkowski@bootlin.com>,
"Laurent Pinchart" <laurent.pinchart@ideasonboard.com>,
dave.stevenson@raspberrypi.org,
"Ezequiel Garcia" <ezequiel@collabora.com>,
"Maxime Jourdan" <maxi.jourdan@wanadoo.fr>
Subject: Re: [PATCH v3 0/2] Document memory-to-memory video codec interfaces
Date: Thu, 24 Jan 2019 11:38:04 +0100 [thread overview]
Message-ID: <a894dd18-7cc7-aae9-969f-4a3fe18ba2d5@xs4all.nl> (raw)
In-Reply-To: <20190124100419.26492-1-tfiga@chromium.org>
On 01/24/19 11:04, Tomasz Figa wrote:
> Late happy new year everyone. It's been a while, but here is the v3 of
> the stateful mem2mem codec interfaces documentation. Sorry for taking so
> long time to respin. (Again.)
>
> This series attempts to add the documentation of what was discussed
> during Media Workshops at LinuxCon Europe 2012 in Barcelona and then
> later Embedded Linux Conference Europe 2014 in Düsseldorf and then
> eventually written down by Pawel Osciak and tweaked a bit by Chrome OS
> video team (but mostly in a cosmetic way or making the document more
> precise), during the several years of Chrome OS using the APIs in
> production.
>
> Note that most, if not all, of the API is already implemented in
> existing mainline drivers, such as s5p-mfc or mtk-vcodec. Intention of
> this series is just to formalize what we already have.
>
> Thanks everyone for the huge amount of useful comments for the RFC and
> v1. Much of the credits should go to Pawel Osciak too, for writing most
> of the original text of the initial RFC.
Thank you very much for this v3.
I've updated the spec with this v3 + Alexandre's v2 incorporated here:
https://hverkuil.home.xs4all.nl/codec-api/uapi/v4l/dev-mem2mem.html
I plan to review this as soon as I can because I really would like to
get this merged for 5.1.
Regards,
Hans
>
> Changes since v2:
> (https://lore.kernel.org/patchwork/cover/1002474/)
> Decoder:
> - Specified that the initial source change event is signaled
> regardless of whether the client-set format matches the
> stream format.
> - Dropped V4L2_CID_MIN_BUFFERS_FOR_OUTPUT since it's meaningless
> for the bitstream input buffers of decoders.
> - Explicitly stated that VIDIOC_REQBUFS is not allowed on CAPTURE
> if the stream information is not available.
> - Described decode error handling.
> - Mentioned that timestamps can be observed after a seek to
> determine whether the CAPTURE buffers originated from before
> or after the seek.
> - Explicitly stated that after a pair of V4L2_DEC_CMD_STOP and
> V4L2_DEC_CMD_START, the decoder is not reset and preserves
> all the state.
>
> Encoder:
> - Specified that width and height of CAPTURE format are ignored
> and always zero.
> - Explicitly noted the common use case for the CROP target with
> macroblock-unaligned video resolutions.
> - Added a reference to Request API.
> - Dropped V4L2_CID_MIN_BUFFERS_FOR_CAPTURE since it's meaningless
> for the bitstream output buffers of encoders.
> - Explicitly stated that after a pair of V4L2_ENC_CMD_STOP and
> V4L2_ENC_CMD_START, the encoder is not reset and preserves
> all the state.
>
> General:
> - Dropped format enumeration from "Initialization", since it's already
> a part of "Querying capabilities".
> - Many spelling, grammar, stylistic, etc. changes.
> - Changed the style of note blocks.
> - Rebased onto Hans' documentation cleanup series.
> (https://patchwork.kernel.org/cover/10775407/
> https://patchwork.kernel.org/patch/10776737/)
> - Moved the interfaces under the "Video Memory-To-Memory Interface"
> section.
>
> For changes since v1 see the v2:
> https://lore.kernel.org/patchwork/cover/1002474/
>
> For changes since RFC see the v1:
> https://patchwork.kernel.org/cover/10542207/
>
> Tomasz Figa (2):
> media: docs-rst: Document memory-to-memory video decoder interface
> media: docs-rst: Document memory-to-memory video encoder interface
>
> Documentation/media/uapi/v4l/dev-decoder.rst | 1076 +++++++++++++++++
> Documentation/media/uapi/v4l/dev-encoder.rst | 586 +++++++++
> Documentation/media/uapi/v4l/dev-mem2mem.rst | 6 +
> Documentation/media/uapi/v4l/pixfmt-v4l2.rst | 10 +
> Documentation/media/uapi/v4l/v4l2.rst | 12 +-
> .../media/uapi/v4l/vidioc-decoder-cmd.rst | 40 +-
> .../media/uapi/v4l/vidioc-encoder-cmd.rst | 38 +-
> Documentation/media/uapi/v4l/vidioc-g-fmt.rst | 14 +
> 8 files changed, 1752 insertions(+), 30 deletions(-)
> create mode 100644 Documentation/media/uapi/v4l/dev-decoder.rst
> create mode 100644 Documentation/media/uapi/v4l/dev-encoder.rst
>
prev parent reply other threads:[~2019-01-24 10:38 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-24 10:04 [PATCH v3 0/2] Document memory-to-memory video codec interfaces Tomasz Figa
2019-01-24 10:04 ` [PATCH v3 1/2] media: docs-rst: Document memory-to-memory video decoder interface Tomasz Figa
2019-01-29 13:11 ` Hans Verkuil
2019-01-31 10:45 ` Hans Verkuil
2019-01-31 12:30 ` Hans Verkuil
2019-01-31 12:38 ` Hans Verkuil
2019-01-31 12:44 ` Philipp Zabel
2019-01-31 13:19 ` Hans Verkuil
2019-02-07 8:51 ` Tomasz Figa
2019-04-05 10:59 ` Philipp Zabel
2019-04-05 11:21 ` Hans Verkuil
2019-04-09 10:28 ` Tomasz Figa
2019-04-09 16:57 ` Philipp Zabel
2019-04-10 9:29 ` Hans Verkuil
2019-01-24 10:04 ` [PATCH v3 2/2] media: docs-rst: Document memory-to-memory video encoder interface Tomasz Figa
2019-01-29 13:52 ` Hans Verkuil
2019-03-14 13:57 ` Hans Verkuil
2019-04-05 8:12 ` Tomasz Figa
2019-04-05 10:03 ` Hans Verkuil
2019-04-08 9:23 ` Tomasz Figa
2019-04-08 11:11 ` Hans Verkuil
2019-04-09 9:35 ` Tomasz Figa
2019-04-10 8:50 ` Hans Verkuil
2019-04-10 16:05 ` Nicolas Dufresne
2019-04-15 8:56 ` Tomasz Figa
2019-04-15 12:30 ` Nicolas Dufresne
2019-04-05 5:53 ` Tomasz Figa
2019-04-05 7:09 ` Hans Verkuil
2019-03-21 10:10 ` Hans Verkuil
2019-04-08 6:59 ` Tomasz Figa
2019-04-08 7:43 ` Hans Verkuil
2019-04-08 9:35 ` Tomasz Figa
2019-03-25 13:12 ` Hans Verkuil
2019-03-25 16:33 ` Hans Verkuil
2019-04-08 8:40 ` Tomasz Figa
2019-04-08 8:36 ` Tomasz Figa
2019-04-08 8:43 ` Hans Verkuil
2019-04-09 7:11 ` Tomasz Figa
2019-04-09 9:37 ` Hans Verkuil
2019-04-09 9:43 ` Tomasz Figa
2019-05-22 8:43 ` Tomasz Figa
2019-05-22 8:51 ` Hans Verkuil
2019-05-22 14:16 ` Michael Tretter
2019-04-30 17:34 ` Michael Tretter
2019-05-14 8:12 ` Tomasz Figa
2019-05-16 8:37 ` Michael Tretter
2019-05-16 8:48 ` Tomasz Figa
2019-01-24 10:38 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a894dd18-7cc7-aae9-969f-4a3fe18ba2d5@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=a.hajda@samsung.com \
--cc=acourbot@chromium.org \
--cc=andrew-ct.chen@mediatek.com \
--cc=dave.stevenson@raspberrypi.org \
--cc=ezequiel@collabora.com \
--cc=jtp.park@samsung.com \
--cc=kamil@wypas.org \
--cc=kyungmin.park@samsung.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxi.jourdan@wanadoo.fr \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=p.zabel@pengutronix.de \
--cc=paul.kocialkowski@bootlin.com \
--cc=posciak@chromium.org \
--cc=stanimir.varbanov@linaro.org \
--cc=tfiga@chromium.org \
--cc=tiffany.lin@mediatek.com \
--cc=todor.tomov@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).