Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 26/07/2022 16:36, Zhang Ning wrote:
> Add manufactor bindings for Tmall
> Add the board bindings for Magicbox M16S Tv Box
> 
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>

All your subjects are still partially wrong. I pointed this out in v5
and you still send v6 and v7 without proper patch prefix.

> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  2 files changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 61a6cabb375b..a67af2adf6a5 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -125,6 +125,7 @@ properties:
>                - libretech,aml-s912-pc
>                - minix,neo-u9h
>                - nexbox,a1
> +              - tmall,magicbox-m16s

Previously the vendor was magicbox... now it is tmall. But you write
also Alibaba. It's a bit confusing.

Best regards,
Krzysztof

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 27/07/2022 16:41, Zhang Ning wrote:
> On Wed, Jul 27, 2022 at 09:06:07AM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>>
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>>
>> All your subjects are still partially wrong. I pointed this out in v5
>> and you still send v6 and v7 without proper patch prefix.
>>
>>> ---
>>>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>>>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>>>  2 files changed, 3 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> index 61a6cabb375b..a67af2adf6a5 100644
>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> @@ -125,6 +125,7 @@ properties:
>>>                - libretech,aml-s912-pc
>>>                - minix,neo-u9h
>>>                - nexbox,a1
>>> +              - tmall,magicbox-m16s
>>
>> Previously the vendor was magicbox... now it is tmall. But you write
>> also Alibaba. It's a bit confusing.
> 
> Tmall is sub-company of Alibaba, if I use alibaba,tmall-magicbox-m16s
> this will be too long.

OK


Best regards,
Krzysztof

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 26/07/2022 16:36, Zhang Ning wrote:
> Add manufactor bindings for Tmall
> Add the board bindings for Magicbox M16S Tv Box
> 
> Signed-off-by: Zhang Ning <zhangn1985@qq.com>

Please send patches with correct subject PATCH.

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml     | 1 +
>  Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++
>  2 files changed, 3 insertions(+)

Best regards,
Krzysztof

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Christian Hewitt]

> On 28 Jul 2022, at 3:48 am, Zhang Ning <zhangn1985@qq.com> wrote:
> 
> On Wed, Jul 27, 2022 at 05:27:25PM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>> 
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>> 
>> Please send patches with correct subject PATCH.
> I got confused, and don't know how to update..
> 
> ad152daedc5c dt-bindings: arm: amlogic: add MagicBox M16S bindings
> 3f7dbd336f36 dt-bindings: arm: amlogic: add Vero 4K+ bindings
> 2ca889b12016 dt-bindings: arm: amlogic: add H96-Max bindings
> 
>> 
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?

Hello Zhang. Let’s work off-list to get things corrected before you send
another (hopefully final) version. I’m happy to explain and coach you on
the process.

Christian

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Krzysztof Kozlowski]

On 28/07/2022 01:48, Zhang Ning wrote:
> On Wed, Jul 27, 2022 at 05:27:25PM +0200, Krzysztof Kozlowski wrote:
>> On 26/07/2022 16:36, Zhang Ning wrote:
>>> Add manufactor bindings for Tmall
>>> Add the board bindings for Magicbox M16S Tv Box
>>>
>>> Signed-off-by: Zhang Ning <zhangn1985@qq.com>
>>
>> Please send patches with correct subject PATCH.
> I got confused, and don't know how to update..
> 
> ad152daedc5c dt-bindings: arm: amlogic: add MagicBox M16S bindings
> 3f7dbd336f36 dt-bindings: arm: amlogic: add Vero 4K+ bindings
> 2ca889b12016 dt-bindings: arm: amlogic: add H96-Max bindings

git format-patch -v8

> 
>>
>> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?
>
If split is the only change, you can add ti both of them


Best regards,
Krzysztof

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Sean Young]

On Thu, Jul 28, 2022 at 07:48:57AM +0800, Zhang Ning wrote:
> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
> for device, how to handle your Acked-by?
> 
> btw, he also said I'm wrong in handle Sean's Signed-of-by, still don't
> know how to do in next version. Should I just not send this patch?

Christian can you explain *on list* what is wrong with handling my
Signed-off-by? As far as I can see Ning has done the right thing.

Please keep the conversation on list so we're all in the loop.


Sean

Re: [v7 3/4] dt-bindings: arm: amlogic: add MagicBox M16S bindings

[Christian Hewitt]

> On 29 Jul 2022, at 12:42 pm, Sean Young <sean@mess.org> wrote:
> 
> On Thu, Jul 28, 2022 at 07:48:57AM +0800, Zhang Ning wrote:
>> Christian Hewitt told me to split to 2 patches, 1st for manufactor, 2nd
>> for device, how to handle your Acked-by?
>> 
>> btw, he also said I'm wrong in handle Sean's Signed-of-by, still don't
>> know how to do in next version. Should I just not send this patch?
> 
> Christian can you explain *on list* what is wrong with handling my
> Signed-off-by? As far as I can see Ning has done the right thing.

Sorry, this is my ignorance. I’ve only seen maintainers provide Acked-By
or Reviewed-By tags in response to my own past submissions. I’ve not had
Signed-Off-By responses on-list before. I’ve only seen maintainer SOB
being applied to patches as they are merged into the maintainers tree
and queued for sending upstream. Today is a learning day :)

> Please keep the conversation on list so we're all in the loop.

The board still has some hardware items to figure out and the next date
Amlogic patches will be picked for 5.21 is ~2.5 months away, so there
is no rush and I’ve encouraged Zhang to keep working via the Armbian
forum thread that he started [0]. I’m no expert (as you can see ^) but
I’m trying to coach and explain/spot the common etiquette and process
nits (which I’ve made myself in the past) before he sends the next rev.
of patches for review.

Christian

[0] https://forum.armbian.com/topic/22301-help-to-review-porting-mainline-u-boot-and-linux-to-tmall-magicbox-m16s-amlogic-s912-h-tv-box/