* [PATCH] [media] sh-vou: clarify videobuf2 dependency
@ 2015-10-16 20:27 Arnd Bergmann
0 siblings, 0 replies; only message in thread
From: Arnd Bergmann @ 2015-10-16 20:27 UTC (permalink / raw)
To: Hans Verkuil
Cc: Mauro Carvalho Chehab, Laurent Pinchart, linux-media,
linux-kernel, linux-arm-kernel, linux-sh
The sh-vou driver has been converted from videobuf to videobuf2, but
the Kconfig file still lists VIDEOBUF_DMA_CONTIG as a dependency.
Consequently we can build the driver without VIDEOBUF2_DMA_CONTIG
and get a link error:
drivers/built-in.o: In function `sh_vou_probe':
vf610-ocotp.c:(.text+0x2dbf5c): undefined reference to `vb2_dma_contig_init_ctx'
vf610-ocotp.c:(.text+0x2dc0b4): undefined reference to `vb2_dma_contig_cleanup_ctx'
vf610-ocotp.c:(.text+0x2dc144): undefined reference to `vb2_dma_contig_memops'
drivers/built-in.o: In function `sh_vou_remove':
vf610-ocotp.c:(.text+0x2dc190): undefined reference to `vb2_dma_contig_cleanup_ctx'
This changes the dependency to VIDEOBUF2_DMA_CONTIG instead.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 57af3ad59d95 ("[media] sh-vou: convert to vb2")
---
Found on ARM randconfig tests
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index f88a6cfb7086..3ddf72f2d844 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -38,7 +38,7 @@ config VIDEO_SH_VOU
depends on MEDIA_CAMERA_SUPPORT
depends on VIDEO_DEV && I2C && HAS_DMA
depends on ARCH_SHMOBILE || COMPILE_TEST
- select VIDEOBUF_DMA_CONTIG
+ select VIDEOBUF2_DMA_CONTIG
help
Support for the Video Output Unit (VOU) on SuperH SoCs.
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-16 20:27 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-16 20:27 [PATCH] [media] sh-vou: clarify videobuf2 dependency Arnd Bergmann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).