* [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer
@ 2014-03-24 17:51 Lad, Prabhakar
2014-04-02 9:38 ` Hans Verkuil
0 siblings, 1 reply; 3+ messages in thread
From: Lad, Prabhakar @ 2014-03-24 17:51 UTC (permalink / raw)
To: LMML
Cc: LKML, Hans Verkuil, Mauro Carvalho Chehab, Lad Prabhakar, LDOC,
Rob Landley
From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
---
Documentation/video4linux/v4l2-pci-skeleton.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
index 3a1c0d2..61a56f4 100644
--- a/Documentation/video4linux/v4l2-pci-skeleton.c
+++ b/Documentation/video4linux/v4l2-pci-skeleton.c
@@ -87,7 +87,7 @@ struct skel_buffer {
static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
{
- return container_of(vb2, struct skel_buffer, vb);
+ return container_of(vb2, struct skel_buffer, vb2);
}
static const struct pci_device_id skeleton_pci_tbl[] = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer
2014-03-24 17:51 [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer Lad, Prabhakar
@ 2014-04-02 9:38 ` Hans Verkuil
2014-04-02 10:22 ` Prabhakar Lad
0 siblings, 1 reply; 3+ messages in thread
From: Hans Verkuil @ 2014-04-02 9:38 UTC (permalink / raw)
To: Lad, Prabhakar
Cc: LMML, LKML, Hans Verkuil, Mauro Carvalho Chehab, LDOC, Rob Landley
On 03/24/14 18:51, Lad, Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
> ---
> Documentation/video4linux/v4l2-pci-skeleton.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
> index 3a1c0d2..61a56f4 100644
> --- a/Documentation/video4linux/v4l2-pci-skeleton.c
> +++ b/Documentation/video4linux/v4l2-pci-skeleton.c
> @@ -87,7 +87,7 @@ struct skel_buffer {
>
> static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
> {
> - return container_of(vb2, struct skel_buffer, vb);
> + return container_of(vb2, struct skel_buffer, vb2);
Why is this a type? The vb2_buffer member in struct skel_buffer is called
'vb', so this should be correct.
Regards,
Hans
> }
>
> static const struct pci_device_id skeleton_pci_tbl[] = {
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer
2014-04-02 9:38 ` Hans Verkuil
@ 2014-04-02 10:22 ` Prabhakar Lad
0 siblings, 0 replies; 3+ messages in thread
From: Prabhakar Lad @ 2014-04-02 10:22 UTC (permalink / raw)
To: Hans Verkuil
Cc: LMML, LKML, Hans Verkuil, Mauro Carvalho Chehab, LDOC, Rob Landley
Hi Hans,
On Wed, Apr 2, 2014 at 3:08 PM, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> On 03/24/14 18:51, Lad, Prabhakar wrote:
>> From: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
>> ---
>> Documentation/video4linux/v4l2-pci-skeleton.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
>> index 3a1c0d2..61a56f4 100644
>> --- a/Documentation/video4linux/v4l2-pci-skeleton.c
>> +++ b/Documentation/video4linux/v4l2-pci-skeleton.c
>> @@ -87,7 +87,7 @@ struct skel_buffer {
>>
>> static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
>> {
>> - return container_of(vb2, struct skel_buffer, vb);
>> + return container_of(vb2, struct skel_buffer, vb2);
>
> Why is this a type? The vb2_buffer member in struct skel_buffer is called
> 'vb', so this should be correct.
>
Oops may be I overlooked, sorry for the noise.
Thanks,
--Prabhakar Lad
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-04-02 10:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-03-24 17:51 [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer Lad, Prabhakar
2014-04-02 9:38 ` Hans Verkuil
2014-04-02 10:22 ` Prabhakar Lad
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).