* [PATCH] media: staging: rkisp1: rsz: fix resolution limitation on sink pad
@ 2020-06-17 18:08 Helen Koike
2020-06-17 20:44 ` Tomasz Figa
0 siblings, 1 reply; 2+ messages in thread
From: Helen Koike @ 2020-06-17 18:08 UTC (permalink / raw)
To: linux-media
Cc: mchehab, dafna.hirschfeld, linux-kernel, tfiga, hans.verkuil,
kernel, Helen Koike
Resizer sink pad is limited by what the ISP can generate.
The configurations describes what the resizer can produce.
This was tested on a Scarlet device with ChromiumOs, where the selfpath
receives 2592x1944 and produces 1600x1200 (which isn't possible without
this fix).
Fixes: 56e3b29f9f6b2 ("media: staging: rkisp1: add streaming paths")
Signed-off-by: Helen Koike <helen.koike@collabora.com>
---
drivers/staging/media/rkisp1/rkisp1-resizer.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c
index d049374413dcf..0d41f43b5339f 100644
--- a/drivers/staging/media/rkisp1/rkisp1-resizer.c
+++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c
@@ -553,11 +553,11 @@ static void rkisp1_rsz_set_sink_fmt(struct rkisp1_resizer *rsz,
src_fmt->code = sink_fmt->code;
sink_fmt->width = clamp_t(u32, format->width,
- rsz->config->min_rsz_width,
- rsz->config->max_rsz_width);
+ RKISP1_ISP_MIN_WIDTH,
+ RKISP1_ISP_MAX_WIDTH);
sink_fmt->height = clamp_t(u32, format->height,
- rsz->config->min_rsz_height,
- rsz->config->max_rsz_height);
+ RKISP1_ISP_MIN_HEIGHT,
+ RKISP1_ISP_MAX_HEIGHT);
*format = *sink_fmt;
--
2.26.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] media: staging: rkisp1: rsz: fix resolution limitation on sink pad
2020-06-17 18:08 [PATCH] media: staging: rkisp1: rsz: fix resolution limitation on sink pad Helen Koike
@ 2020-06-17 20:44 ` Tomasz Figa
0 siblings, 0 replies; 2+ messages in thread
From: Tomasz Figa @ 2020-06-17 20:44 UTC (permalink / raw)
To: Helen Koike
Cc: Linux Media Mailing List, Mauro Carvalho Chehab,
Dafna Hirschfeld, Linux Kernel Mailing List, Hans Verkuil,
kernel
On Wed, Jun 17, 2020 at 8:08 PM Helen Koike <helen.koike@collabora.com> wrote:
>
> Resizer sink pad is limited by what the ISP can generate.
> The configurations describes what the resizer can produce.
>
> This was tested on a Scarlet device with ChromiumOs, where the selfpath
> receives 2592x1944 and produces 1600x1200 (which isn't possible without
> this fix).
>
> Fixes: 56e3b29f9f6b2 ("media: staging: rkisp1: add streaming paths")
> Signed-off-by: Helen Koike <helen.koike@collabora.com>
>
> ---
>
> drivers/staging/media/rkisp1/rkisp1-resizer.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c
> index d049374413dcf..0d41f43b5339f 100644
> --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c
> +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c
> @@ -553,11 +553,11 @@ static void rkisp1_rsz_set_sink_fmt(struct rkisp1_resizer *rsz,
> src_fmt->code = sink_fmt->code;
>
> sink_fmt->width = clamp_t(u32, format->width,
> - rsz->config->min_rsz_width,
> - rsz->config->max_rsz_width);
> + RKISP1_ISP_MIN_WIDTH,
> + RKISP1_ISP_MAX_WIDTH);
> sink_fmt->height = clamp_t(u32, format->height,
> - rsz->config->min_rsz_height,
> - rsz->config->max_rsz_height);
> + RKISP1_ISP_MIN_HEIGHT,
> + RKISP1_ISP_MAX_HEIGHT);
>
> *format = *sink_fmt;
>
> --
> 2.26.0
>
Reviewed-by: Tomasz Figa <tfiga@chromium.org>
Best regards,
Tomasz
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-17 20:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-17 18:08 [PATCH] media: staging: rkisp1: rsz: fix resolution limitation on sink pad Helen Koike
2020-06-17 20:44 ` Tomasz Figa
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).