* [PATCH] [media] VIDEO_RENESAS_JPU should depend on HAS_DMA
@ 2015-09-06 10:11 Geert Uytterhoeven
2015-09-14 9:22 ` Mikhail Ulyanov
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2015-09-06 10:11 UTC (permalink / raw)
To: Mikhail Ulyanov, Hans Verkuil, Mauro Carvalho Chehab
Cc: linux-media, linux-sh, linux-kernel, Geert Uytterhoeven
If NO_DMA=y:
warning: (VIDEO_STI_BDISP && VIDEO_RENESAS_JPU && VIDEO_DM365_VPFE && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:207: error: implicit declaration of function ‘dma_mmap_coherent’
drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
drivers/media/v4l2-core/videobuf2-dma-contig.c:390: error: implicit declaration of function ‘dma_get_sgtable’
VIDEO_RENESAS_JPU selects VIDEOBUF2_DMA_CONTIG, which bypasses its
dependency on HAS_DMA. Make VIDEO_RENESAS_JPU depend on HAS_DMA to fix
this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index dc75694ac12d2d57..ccbc9742cb7aeca4 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -233,7 +233,7 @@ config VIDEO_SH_VEU
config VIDEO_RENESAS_JPU
tristate "Renesas JPEG Processing Unit"
- depends on VIDEO_DEV && VIDEO_V4L2
+ depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA
depends on ARCH_SHMOBILE || COMPILE_TEST
select VIDEOBUF2_DMA_CONTIG
select V4L2_MEM2MEM_DEV
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] [media] VIDEO_RENESAS_JPU should depend on HAS_DMA
2015-09-06 10:11 [PATCH] [media] VIDEO_RENESAS_JPU should depend on HAS_DMA Geert Uytterhoeven
@ 2015-09-14 9:22 ` Mikhail Ulyanov
0 siblings, 0 replies; 2+ messages in thread
From: Mikhail Ulyanov @ 2015-09-14 9:22 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Hans Verkuil, Mauro Carvalho Chehab, Linux Media Mailing List,
linux-sh, linux-kernel
Hi!
Thanks for patch.
On Sun, Sep 6, 2015 at 1:11 PM, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> If NO_DMA=y:
>
> warning: (VIDEO_STI_BDISP && VIDEO_RENESAS_JPU && VIDEO_DM365_VPFE && VIDEO_OMAP4) selects VIDEOBUF2_DMA_CONTIG which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)
>
> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:207: error: implicit declaration of function ‘dma_mmap_coherent’
> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:390: error: implicit declaration of function ‘dma_get_sgtable’
>
> VIDEO_RENESAS_JPU selects VIDEOBUF2_DMA_CONTIG, which bypasses its
> dependency on HAS_DMA. Make VIDEO_RENESAS_JPU depend on HAS_DMA to fix
> this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
> drivers/media/platform/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index dc75694ac12d2d57..ccbc9742cb7aeca4 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -233,7 +233,7 @@ config VIDEO_SH_VEU
>
> config VIDEO_RENESAS_JPU
> tristate "Renesas JPEG Processing Unit"
> - depends on VIDEO_DEV && VIDEO_V4L2
> + depends on VIDEO_DEV && VIDEO_V4L2 && HAS_DMA
> depends on ARCH_SHMOBILE || COMPILE_TEST
> select VIDEOBUF2_DMA_CONTIG
> select V4L2_MEM2MEM_DEV
> --
> 1.9.1
>
Acked-by: Mikhail Ulyanov <mikhail.ulyanov@cogentembedded.com>
--
W.B.R, Mikhail.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-09-14 9:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-09-06 10:11 [PATCH] [media] VIDEO_RENESAS_JPU should depend on HAS_DMA Geert Uytterhoeven
2015-09-14 9:22 ` Mikhail Ulyanov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).