From: "Guido Günther" <guido.gunther@puri.sm>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: Martin Kepplinger <martin.kepplinger@puri.sm>,
krzysztof.kozlowski@canonical.com,
laurent.pinchart@ideasonboard.com, devicetree@vger.kernel.org,
kernel@puri.sm, linux-kernel@vger.kernel.org,
linux-media@vger.kernel.org, mchehab@kernel.org,
paul.kocialkowski@bootlin.com, pavel@ucw.cz,
phone-devel@vger.kernel.org, robh@kernel.org,
shawnx.tu@intel.com
Subject: Re: [PATCH v6 5/5] arm64: defconfig: enable VIDEO_HI846
Date: Thu, 8 Jul 2021 17:13:13 +0200 [thread overview]
Message-ID: <YOcWCVSXfV+cKJ6H@qwark.sigxcpu.org> (raw)
In-Reply-To: <20210708130003.GA3@valkosipuli.retiisi.eu>
Hi,
On Thu, Jul 08, 2021 at 04:00:04PM +0300, Sakari Ailus wrote:
> Hi Martin,
>
> On Mon, Jun 28, 2021 at 12:10:54PM +0200, Martin Kepplinger wrote:
> > Build the driver for the Hi-846 camera by default on arm64 where it's
> > going to be used on at least the imx8mq-librem5 board.
> >
> > Signed-off-by: Martin Kepplinger <martin.kepplinger@puri.sm>
> > ---
> > arch/arm64/configs/defconfig | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defconfig
> > index f423d08b9a71..bf27d9cfbdd5 100644
> > --- a/arch/arm64/configs/defconfig
> > +++ b/arch/arm64/configs/defconfig
> > @@ -666,6 +666,7 @@ CONFIG_VIDEO_RENESAS_VSP1=m
> > CONFIG_VIDEO_QCOM_VENUS=m
> > CONFIG_SDR_PLATFORM_DRIVERS=y
> > CONFIG_VIDEO_RCAR_DRIF=m
> > +CONFIG_VIDEO_HI846=m
> > CONFIG_VIDEO_IMX219=m
> > CONFIG_VIDEO_OV5645=m
> > CONFIG_VIDEO_QCOM_CAMSS=m
>
> The same sensor may be or may not used on a given board (and certainly it's
> not specific to arm64). Is it desirable all arm64 systems compile this in
> by default?
>
> There appear to be a other sensor drivers though.
>
> Is there a defconfig for the librem5 board?
arm64 has a single defconfig, there are no board specific ones (and
afaik they're not wanted either) so I think enabling it as a module is
the only way.
Cheers,
-- Guido
>
> I wonder what others think.
>
> --
> Kind regards,
>
> Sakari Ailus
next prev parent reply other threads:[~2021-07-08 15:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-28 10:10 [PATCH v6 0/5] Add support for the Hynix Hi-846 camera Martin Kepplinger
2021-06-28 10:10 ` [PATCH v6 1/5] dt-bindings: vendor-prefixes: Add SK Hynix Inc Martin Kepplinger
2021-06-28 10:10 ` [PATCH v6 2/5] dt-bindings: media: document SK Hynix Hi-846 MIPI CSI-2 8M pixel sensor Martin Kepplinger
2021-06-28 10:10 ` [PATCH v6 3/5] media: i2c: add driver for the SK Hynix Hi-846 8M pixel camera Martin Kepplinger
2021-07-08 12:54 ` Sakari Ailus
2021-07-08 12:57 ` Sakari Ailus
2021-06-28 10:10 ` [PATCH v6 4/5] Documentation: i2c-cardlist: add the Hynix hi846 sensor Martin Kepplinger
2021-06-28 10:10 ` [PATCH v6 5/5] arm64: defconfig: enable VIDEO_HI846 Martin Kepplinger
2021-07-08 13:00 ` Sakari Ailus
2021-07-08 15:13 ` Guido Günther [this message]
2021-07-08 15:34 ` Laurent Pinchart
2021-07-09 7:06 ` Guido Günther
2021-08-07 7:06 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YOcWCVSXfV+cKJ6H@qwark.sigxcpu.org \
--to=guido.gunther@puri.sm \
--cc=devicetree@vger.kernel.org \
--cc=kernel@puri.sm \
--cc=krzysztof.kozlowski@canonical.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.kepplinger@puri.sm \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=pavel@ucw.cz \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=shawnx.tu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).