linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
To: "Jernej Škrabec" <jernej.skrabec@gmail.com>,
	linux-sunxi@googlegroups.com
Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Maxime Ripard <maxime.ripard@bootlin.com>,
	Chen-Yu Tsai <wens@csie.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Hans Verkuil <hverkuil@xs4all.nl>,
	Sakari Ailus <sakari.ailus@linux.intel.com>
Subject: Re: [linux-sunxi] [PATCH v2 15/15] arm64: dts: allwinner: a64: Add Video Engine node
Date: Mon, 10 Dec 2018 10:00:34 +0100	[thread overview]
Message-ID: <c276fb045ab285c0907c4831f3b71a31f09cd4a5.camel@bootlin.com> (raw)
In-Reply-To: <2823800.C4zEU5jiS7@jernej-laptop>

Hi,

On Fri, 2018-12-07 at 22:22 +0100, Jernej Škrabec wrote:
> Hi!
> 
> Dne sreda, 05. december 2018 ob 10:24:44 CET je Paul Kocialkowski napisal(a):
> > This adds the Video Engine node for the A64. Since it can map the whole
> > DRAM range, there is no particular need for a reserved memory node
> > (unlike platforms preceding the A33).
> > 
> > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
> > ---
> >  arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 11 +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index
> > 8557d52c7c99..8d024c10d7cb 100644
> > --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi
> > @@ -397,6 +397,17 @@
> >  			};
> >  		};
> > 
> > +		video-codec@1c0e000 {
> > +			compatible = "allwinner,sun50i-h5-video-engine";
> 
> You meant A64 instead of H5, right?

Ah yes definitely, that's a mistake right here.

I'll send a follow-up patch for switching the compatible to describe
the a64 instead of the h5. In practice, having the a64 use the h5
compatible doesn't cause any issue, but it should be fixed
nevertheless.

Cheers,

Paul

> Best regards,
> Jernej
> 
> > +			reg = <0x01c0e000 0x1000>;
> > +			clocks = <&ccu CLK_BUS_VE>, <&ccu CLK_VE>,
> > +				 <&ccu CLK_DRAM_VE>;
> > +			clock-names = "ahb", "mod", "ram";
> > +			resets = <&ccu RST_BUS_VE>;
> > +			interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
> > +			allwinner,sram = <&ve_sram 1>;
> > +		};
> > +
> >  		mmc0: mmc@1c0f000 {
> >  			compatible = "allwinner,sun50i-a64-mmc";
> >  			reg = <0x01c0f000 0x1000>;
> 
> 
> 
-- 
Paul Kocialkowski, Bootlin (formerly Free Electrons)
Embedded Linux and kernel engineering
https://bootlin.com


  reply	other threads:[~2018-12-10  9:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-05  9:24 [PATCH v2 00/15] Cedrus H5 and A64 support with A33 and H3 updates Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 01/15] ARM: dts: sun8i: h3: Fix the system-control register range Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 02/15] ARM: dts: sun8i: a33: Remove unnecessary reserved memory node Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 03/15] ARM: dts: sun8i: h3: " Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 04/15] soc: sunxi: sram: Enable EMAC clock access for H3 variant Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 05/15] dt-bindings: sram: sunxi: Add bindings for the H5 with SRAM C1 Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 06/15] soc: sunxi: sram: Add support for the H5 SoC system control Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 07/15] arm64: dts: allwinner: h5: Add system-control node with SRAM C1 Paul Kocialkowski
2018-12-05  9:45   ` Chen-Yu Tsai
2018-12-05  9:48     ` Paul Kocialkowski
2018-12-05  9:49       ` Chen-Yu Tsai
2018-12-05  9:53         ` Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 08/15] ARM/arm64: sunxi: Move H3/H5 syscon label over to soc-specific nodes Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 09/15] dt-bindings: sram: sunxi: Add compatible for the A64 SRAM C1 Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 10/15] arm64: dts: allwinner: a64: Add support for the SRAM C1 section Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 11/15] dt-bindings: media: cedrus: Add compatibles for the A64 and H5 Paul Kocialkowski
2018-12-05 11:00   ` Maxime Ripard
2018-12-05  9:24 ` [PATCH v2 12/15] media: cedrus: Add device-tree compatible and variant for H5 support Paul Kocialkowski
2018-12-05 11:00   ` Maxime Ripard
2018-12-05  9:24 ` [PATCH v2 13/15] media: cedrus: Add device-tree compatible and variant for A64 support Paul Kocialkowski
2018-12-05 11:01   ` Maxime Ripard
2018-12-05  9:24 ` [PATCH v2 14/15] arm64: dts: allwinner: h5: Add Video Engine node Paul Kocialkowski
2018-12-05  9:24 ` [PATCH v2 15/15] arm64: dts: allwinner: a64: " Paul Kocialkowski
2018-12-07 21:22   ` [linux-sunxi] " Jernej Škrabec
2018-12-10  9:00     ` Paul Kocialkowski [this message]
2018-12-05  9:48 ` [PATCH v2 00/15] Cedrus H5 and A64 support with A33 and H3 updates Chen-Yu Tsai
2018-12-05 11:07   ` Maxime Ripard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c276fb045ab285c0907c4831f3b71a31f09cd4a5.camel@bootlin.com \
    --to=paul.kocialkowski@bootlin.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=devicetree@vger.kernel.org \
    --cc=hverkuil@xs4all.nl \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=mark.rutland@arm.com \
    --cc=maxime.ripard@bootlin.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).