* [PATCH] media: mediatek: vcodec: Fix non subdev architecture open power fail
@ 2022-06-17 3:21 Yunfei Dong
2022-06-17 6:56 ` Chen-Yu Tsai
0 siblings, 1 reply; 3+ messages in thread
From: Yunfei Dong @ 2022-06-17 3:21 UTC (permalink / raw)
To: Yunfei Dong, Alexandre Courbot, Nicolas Dufresne, Hans Verkuil,
AngeloGioacchino Del Regno, Benjamin Gaignard, Tiffany Lin,
Andrew-CT Chen, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tomasz Figa
Cc: George Sun, Xiaoyong Lu, Hsin-Yi Wang, Fritz Koenig,
Daniel Vetter, dri-devel, Irui Wang, Steve Cho, linux-media,
devicetree, linux-kernel, linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
According to subdev_bitmap bit value to open hardware power, need to
set subdev_bitmap value for non subdev architecture.
Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
index 995e6e2fb1ab..4103d7c1b638 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
@@ -386,6 +386,8 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
mtk_v4l2_err("Main device of_platform_populate failed.");
goto err_reg_cont;
}
+ } else {
+ set_bit(MTK_VDEC_CORE, dev->subdev_bitmap);
}
ret = video_register_device(vfd_dec, VFL_TYPE_VIDEO, -1);
--
2.18.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Fix non subdev architecture open power fail
2022-06-17 3:21 [PATCH] media: mediatek: vcodec: Fix non subdev architecture open power fail Yunfei Dong
@ 2022-06-17 6:56 ` Chen-Yu Tsai
2022-06-17 7:27 ` yunfei.dong
0 siblings, 1 reply; 3+ messages in thread
From: Chen-Yu Tsai @ 2022-06-17 6:56 UTC (permalink / raw)
To: Yunfei Dong
Cc: Alexandre Courbot, Nicolas Dufresne, Hans Verkuil,
AngeloGioacchino Del Regno, Benjamin Gaignard, Tiffany Lin,
Andrew-CT Chen, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tomasz Figa, George Sun, Xiaoyong Lu,
Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, dri-devel, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
On Fri, Jun 17, 2022 at 11:21 AM Yunfei Dong <yunfei.dong@mediatek.com> wrote:
>
> According to subdev_bitmap bit value to open hardware power, need to
> set subdev_bitmap value for non subdev architecture.
>
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
Fixes: c05bada35f01 ("media: mtk-vcodec: Add to support multi hardware decode")
?
ChenYu
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: mediatek: vcodec: Fix non subdev architecture open power fail
2022-06-17 6:56 ` Chen-Yu Tsai
@ 2022-06-17 7:27 ` yunfei.dong
0 siblings, 0 replies; 3+ messages in thread
From: yunfei.dong @ 2022-06-17 7:27 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Alexandre Courbot, Nicolas Dufresne, Hans Verkuil,
AngeloGioacchino Del Regno, Benjamin Gaignard, Tiffany Lin,
Andrew-CT Chen, Mauro Carvalho Chehab, Rob Herring,
Matthias Brugger, Tomasz Figa, George Sun, Xiaoyong Lu,
Hsin-Yi Wang, Fritz Koenig, Daniel Vetter, dri-devel, Irui Wang,
Steve Cho, linux-media, devicetree, linux-kernel,
linux-arm-kernel, linux-mediatek,
Project_Global_Chrome_Upstream_Group
Hi Chen-Yu,
Thanks for your suggestion.
On Fri, 2022-06-17 at 14:56 +0800, Chen-Yu Tsai wrote:
> On Fri, Jun 17, 2022 at 11:21 AM Yunfei Dong <
> yunfei.dong@mediatek.com> wrote:
> >
> > According to subdev_bitmap bit value to open hardware power, need
> > to
> > set subdev_bitmap value for non subdev architecture.
> >
> > Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
>
> Fixes: c05bada35f01 ("media: mtk-vcodec: Add to support multi
> hardware decode")
>
> ?
>
> ChenYu
Fix it in patch v2.
Best Regards,
Yunfei Dong
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-17 7:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-17 3:21 [PATCH] media: mediatek: vcodec: Fix non subdev architecture open power fail Yunfei Dong
2022-06-17 6:56 ` Chen-Yu Tsai
2022-06-17 7:27 ` yunfei.dong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).