From: Matthias Brugger <matthias.bgg@gmail.com>
To: Wen Su <Wen.Su@mediatek.com>, Mark Brown <broonie@kernel.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree@vger.kernel.org, wsd_upstream@mediatek.com,
linux-kernel@vger.kernel.org, Liam Girdwood <lgirdwood@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mediatek@lists.infradead.org,
Lee Jones <lee.jones@linaro.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: regulator: Add document for MT6359 regulator
Date: Tue, 11 Feb 2020 17:06:32 +0100 [thread overview]
Message-ID: <8398188f-820a-5abf-f52e-b79c0c583704@gmail.com> (raw)
In-Reply-To: <1581335854.16783.1.camel@mtkswgap22>
On 10/02/2020 12:57, Wen Su wrote:
> Hi,
>
> On Thu, 2020-02-06 at 11:49 +0000, Mark Brown wrote:
>> On Thu, Feb 06, 2020 at 11:06:48AM +0800, Wen Su wrote:
>>
>>> +Required properties:
>>> +- compatible: "mediatek,mt6359-regulator"
>>
>> Why does this need a compatible string - it looks like it's just
>> encoding the way Linux splits devices up into the DT, not
>> providing some reusable IP block.
>
> Thanks for your comments.
> I will remove it in the next patch.
>
If this the way to go, then please fix all the other MediaTek binding
description for regulators (+ the dts) as this is then wrong.
Thanks!
Matthias
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2020-02-11 16:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 3:06 [PATCH v2 0/4] Add Support for MediaTek PMIC MT6359 Regulator Wen Su
2020-02-06 3:06 ` [PATCH v2 1/4] dt-bindings: regulator: Add document for MT6359 regulator Wen Su
2020-02-06 11:49 ` Mark Brown
2020-02-10 11:57 ` Wen Su
2020-02-11 16:06 ` Matthias Brugger [this message]
2020-02-12 6:08 ` Wen Su
2020-02-06 3:06 ` [PATCH v2 2/4] mfd: Add for PMIC MT6359 registers definition Wen Su
2020-02-06 3:06 ` [PATCH v2 3/4] regulator: mt6359: Add support for MT6359 regulator Wen Su
2020-02-06 3:06 ` [PATCH v2 4/4] arm64: dts: mt6359: add PMIC MT6359 related nodes Wen Su
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8398188f-820a-5abf-f52e-b79c0c583704@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=Wen.Su@mediatek.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).