From: David Miller <davem@davemloft.net>
To: antoine.tenart@bootlin.com
Cc: richardcochran@gmail.com, alexandre.belloni@bootlin.com,
UNGLinuxDriver@microchip.com, ralf@linux-mips.org,
paul.burton@mips.com, jhogan@kernel.org, netdev@vger.kernel.org,
linux-mips@vger.kernel.org, thomas.petazzoni@bootlin.com,
allan.nielsen@microchip.com
Subject: Re: [PATCH net-next v3 8/8] net: mscc: PTP Hardware Clock (PHC) support
Date: Wed, 24 Jul 2019 11:52:26 -0700 (PDT) [thread overview]
Message-ID: <20190724.115226.478045379512899769.davem@davemloft.net> (raw)
In-Reply-To: <20190724081715.29159-9-antoine.tenart@bootlin.com>
From: Antoine Tenart <antoine.tenart@bootlin.com>
Date: Wed, 24 Jul 2019 10:17:15 +0200
> +static int ocelot_ptp_adjfine(struct ptp_clock_info *ptp, long scaled_ppm)
> +{
> + struct ocelot *ocelot = container_of(ptp, struct ocelot, ptp_info);
> + u32 unit = 0, direction = 0;
> + unsigned long flags;
^^^^
> + u64 adj = 0;
> +
> + if (!scaled_ppm)
> + goto disable_adj;
...
> +disable_adj:
> + ocelot_write(ocelot, 0, PTP_CLK_CFG_ADJ_CFG);
> +
> + spin_unlock_irqrestore(&ocelot->ptp_clock_lock, flags);
^^^^^
Did GCC really not warn about this in your build like it did immediately
on mine?
drivers/net/ethernet/mscc/ocelot.c: In function ‘ocelot_ptp_adjfine’:
./include/linux/spinlock.h:288:3: warning: ‘flags’ may be used uninitialized in this function [-Wmaybe-uninitialized]
_raw_spin_unlock_irqrestore(lock, flags); \
^~~~~~~~~~~~~~~~~~~~~~~~~~~
Please fix this and when you respin please just elide the MIPS tree
patches and just keep all the ones that I should apply to net-next.
Thank you.
next prev parent reply other threads:[~2019-07-24 18:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-24 8:17 [PATCH net-next v3 0/8] net: mscc: PTP Hardware Clock (PHC) support Antoine Tenart
2019-07-24 8:17 ` [PATCH net-next v3 1/8] Documentation/bindings: net: ocelot: document the PTP bank Antoine Tenart
2019-07-24 8:17 ` [PATCH net-next v3 2/8] MIPS: dts: mscc: describe the PTP register range Antoine Tenart
2019-08-24 14:18 ` Paul Burton
2019-07-24 8:17 ` [PATCH net-next v3 3/8] Documentation/bindings: net: ocelot: document the PTP ready IRQ Antoine Tenart
2019-07-24 8:17 ` [PATCH net-next v3 4/8] MIPS: dts: mscc: describe the PTP ready interrupt Antoine Tenart
2019-08-22 7:56 ` Antoine Tenart
2019-08-24 14:18 ` Paul Burton
2019-07-24 8:17 ` [PATCH net-next v3 5/8] net: mscc: describe the PTP register range Antoine Tenart
2019-07-24 8:17 ` [PATCH net-next v3 6/8] net: mscc: improve the frame header parsing readability Antoine Tenart
2019-07-24 8:17 ` [PATCH net-next v3 7/8] net: mscc: remove the frame_info cpuq member Antoine Tenart
2019-07-24 8:17 ` [PATCH net-next v3 8/8] net: mscc: PTP Hardware Clock (PHC) support Antoine Tenart
2019-07-24 13:53 ` Richard Cochran
2019-07-24 18:52 ` David Miller [this message]
2019-07-25 7:24 ` Antoine Tenart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190724.115226.478045379512899769.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=allan.nielsen@microchip.com \
--cc=antoine.tenart@bootlin.com \
--cc=jhogan@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=ralf@linux-mips.org \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).