From: Mike Rapoport <rppt@kernel.org>
To: linux-kernel@vger.kernel.org
Cc: "Alexandre Ghiti" <alexghiti@rivosinc.com>,
"Andrew Morton" <akpm@linux-foundation.org>,
"Björn Töpel" <bjorn@kernel.org>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Christophe Leroy" <christophe.leroy@csgroup.eu>,
"David S. Miller" <davem@davemloft.net>,
"Dinh Nguyen" <dinguyen@kernel.org>,
"Donald Dutile" <ddutile@redhat.com>,
"Eric Chanudet" <echanude@redhat.com>,
"Heiko Carstens" <hca@linux.ibm.com>,
"Helge Deller" <deller@gmx.de>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Kent Overstreet" <kent.overstreet@linux.dev>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Michael Ellerman" <mpe@ellerman.id.au>,
"Mike Rapoport" <rppt@kernel.org>,
"Nadav Amit" <nadav.amit@gmail.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Puranjay Mohan" <puranjay12@gmail.com>,
"Rick Edgecombe" <rick.p.edgecombe@intel.com>,
"Russell King" <linux@armlinux.org.uk>,
"Song Liu" <song@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Will Deacon" <will@kernel.org>,
bpf@vger.kernel.org, linux-arch@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org,
linux-mm@kvack.org, linux-modules@vger.kernel.org,
linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev,
netdev@vger.kernel.org, sparclinux@vger.kernel.org,
x86@kernel.org
Subject: [PATCH v4 03/15] nios2: define virtual address space for modules
Date: Thu, 11 Apr 2024 19:00:39 +0300 [thread overview]
Message-ID: <20240411160051.2093261-4-rppt@kernel.org> (raw)
In-Reply-To: <20240411160051.2093261-1-rppt@kernel.org>
From: "Mike Rapoport (IBM)" <rppt@kernel.org>
nios2 uses kmalloc() to implement module_alloc() because CALL26/PCREL26
cannot reach all of vmalloc address space.
Define module space as 32MiB below the kernel base and switch nios2 to
use vmalloc for module allocations.
Suggested-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Dinh Nguyen <dinguyen@kernel.org>
Acked-by: Song Liu <song@kernel.org>
Signed-off-by: Mike Rapoport (IBM) <rppt@kernel.org>
---
arch/nios2/include/asm/pgtable.h | 5 ++++-
arch/nios2/kernel/module.c | 19 ++++---------------
2 files changed, 8 insertions(+), 16 deletions(-)
diff --git a/arch/nios2/include/asm/pgtable.h b/arch/nios2/include/asm/pgtable.h
index d052dfcbe8d3..eab87c6beacb 100644
--- a/arch/nios2/include/asm/pgtable.h
+++ b/arch/nios2/include/asm/pgtable.h
@@ -25,7 +25,10 @@
#include <asm-generic/pgtable-nopmd.h>
#define VMALLOC_START CONFIG_NIOS2_KERNEL_MMU_REGION_BASE
-#define VMALLOC_END (CONFIG_NIOS2_KERNEL_REGION_BASE - 1)
+#define VMALLOC_END (CONFIG_NIOS2_KERNEL_REGION_BASE - SZ_32M - 1)
+
+#define MODULES_VADDR (CONFIG_NIOS2_KERNEL_REGION_BASE - SZ_32M)
+#define MODULES_END (CONFIG_NIOS2_KERNEL_REGION_BASE - 1)
struct mm_struct;
diff --git a/arch/nios2/kernel/module.c b/arch/nios2/kernel/module.c
index 76e0a42d6e36..9c97b7513853 100644
--- a/arch/nios2/kernel/module.c
+++ b/arch/nios2/kernel/module.c
@@ -21,23 +21,12 @@
#include <asm/cacheflush.h>
-/*
- * Modules should NOT be allocated with kmalloc for (obvious) reasons.
- * But we do it for now to avoid relocation issues. CALL26/PCREL26 cannot reach
- * from 0x80000000 (vmalloc area) to 0xc00000000 (kernel) (kmalloc returns
- * addresses in 0xc0000000)
- */
void *module_alloc(unsigned long size)
{
- if (size == 0)
- return NULL;
- return kmalloc(size, GFP_KERNEL);
-}
-
-/* Free memory returned from module_alloc */
-void module_memfree(void *module_region)
-{
- kfree(module_region);
+ return __vmalloc_node_range(size, 1, MODULES_VADDR, MODULES_END,
+ GFP_KERNEL, PAGE_KERNEL_EXEC,
+ VM_FLUSH_RESET_PERMS, NUMA_NO_NODE,
+ __builtin_return_address(0));
}
int apply_relocate_add(Elf32_Shdr *sechdrs, const char *strtab,
--
2.43.0
next prev parent reply other threads:[~2024-04-11 16:02 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-11 16:00 [PATCH v4 00/15] mm: jit/text allocator Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 01/15] arm64: module: remove uneeded call to kasan_alloc_module_shadow() Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 02/15] mips: module: rename MODULE_START to MODULES_VADDR Mike Rapoport
2024-04-11 16:00 ` Mike Rapoport [this message]
2024-04-11 16:00 ` [PATCH v4 04/15] module: make module_memory_{alloc,free} more self-contained Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 05/15] mm: introduce execmem_alloc() and execmem_free() Mike Rapoport
2024-04-11 19:42 ` Luis Chamberlain
2024-04-14 6:53 ` Mike Rapoport
2024-04-12 9:16 ` Ingo Molnar
2024-04-14 6:54 ` Mike Rapoport
2024-04-15 7:52 ` Peter Zijlstra
2024-04-15 16:51 ` Mike Rapoport
2024-04-15 17:36 ` Mark Rutland
2024-04-16 7:22 ` Mike Rapoport
2024-04-17 23:32 ` Song Liu
2024-04-18 15:35 ` Mike Rapoport
2024-04-18 16:13 ` Song Liu
2024-04-18 17:52 ` Mike Rapoport
2024-04-18 21:01 ` Song Liu
2024-04-19 6:55 ` Mike Rapoport
2024-04-19 15:54 ` Song Liu
2024-04-19 17:02 ` Mike Rapoport
2024-04-19 17:32 ` Song Liu
2024-04-19 19:59 ` Mike Rapoport
2024-04-19 21:42 ` Song Liu
2024-04-20 4:22 ` Mike Rapoport
2024-04-20 9:11 ` Masami Hiramatsu
2024-04-22 18:32 ` Song Liu
2024-04-17 21:06 ` Masami Hiramatsu
2024-04-11 16:00 ` [PATCH v4 06/15] mm/execmem, arch: convert simple overrides of module_alloc to execmem Mike Rapoport
2024-04-11 20:53 ` Sam Ravnborg
2024-04-14 7:26 ` Mike Rapoport
2024-04-15 8:03 ` Peter Zijlstra
2024-04-11 16:00 ` [PATCH v4 07/15] mm/execmem, arch: convert remaining " Mike Rapoport
2024-04-15 9:36 ` Peter Zijlstra
2024-04-11 16:00 ` [PATCH v4 08/15] arm64: extend execmem_info for generated code allocations Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 09/15] riscv: extend execmem_params " Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 10/15] powerpc: extend execmem_params for kprobes allocations Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 11/15] arch: make execmem setup available regardless of CONFIG_MODULES Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 12/15] x86/ftrace: enable dynamic ftrace without CONFIG_MODULES Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 13/15] powerpc: use CONFIG_EXECMEM instead of CONFIG_MODULES where appropiate Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 14/15] kprobes: remove dependency on CONFIG_MODULES Mike Rapoport
2024-04-17 21:16 ` Masami Hiramatsu
2024-04-18 15:37 ` Mike Rapoport
2024-04-19 15:49 ` Mike Rapoport
2024-04-19 15:59 ` Christophe Leroy
2024-04-20 7:33 ` Mike Rapoport
2024-04-20 9:15 ` Masami Hiramatsu
2024-04-20 10:52 ` Mike Rapoport
2024-04-11 16:00 ` [PATCH v4 15/15] bpf: remove CONFIG_BPF_JIT dependency on CONFIG_MODULES of Mike Rapoport
2024-04-11 18:00 ` [PATCH v4 00/15] mm: jit/text allocator Kent Overstreet
2024-04-11 19:45 ` Luis Chamberlain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240411160051.2093261-4-rppt@kernel.org \
--to=rppt@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alexghiti@rivosinc.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=catalin.marinas@arm.com \
--cc=chenhuacai@kernel.org \
--cc=christophe.leroy@csgroup.eu \
--cc=davem@davemloft.net \
--cc=ddutile@redhat.com \
--cc=deller@gmx.de \
--cc=dinguyen@kernel.org \
--cc=echanude@redhat.com \
--cc=hca@linux.ibm.com \
--cc=kent.overstreet@linux.dev \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=mcgrof@kernel.org \
--cc=mpe@ellerman.id.au \
--cc=nadav.amit@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=puranjay12@gmail.com \
--cc=rick.p.edgecombe@intel.com \
--cc=rostedt@goodmis.org \
--cc=song@kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).