* [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file.
@ 2019-11-21 1:41 Lichao Liu
2019-11-21 6:12 ` Jiaxun Yang
2019-11-21 6:17 ` Jiaxun Yang
0 siblings, 2 replies; 3+ messages in thread
From: Lichao Liu @ 2019-11-21 1:41 UTC (permalink / raw)
To: Huacai Chen
Cc: Ralf Baechle, Paul Burton, James Hogan, Marc Dionne,
David Howells, Lichao Liu, linux-mips, linux-kernel
Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
to control whether to include the asm/i8259.h header file.
Signed-off-by: Lichao Liu <liulichao@loongson.cn>
---
arch/mips/loongson64/common/pm.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/mips/loongson64/common/pm.c b/arch/mips/loongson64/common/pm.c
index b8aed878d..bc619e4d0 100644
--- a/arch/mips/loongson64/common/pm.c
+++ b/arch/mips/loongson64/common/pm.c
@@ -9,7 +9,9 @@
#include <linux/interrupt.h>
#include <linux/pm.h>
+#ifdef CONFIG_I8259
#include <asm/i8259.h>
+#endif
#include <asm/mipsregs.h>
#include <loongson.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file.
2019-11-21 1:41 [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file Lichao Liu
@ 2019-11-21 6:12 ` Jiaxun Yang
2019-11-21 6:17 ` Jiaxun Yang
1 sibling, 0 replies; 3+ messages in thread
From: Jiaxun Yang @ 2019-11-21 6:12 UTC (permalink / raw)
To: Lichao Liu, Huacai Chen
Cc: Ralf Baechle, Paul Burton, James Hogan, Marc Dionne,
David Howells, linux-mips, linux-kernel
于 2019年11月21日 GMT+08:00 上午9:41:56, Lichao Liu <liulichao@loongson.cn> 写到:
>Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
>to control whether to include the asm/i8259.h header file.
>
>Signed-off-by: Lichao Liu <liulichao@loongson.cn>
Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
I'm glad to see Loongson guys finally get here.
I will send v3 of my previous "modernize" set.
Which will also refactor interrupt part.
Do you have any comments based on v2 [1]?
[1]: https://patchwork.kernel.org/cover/11133237/
>---
> arch/mips/loongson64/common/pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/mips/loongson64/common/pm.c
>b/arch/mips/loongson64/common/pm.c
>index b8aed878d..bc619e4d0 100644
>--- a/arch/mips/loongson64/common/pm.c
>+++ b/arch/mips/loongson64/common/pm.c
>@@ -9,7 +9,9 @@
> #include <linux/interrupt.h>
> #include <linux/pm.h>
>
>+#ifdef CONFIG_I8259
> #include <asm/i8259.h>
>+#endif
> #include <asm/mipsregs.h>
>
> #include <loongson.h>
--
Jiaxun Yang
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file.
2019-11-21 1:41 [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file Lichao Liu
2019-11-21 6:12 ` Jiaxun Yang
@ 2019-11-21 6:17 ` Jiaxun Yang
1 sibling, 0 replies; 3+ messages in thread
From: Jiaxun Yang @ 2019-11-21 6:17 UTC (permalink / raw)
To: Lichao Liu, Huacai Chen
Cc: Ralf Baechle, Paul Burton, James Hogan, Marc Dionne,
David Howells, linux-mips, linux-kernel
于 2019年11月21日 GMT+08:00 上午9:41:56, Lichao Liu <liulichao@loongson.cn> 写到:
>Not all platform config CONFIG_I8259, So Use the macro CONFIG_I8259
>to control whether to include the asm/i8259.h header file.
You should have a dedicated short patch tittle.
Like MIPS: Loongson64: Limit i8259 include by config
>
>Signed-off-by: Lichao Liu <liulichao@loongson.cn>
>---
> arch/mips/loongson64/common/pm.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/arch/mips/loongson64/common/pm.c
>b/arch/mips/loongson64/common/pm.c
>index b8aed878d..bc619e4d0 100644
>--- a/arch/mips/loongson64/common/pm.c
>+++ b/arch/mips/loongson64/common/pm.c
>@@ -9,7 +9,9 @@
> #include <linux/interrupt.h>
> #include <linux/pm.h>
>
>+#ifdef CONFIG_I8259
> #include <asm/i8259.h>
>+#endif
> #include <asm/mipsregs.h>
>
> #include <loongson.h>
--
Jiaxun Yang
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-21 6:17 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-21 1:41 [PATCH] Use the macro CONFIG_I8259 to control whether to include the asm/i8259.h header file Lichao Liu
2019-11-21 6:12 ` Jiaxun Yang
2019-11-21 6:17 ` Jiaxun Yang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).