From: Zi Yan <ziy@nvidia.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "\"Huang,
Ying\"" <ying.huang@intel.com>,
Ryan Roberts <ryan.roberts@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
"\"Matthew Wilcox (Oracle)\"" <willy@infradead.org>,
David Hildenbrand <david@redhat.com>,
"\"Yin, Fengwei\"" <fengwei.yin@intel.com>,
Yu Zhao <yuzhao@google.com>,
"\"Kirill A . Shutemov\"" <kirill.shutemov@linux.intel.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Kemeng Shi <shikemeng@huaweicloud.com>,
Mel Gorman <mgorman@techsingularity.net>,
Rohan Puri <rohan.puri15@gmail.com>,
Mcgrof Chamberlain <mcgrof@kernel.org>,
Adam Manzanares <a.manzanares@samsung.com>,
"\"Vishal Moola (Oracle)\"" <vishal.moola@gmail.com>
Subject: Re: [PATCH v3 2/3] mm/compaction: add support for >0 order folio memory compaction.
Date: Fri, 09 Feb 2024 16:58:59 -0500 [thread overview]
Message-ID: <06B3E4A1-856F-4469-A703-37C98F3DD062@nvidia.com> (raw)
In-Reply-To: <025b7e7c-b17f-47c7-8677-ee36fc6dbc52@suse.cz>
[-- Attachment #1: Type: text/plain, Size: 697 bytes --]
On 9 Feb 2024, at 11:37, Vlastimil Babka wrote:
>>
>> extern void free_unref_page(struct page *page, unsigned int order);
>> @@ -473,6 +475,11 @@ int split_free_page(struct page *free_page,
>> /*
>> * in mm/compaction.c
>> */
>> +
>> +struct page_list {
>> + struct list_head pages;
>> + unsigned long nr_pages;
>
> I've checked and even with patch 3/3 I don't think you actually need the
> counter? The only check of the counter I noticed was to check for
> zero/non-zero, and you could use list_empty() instead.
Should I just use struct list_head instead of a new struct page_list?
list_empty(&cc->freepages[order]) vs list_empty(&cc->freepages[order].pages).
--
Best Regards,
Yan, Zi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 854 bytes --]
next prev parent reply other threads:[~2024-02-09 21:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 16:15 [PATCH v3 0/3] Enable >0 order folio memory compaction Zi Yan
2024-02-02 16:15 ` [PATCH v3 1/3] mm/compaction: enable compacting >0 order folios Zi Yan
2024-02-09 14:32 ` Vlastimil Babka
2024-02-09 19:25 ` Zi Yan
2024-02-09 20:43 ` Vlastimil Babka
2024-02-09 20:44 ` Zi Yan
2024-02-02 16:15 ` [PATCH v3 2/3] mm/compaction: add support for >0 order folio memory compaction Zi Yan
2024-02-09 16:37 ` Vlastimil Babka
2024-02-09 19:36 ` Zi Yan
2024-02-09 19:40 ` Zi Yan
2024-02-09 20:46 ` Vlastimil Babka
2024-02-09 20:47 ` Zi Yan
2024-02-09 21:58 ` Zi Yan [this message]
2024-02-02 16:15 ` [PATCH v3 3/3] mm/compaction: optimize >0 order folio compaction with free page split Zi Yan
2024-02-09 18:43 ` Vlastimil Babka
2024-02-09 19:57 ` Zi Yan
2024-02-09 20:49 ` Vlastimil Babka
2024-02-02 19:55 ` [PATCH v3 0/3] Enable >0 order folio memory compaction Luis Chamberlain
2024-02-02 20:12 ` Zi Yan
2024-02-05 8:16 ` Baolin Wang
2024-02-05 14:18 ` Zi Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06B3E4A1-856F-4469-A703-37C98F3DD062@nvidia.com \
--to=ziy@nvidia.com \
--cc=a.manzanares@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=baolin.wang@linux.alibaba.com \
--cc=david@redhat.com \
--cc=fengwei.yin@intel.com \
--cc=hannes@cmpxchg.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@techsingularity.net \
--cc=rohan.puri15@gmail.com \
--cc=ryan.roberts@arm.com \
--cc=shikemeng@huaweicloud.com \
--cc=vbabka@suse.cz \
--cc=vishal.moola@gmail.com \
--cc=willy@infradead.org \
--cc=ying.huang@intel.com \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).