From: Anshuman Khandual <anshuman.khandual@arm.com>
To: David Hildenbrand <david@redhat.com>, linux-kernel@vger.kernel.org
Cc: linux-mm@kvack.org, "Michael S. Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Pankaj Gupta <pankaj.gupta.linux@gmail.com>,
Michal Hocko <mhocko@kernel.org>,
Oscar Salvador <osalvador@suse.de>,
Wei Yang <richard.weiyang@linux.alibaba.com>,
Andrew Morton <akpm@linux-foundation.org>,
catalin.marinas@arm.com, teawater <teawaterz@linux.alibaba.com>,
Pankaj Gupta <pankaj.gupta@cloud.ionos.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
hca@linux.ibm.com, Vasily Gorbik <gor@linux.ibm.com>,
Will Deacon <will@kernel.org>, Ard Biesheuvel <ardb@kernel.org>,
Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH RFC] virtio-mem: check against memhp_get_pluggable_range() which memory we can hotplug
Date: Tue, 12 Jan 2021 09:55:26 +0530 [thread overview]
Message-ID: <0d5b797b-8a1c-7ee5-c821-99e065e9c489@arm.com> (raw)
In-Reply-To: <20210111124140.11423-1-david@redhat.com>
On 1/11/21 6:11 PM, David Hildenbrand wrote:
> Right now, we only check against MAX_PHYSMEM_BITS - but turns out there
> are more restrictions of which memory we can actually hotplug, especially
> om arm64 or s390x once we support them: we might receive something like
> -E2BIG or -ERANGE from add_memory_driver_managed(), stopping device
> operation.
>
> So, check right when initializing the device which memory we can add,
> warning the user. Try only adding actually pluggable ranges: in the worst
> case, no memory provided by our device is pluggable.
>
> In the usual case, we expect all device memory to be pluggable, and in
> corner cases only some memory at the end of the device-managed memory
> region to not be pluggable.
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Jason Wang <jasowang@redhat.com>
> Cc: Pankaj Gupta <pankaj.gupta.linux@gmail.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Cc: Oscar Salvador <osalvador@suse.de>
> Cc: Wei Yang <richard.weiyang@linux.alibaba.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: catalin.marinas@arm.com
> Cc: teawater <teawaterz@linux.alibaba.com>
> Cc: Anshuman Khandual <anshuman.khandual@arm.com>
> Cc: Pankaj Gupta <pankaj.gupta@cloud.ionos.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: hca@linux.ibm.com
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Will Deacon <will@kernel.org>
> Cc: Ard Biesheuvel <ardb@kernel.org>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Michal Hocko <mhocko@kernel.org>
> Signed-off-by: David Hildenbrand <david@redhat.com>
> ---
>
> This is an example how virito-mem intends to use an interface like
> memhp_get_pluggable_range() once around. See:
>
> "[PATCH V2 0/3] mm/hotplug: Pre-validate the address range with platform"
> https://lkml.kernel.org/r/1608218912-28932-1-git-send-email-anshuman.khandual@arm.com
>
> @Anshuman, feel free to pick up and carry this patch. I'll retest the final
> result / new versions of you series.
Makes sense, will carry this patch in the series.
next prev parent reply other threads:[~2021-01-12 4:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 15:28 [PATCH V2 0/3] mm/hotplug: Pre-validate the address range with platform Anshuman Khandual
2020-12-17 15:28 ` [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added " Anshuman Khandual
2021-01-11 10:51 ` David Hildenbrand
2021-01-11 13:43 ` Oscar Salvador
2021-01-12 3:51 ` Anshuman Khandual
2021-01-12 10:09 ` David Hildenbrand
2021-01-13 5:04 ` Anshuman Khandual
2021-01-12 3:43 ` Anshuman Khandual
2020-12-17 15:28 ` [PATCH V2 2/3] arm64/mm: Define arch_get_mappable_range() Anshuman Khandual
2020-12-17 15:28 ` [PATCH V2 3/3] s390/mm: " Anshuman Khandual
2021-01-11 10:40 ` David Hildenbrand
2021-01-13 7:02 ` Anshuman Khandual
2020-12-17 17:31 ` [PATCH V2 0/3] mm/hotplug: Pre-validate the address range with platform David Hildenbrand
2021-01-11 12:41 ` [PATCH RFC] virtio-mem: check against memhp_get_pluggable_range() which memory we can hotplug David Hildenbrand
2021-01-12 4:25 ` Anshuman Khandual [this message]
2021-01-18 13:12 [PATCH V3 0/3] mm/memory_hotplug: Pre-validate the address range with platform Anshuman Khandual
2021-01-18 13:13 ` [PATCH RFC] virtio-mem: check against memhp_get_pluggable_range() which memory we can hotplug Anshuman Khandual
2021-01-18 13:21 ` Anshuman Khandual
2021-01-19 12:27 ` David Hildenbrand
2021-01-21 9:57 ` David Hildenbrand
2021-01-22 3:32 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d5b797b-8a1c-7ee5-c821-99e065e9c489@arm.com \
--to=anshuman.khandual@arm.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=david@redhat.com \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=jasowang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mhocko@kernel.org \
--cc=mst@redhat.com \
--cc=osalvador@suse.de \
--cc=pankaj.gupta.linux@gmail.com \
--cc=pankaj.gupta@cloud.ionos.com \
--cc=richard.weiyang@linux.alibaba.com \
--cc=teawaterz@linux.alibaba.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).