linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Oscar Salvador <osalvador@suse.de>, David Hildenbrand <david@redhat.com>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com,
	catalin.marinas@arm.com, linux-arm-kernel@lists.infradead.org,
	linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
	Vasily Gorbik <gor@linux.ibm.com>, Will Deacon <will@kernel.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>
Subject: Re: [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added with platform
Date: Tue, 12 Jan 2021 09:21:18 +0530	[thread overview]
Message-ID: <e2b53f0a-482d-2045-6162-6de2510c9690@arm.com> (raw)
In-Reply-To: <20210111134303.GA3031@linux>



On 1/11/21 7:13 PM, Oscar Salvador wrote:
> On Mon, Jan 11, 2021 at 11:51:47AM +0100, David Hildenbrand wrote:
>> AFAIKs, all memhp_get_pluggable_range() users pass "1".
>>
>> What about the "add_pages()-only" path?
> 
> I guess you refer to memremap_pages(), right?

Right, via pagemap_range().

> If so, moving the added memhp_range_allowed() check above the if-else might do
> the trick
> 
We had that code in the earlier version. But dropped it, as we did
not want to add any new checks in the generic code. Can add it back
if that is preferred.


  reply	other threads:[~2021-01-12  3:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-17 15:28 [PATCH V2 0/3] mm/hotplug: Pre-validate the address range with platform Anshuman Khandual
2020-12-17 15:28 ` [PATCH V2 1/3] mm/hotplug: Prevalidate the address range being added " Anshuman Khandual
2021-01-11 10:51   ` David Hildenbrand
2021-01-11 13:43     ` Oscar Salvador
2021-01-12  3:51       ` Anshuman Khandual [this message]
2021-01-12 10:09         ` David Hildenbrand
2021-01-13  5:04           ` Anshuman Khandual
2021-01-12  3:43     ` Anshuman Khandual
2020-12-17 15:28 ` [PATCH V2 2/3] arm64/mm: Define arch_get_mappable_range() Anshuman Khandual
2020-12-17 15:28 ` [PATCH V2 3/3] s390/mm: " Anshuman Khandual
2021-01-11 10:40   ` David Hildenbrand
2021-01-13  7:02     ` Anshuman Khandual
2020-12-17 17:31 ` [PATCH V2 0/3] mm/hotplug: Pre-validate the address range with platform David Hildenbrand
2021-01-11 12:41 ` [PATCH RFC] virtio-mem: check against memhp_get_pluggable_range() which memory we can hotplug David Hildenbrand
2021-01-12  4:25   ` Anshuman Khandual

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2b53f0a-482d-2045-6162-6de2510c9690@arm.com \
    --to=anshuman.khandual@arm.com \
    --cc=akpm@linux-foundation.org \
    --cc=ardb@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=david@redhat.com \
    --cc=gor@linux.ibm.com \
    --cc=hca@linux.ibm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=osalvador@suse.de \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).