From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Cc: Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
xishi.qiuxishi@alibaba-inc.com,
Laurent Dufour <ldufour@linux.vnet.ibm.com>
Subject: [PATCH RFC v1 00/11] hwpoison improvement part 1
Date: Fri, 9 Nov 2018 15:47:04 +0900 [thread overview]
Message-ID: <1541746035-13408-1-git-send-email-n-horiguchi@ah.jp.nec.com> (raw)
Hi everyone,
I wrote hwpoison patches which partially mention the problems
discussed recently on this area [1].
Main point of this series is how we isolate faulty pages more
safely/reliable. As pointed out from Michal in thread [2], we can
have better isolation functions rather than what we currently have.
Patch 8/11 gives the implementation. As a result, the behavior of
poisoned pages (at least from soft-offline) are more predictable
and I think that memory hotremove should properly work with it.
The structure of this series:
- patch 1-7 are small fixes, preparation, and/or cleanup.
I can separate these out from main part if you like.
- patch 8 is core part of this series, providing some code
to pick out the target page from buddy allocator,
- patch 9-11 are changes on caller sides (hard-offline,
hotremove and unpoison.)
One big issue not addressed by this series is hard-offlining hugetlb,
which is still a todo unfortunately.
Another remaining work is to rework on the behavior of PG_hwpoison
flag from hard-offlining of in-use page. Even with this series,
hard-offline for in-use pages works as in the past (i.e. we still take
racy "set PG_hwpoison at first, then do some handling" approach.)
Without changing this, we can't be free from many "if (PageHWPoison)"
checks in mm code. So I'll think/try more about it after this one.
Anyway this is the first step for better solution (I believe,)
and any kind of help is applicated.
Thanks,
Naoya Horiguchi
[1]: https://lwn.net/Articles/753261/
[2]: https://lkml.org/lkml/2018/7/17/60
---
Summary:
Naoya Horiguchi (11):
mm: hwpoison: cleanup unused PageHuge() check
mm: soft-offline: add missing error check of set_hwpoison_free_buddy_page()
mm: move definition of num_poisoned_pages_inc/dec to include/linux/mm.h
mm: madvise: call soft_offline_page() without MF_COUNT_INCREASED
mm: hwpoison-inject: don't pin for hwpoison_filter()
mm: hwpoison: remove MF_COUNT_INCREASED
mm: remove flag argument from soft offline functions
mm: soft-offline: isolate error pages from buddy freelist
mm: hwpoison: apply buddy page handling code to hard-offline
mm: clear PageHWPoison in memory hotremove
mm: hwpoison: introduce clear_hwpoison_free_buddy_page()
drivers/base/memory.c | 2 +-
include/linux/mm.h | 22 ++++++---
include/linux/page-flags.h | 8 +++-
include/linux/swapops.h | 16 -------
mm/hwpoison-inject.c | 18 ++------
mm/madvise.c | 25 +++++-----
mm/memory-failure.c | 112 ++++++++++++++++++++++++++-------------------
mm/migrate.c | 9 ----
mm/page_alloc.c | 95 +++++++++++++++++++++++++++++++++++---
mm/sparse.c | 2 +-
10 files changed, 193 insertions(+), 116 deletions(-)
next reply other threads:[~2018-11-09 6:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 6:47 Naoya Horiguchi [this message]
2018-11-09 6:47 ` [RFC][PATCH v1 01/11] mm: hwpoison: cleanup unused PageHuge() check Naoya Horiguchi
2018-11-09 9:52 ` Anshuman Khandual
2018-11-09 6:47 ` [RFC][PATCH v1 02/11] mm: soft-offline: add missing error check of set_hwpoison_free_buddy_page() Naoya Horiguchi
2018-11-09 10:20 ` Anshuman Khandual
2018-11-13 0:16 ` Naoya Horiguchi
2018-11-14 8:53 ` Anshuman Khandual
2018-11-09 6:47 ` [RFC][PATCH v1 03/11] mm: move definition of num_poisoned_pages_inc/dec to include/linux/mm.h Naoya Horiguchi
2018-11-09 10:28 ` Anshuman Khandual
2018-11-13 0:17 ` Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 04/11] mm: madvise: call soft_offline_page() without MF_COUNT_INCREASED Naoya Horiguchi
2018-11-09 10:46 ` Anshuman Khandual
2018-11-13 0:18 ` Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 05/11] mm: hwpoison-inject: don't pin for hwpoison_filter() Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 06/11] mm: hwpoison: remove MF_COUNT_INCREASED Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 07/11] mm: remove flag argument from soft offline functions Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 08/11] mm: soft-offline: isolate error pages from buddy freelist Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 09/11] mm: hwpoison: apply buddy page handling code to hard-offline Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 10/11] mm: clear PageHWPoison in memory hotremove Naoya Horiguchi
2018-11-13 1:32 ` Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 11/11] mm: hwpoison: introduce clear_hwpoison_free_buddy_page() Naoya Horiguchi
2018-11-09 11:33 ` Anshuman Khandual
2018-11-13 0:19 ` Naoya Horiguchi
2018-11-14 8:23 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1541746035-13408-1-git-send-email-n-horiguchi@ah.jp.nec.com \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=xishi.qiuxishi@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).