From: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
To: Anshuman Khandual <anshuman.khandual@arm.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Kravetz <mike.kravetz@oracle.com>,
"xishi.qiuxishi@alibaba-inc.com" <xishi.qiuxishi@alibaba-inc.com>,
Laurent Dufour <ldufour@linux.vnet.ibm.com>
Subject: Re: [RFC][PATCH v1 03/11] mm: move definition of num_poisoned_pages_inc/dec to include/linux/mm.h
Date: Tue, 13 Nov 2018 00:17:31 +0000 [thread overview]
Message-ID: <20181113001730.GB5945@hori1.linux.bs1.fc.nec.co.jp> (raw)
In-Reply-To: <e4c4ae14-0d55-0738-9257-2c1232acef33@arm.com>
On Fri, Nov 09, 2018 at 03:58:27PM +0530, Anshuman Khandual wrote:
>
>
> On 11/09/2018 12:17 PM, Naoya Horiguchi wrote:
> > num_poisoned_pages_inc/dec had better be visible to some file like
> > mm/sparse.c and mm/page_alloc.c (for a subsequent patch). So let's
> > move it to include/linux/mm.h.
> >
> > Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
> > ---
> > include/linux/mm.h | 13 ++++++++++++-
> > include/linux/swapops.h | 16 ----------------
> > mm/sparse.c | 2 +-
> > 3 files changed, 13 insertions(+), 18 deletions(-)
> >
> > diff --git v4.19-mmotm-2018-10-30-16-08/include/linux/mm.h v4.19-mmotm-2018-10-30-16-08_patched/include/linux/mm.h
> > index 59df394..22623ba 100644
> > --- v4.19-mmotm-2018-10-30-16-08/include/linux/mm.h
> > +++ v4.19-mmotm-2018-10-30-16-08_patched/include/linux/mm.h
> > @@ -2741,7 +2741,7 @@ extern void shake_page(struct page *p, int access);
> > extern atomic_long_t num_poisoned_pages __read_mostly;
> > extern int soft_offline_page(struct page *page, int flags);
> >
> > -
> > +#ifdef CONFIG_MEMORY_FAILURE
> > /*
> > * Error handlers for various types of pages.
> > */
> > @@ -2777,6 +2777,17 @@ enum mf_action_page_type {
> > MF_MSG_UNKNOWN,
> > };
> >
> > +static inline void num_poisoned_pages_inc(void)
> > +{
> > + atomic_long_inc(&num_poisoned_pages);
> > +}
> > +
> > +static inline void num_poisoned_pages_dec(void)
> > +{
> > + atomic_long_dec(&num_poisoned_pages);
> > +}
> > +#endif
> > +
> > #if defined(CONFIG_TRANSPARENT_HUGEPAGE) || defined(CONFIG_HUGETLBFS)
> > extern void clear_huge_page(struct page *page,
> > unsigned long addr_hint,
> > diff --git v4.19-mmotm-2018-10-30-16-08/include/linux/swapops.h v4.19-mmotm-2018-10-30-16-08_patched/include/linux/swapops.h
> > index 4d96166..88137e9 100644
> > --- v4.19-mmotm-2018-10-30-16-08/include/linux/swapops.h
> > +++ v4.19-mmotm-2018-10-30-16-08_patched/include/linux/swapops.h
> > @@ -320,8 +320,6 @@ static inline int is_pmd_migration_entry(pmd_t pmd)
> >
> > #ifdef CONFIG_MEMORY_FAILURE
> >
> > -extern atomic_long_t num_poisoned_pages __read_mostly;
> > -
> > /*
> > * Support for hardware poisoned pages
> > */
> > @@ -336,16 +334,6 @@ static inline int is_hwpoison_entry(swp_entry_t entry)
> > return swp_type(entry) == SWP_HWPOISON;
> > }
> >
> > -static inline void num_poisoned_pages_inc(void)
> > -{
> > - atomic_long_inc(&num_poisoned_pages);
> > -}
> > -
> > -static inline void num_poisoned_pages_dec(void)
> > -{
> > - atomic_long_dec(&num_poisoned_pages);
> > -}
> > -
> > #else
> >
> > static inline swp_entry_t make_hwpoison_entry(struct page *page)
> > @@ -357,10 +345,6 @@ static inline int is_hwpoison_entry(swp_entry_t swp)
> > {
> > return 0;
> > }
> > -
> > -static inline void num_poisoned_pages_inc(void)
> > -{
> > -}
>
> I hope this was a stray definition and redundant which does not prevent
> build in absence of CONFIG_MEMORY_FAILURE.
You're right :)
> > #endif
> >
> > #if defined(CONFIG_MEMORY_FAILURE) || defined(CONFIG_MIGRATION)
> > diff --git v4.19-mmotm-2018-10-30-16-08/mm/sparse.c v4.19-mmotm-2018-10-30-16-08_patched/mm/sparse.c
> > index 33307fc..7ada2e5 100644
> > --- v4.19-mmotm-2018-10-30-16-08/mm/sparse.c
> > +++ v4.19-mmotm-2018-10-30-16-08_patched/mm/sparse.c
> > @@ -726,7 +726,7 @@ static void clear_hwpoisoned_pages(struct page *memmap, int nr_pages)
> >
> > for (i = 0; i < nr_pages; i++) {
> > if (PageHWPoison(&memmap[i])) {
> > - atomic_long_sub(1, &num_poisoned_pages);
> > + num_poisoned_pages_dec();
> > ClearPageHWPoison(&memmap[i]);
> > }
> > }
> >
>
> Otherwise looks good.
>
> Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Thanks!
Naoya Horiguchi
next prev parent reply other threads:[~2018-11-13 0:21 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 6:47 [PATCH RFC v1 00/11] hwpoison improvement part 1 Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 01/11] mm: hwpoison: cleanup unused PageHuge() check Naoya Horiguchi
2018-11-09 9:52 ` Anshuman Khandual
2018-11-09 6:47 ` [RFC][PATCH v1 02/11] mm: soft-offline: add missing error check of set_hwpoison_free_buddy_page() Naoya Horiguchi
2018-11-09 10:20 ` Anshuman Khandual
2018-11-13 0:16 ` Naoya Horiguchi
2018-11-14 8:53 ` Anshuman Khandual
2018-11-09 6:47 ` [RFC][PATCH v1 03/11] mm: move definition of num_poisoned_pages_inc/dec to include/linux/mm.h Naoya Horiguchi
2018-11-09 10:28 ` Anshuman Khandual
2018-11-13 0:17 ` Naoya Horiguchi [this message]
2018-11-09 6:47 ` [RFC][PATCH v1 04/11] mm: madvise: call soft_offline_page() without MF_COUNT_INCREASED Naoya Horiguchi
2018-11-09 10:46 ` Anshuman Khandual
2018-11-13 0:18 ` Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 05/11] mm: hwpoison-inject: don't pin for hwpoison_filter() Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 06/11] mm: hwpoison: remove MF_COUNT_INCREASED Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 07/11] mm: remove flag argument from soft offline functions Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 08/11] mm: soft-offline: isolate error pages from buddy freelist Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 09/11] mm: hwpoison: apply buddy page handling code to hard-offline Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 10/11] mm: clear PageHWPoison in memory hotremove Naoya Horiguchi
2018-11-13 1:32 ` Naoya Horiguchi
2018-11-09 6:47 ` [RFC][PATCH v1 11/11] mm: hwpoison: introduce clear_hwpoison_free_buddy_page() Naoya Horiguchi
2018-11-09 11:33 ` Anshuman Khandual
2018-11-13 0:19 ` Naoya Horiguchi
2018-11-14 8:23 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181113001730.GB5945@hori1.linux.bs1.fc.nec.co.jp \
--to=n-horiguchi@ah.jp.nec.com \
--cc=akpm@linux-foundation.org \
--cc=anshuman.khandual@arm.com \
--cc=ldufour@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=mike.kravetz@oracle.com \
--cc=xishi.qiuxishi@alibaba-inc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).