* [PATCH] mm: fix comments related to node reclaim
@ 2019-11-25 14:20 Hao Lee
2019-11-26 9:43 ` Anshuman Khandual
0 siblings, 1 reply; 3+ messages in thread
From: Hao Lee @ 2019-11-25 14:20 UTC (permalink / raw)
To: akpm; +Cc: mgorman, linux-mm, linux-kernel, haolee.swjtu
As zone reclaim has been replaced by node reclaim, this patch fixes related
comments.
Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
---
include/linux/mmzone.h | 2 +-
include/uapi/linux/capability.h | 2 +-
include/uapi/linux/sysctl.h | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
index 9e47289a4511..7e3208f4f5bc 100644
--- a/include/linux/mmzone.h
+++ b/include/linux/mmzone.h
@@ -747,7 +747,7 @@ typedef struct pglist_data {
#ifdef CONFIG_NUMA
/*
- * zone reclaim becomes active if more unmapped pages exist.
+ * node reclaim becomes active if more unmapped pages exist.
*/
unsigned long min_unmapped_pages;
unsigned long min_slab_pages;
diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
index 240fdb9a60f6..dd6772f16eec 100644
--- a/include/uapi/linux/capability.h
+++ b/include/uapi/linux/capability.h
@@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
/* Allow enabling/disabling tagged queuing on SCSI controllers and sending
arbitrary SCSI commands */
/* Allow setting encryption key on loopback filesystem */
-/* Allow setting zone reclaim policy */
+/* Allow setting node reclaim policy */
#define CAP_SYS_ADMIN 21
diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
index 87aa2a6d9125..27c1ed2822e6 100644
--- a/include/uapi/linux/sysctl.h
+++ b/include/uapi/linux/sysctl.h
@@ -195,7 +195,7 @@ enum
VM_MIN_UNMAPPED=32, /* Set min percent of unmapped pages */
VM_PANIC_ON_OOM=33, /* panic at out-of-memory */
VM_VDSO_ENABLED=34, /* map VDSO into new processes? */
- VM_MIN_SLAB=35, /* Percent pages ignored by zone reclaim */
+ VM_MIN_SLAB=35, /* Percent pages ignored by node reclaim */
};
--
2.14.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: fix comments related to node reclaim
2019-11-25 14:20 [PATCH] mm: fix comments related to node reclaim Hao Lee
@ 2019-11-26 9:43 ` Anshuman Khandual
2019-11-26 14:09 ` Hao Lee
0 siblings, 1 reply; 3+ messages in thread
From: Anshuman Khandual @ 2019-11-26 9:43 UTC (permalink / raw)
To: Hao Lee, akpm; +Cc: mgorman, linux-mm, linux-kernel
On 11/25/2019 07:50 PM, Hao Lee wrote:
> As zone reclaim has been replaced by node reclaim, this patch fixes related
> comments.
>
> Signed-off-by: Hao Lee <haolee.swjtu@gmail.com>
> ---
> include/linux/mmzone.h | 2 +-
> include/uapi/linux/capability.h | 2 +-
> include/uapi/linux/sysctl.h | 2 +-
> 3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/linux/mmzone.h b/include/linux/mmzone.h
> index 9e47289a4511..7e3208f4f5bc 100644
> --- a/include/linux/mmzone.h
> +++ b/include/linux/mmzone.h
> @@ -747,7 +747,7 @@ typedef struct pglist_data {
>
> #ifdef CONFIG_NUMA
> /*
> - * zone reclaim becomes active if more unmapped pages exist.
> + * node reclaim becomes active if more unmapped pages exist.
> */
> unsigned long min_unmapped_pages;
> unsigned long min_slab_pages;
> diff --git a/include/uapi/linux/capability.h b/include/uapi/linux/capability.h
> index 240fdb9a60f6..dd6772f16eec 100644
> --- a/include/uapi/linux/capability.h
> +++ b/include/uapi/linux/capability.h
> @@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
> /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
> arbitrary SCSI commands */
> /* Allow setting encryption key on loopback filesystem */
> -/* Allow setting zone reclaim policy */
> +/* Allow setting node reclaim policy */
Does this point to the capability for accessing vm.zone_reclaim_mode = 0
sysctl knob ? In that case we should not be changing the name here as the
interface still retains the original name 'zone_reclaim_mode'.
>
> #define CAP_SYS_ADMIN 21
>
> diff --git a/include/uapi/linux/sysctl.h b/include/uapi/linux/sysctl.h
> index 87aa2a6d9125..27c1ed2822e6 100644
> --- a/include/uapi/linux/sysctl.h
> +++ b/include/uapi/linux/sysctl.h
> @@ -195,7 +195,7 @@ enum
> VM_MIN_UNMAPPED=32, /* Set min percent of unmapped pages */
> VM_PANIC_ON_OOM=33, /* panic at out-of-memory */
> VM_VDSO_ENABLED=34, /* map VDSO into new processes? */
> - VM_MIN_SLAB=35, /* Percent pages ignored by zone reclaim */
> + VM_MIN_SLAB=35, /* Percent pages ignored by node reclaim */
> };
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm: fix comments related to node reclaim
2019-11-26 9:43 ` Anshuman Khandual
@ 2019-11-26 14:09 ` Hao Lee
0 siblings, 0 replies; 3+ messages in thread
From: Hao Lee @ 2019-11-26 14:09 UTC (permalink / raw)
To: Anshuman Khandual; +Cc: akpm, mgorman, linux-mm, linux-kernel
On Tue, 26 Nov 2019 at 17:42, Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
> On 11/25/2019 07:50 PM, Hao Lee wrote:
> > --- a/include/uapi/linux/capability.h
> > +++ b/include/uapi/linux/capability.h
> > @@ -273,7 +273,7 @@ struct vfs_ns_cap_data {
> > /* Allow enabling/disabling tagged queuing on SCSI controllers and sending
> > arbitrary SCSI commands */
> > /* Allow setting encryption key on loopback filesystem */
> > -/* Allow setting zone reclaim policy */
> > +/* Allow setting node reclaim policy */
>
> Does this point to the capability for accessing vm.zone_reclaim_mode = 0
> sysctl knob ? In that case we should not be changing the name here as the
> interface still retains the original name 'zone_reclaim_mode'.
Yes. This comment should be consistent with sysctl documentation and
interface. Thanks for your correction!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-26 14:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-25 14:20 [PATCH] mm: fix comments related to node reclaim Hao Lee
2019-11-26 9:43 ` Anshuman Khandual
2019-11-26 14:09 ` Hao Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).