From: kbuild test robot <lkp@intel.com>
To: Mike Rapoport <rppt@kernel.org>
Cc: kbuild-all@lists.01.org, Andy Lutomirski <luto@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Alexey Dobriyan <adobriyan@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
James Bottomley <jejb@linux.ibm.com>,
Peter Zijlstra <peterz@infradead.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Linux API <linux-api@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>, X86 ML <x86@kernel.org>,
Mike Rapoport <rppt@linux.ibm.com>,
Alan Cox <alan@linux.intel.com>,
"Reshetova, Elena" <elena.reshetova@intel.com>,
Tycho Andersen <tycho@tycho.ws>,
Christopher Lameter <cl@linux.com>
Subject: Re: [PATCH] mm: extend memfd with ability to create secret memory
Date: Sun, 8 Dec 2019 22:10:08 +0800 [thread overview]
Message-ID: <201912082019.UdtZtXJf%lkp@intel.com> (raw)
In-Reply-To: <20191205153400.GA25575@rapoport-lnx>
[-- Attachment #1: Type: text/plain, Size: 3891 bytes --]
Hi Mike,
I love your patch! Yet something to improve:
[auto build test ERROR on mmotm/master]
[also build test ERROR on linux/master v5.4]
[cannot apply to arm-soc/for-next linus/master next-20191208]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
url: https://github.com/0day-ci/linux/commits/Mike-Rapoport/mm-extend-memfd-with-ability-to-create-secret-memory/20191207-130906
base: git://git.cmpxchg.org/linux-mmotm.git master
config: arm64-randconfig-a001-20191208 (attached as .config)
compiler: aarch64-linux-gcc (GCC) 7.5.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.5.0 make.cross ARCH=arm64
If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
mm/secretmem.c: In function 'secretmem_fault':
>> mm/secretmem.c:45:9: error: implicit declaration of function 'set_pages_array_uc'; did you mean 'set_page_dirty_lock'? [-Werror=implicit-function-declaration]
err = set_pages_array_uc(&page, 1);
^~~~~~~~~~~~~~~~~~
set_page_dirty_lock
mm/secretmem.c: In function 'secretmem_close':
>> mm/secretmem.c:75:4: error: implicit declaration of function 'set_pages_array_wb'; did you mean 'set_page_dirty'? [-Werror=implicit-function-declaration]
set_pages_array_wb(&page, 1);
^~~~~~~~~~~~~~~~~~
set_page_dirty
cc1: some warnings being treated as errors
vim +45 mm/secretmem.c
21
22 static vm_fault_t secretmem_fault(struct vm_fault *vmf)
23 {
24 struct secretmem_state *state = vmf->vma->vm_file->private_data;
25 struct address_space *mapping = vmf->vma->vm_file->f_mapping;
26 pgoff_t offset = vmf->pgoff;
27 unsigned long addr;
28 struct page *page;
29 int err;
30
31 page = find_get_page(mapping, offset);
32 if (!page) {
33 page = pagecache_get_page(mapping, offset,
34 FGP_CREAT|FGP_FOR_MMAP,
35 vmf->gfp_mask);
36 if (!page)
37 return vmf_error(-ENOMEM);
38
39 __SetPageUptodate(page);
40 }
41
42 if (state->mode == SECRETMEM_EXCLUSIVE)
43 err = set_direct_map_invalid_noflush(page);
44 else if (state->mode == SECRETMEM_UNCACHED)
> 45 err = set_pages_array_uc(&page, 1);
46 else
47 BUG();
48
49 if (err) {
50 delete_from_page_cache(page);
51 return vmf_error(err);
52 }
53
54 addr = (unsigned long)page_address(page);
55 flush_tlb_kernel_range(addr, addr + PAGE_SIZE);
56
57 vmf->page = page;
58 return 0;
59 }
60
61 static void secretmem_close(struct vm_area_struct *vma)
62 {
63 struct secretmem_state *state = vma->vm_file->private_data;
64 struct address_space *mapping = vma->vm_file->f_mapping;
65 struct page *page;
66 pgoff_t index;
67
68 xa_for_each(&mapping->i_pages, index, page) {
69 get_page(page);
70 lock_page(page);
71
72 if (state->mode == SECRETMEM_EXCLUSIVE)
73 set_direct_map_default_noflush(page);
74 else if (state->mode == SECRETMEM_UNCACHED)
> 75 set_pages_array_wb(&page, 1);
76 else
77 BUG();
78
79 __ClearPageDirty(page);
80 delete_from_page_cache(page);
81
82 unlock_page(page);
83 put_page(page);
84 }
85 }
86
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 37879 bytes --]
next prev parent reply other threads:[~2019-12-08 14:11 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-27 10:17 [PATCH RFC] mm: add MAP_EXCLUSIVE to create exclusive user mappings Mike Rapoport
2019-10-27 10:17 ` Mike Rapoport
2019-10-28 12:31 ` Kirill A. Shutemov
2019-10-28 13:00 ` Mike Rapoport
2019-10-28 13:16 ` Kirill A. Shutemov
2019-10-28 13:55 ` Peter Zijlstra
2019-10-28 19:59 ` Edgecombe, Rick P
2019-10-28 21:00 ` Peter Zijlstra
2019-10-29 17:27 ` Edgecombe, Rick P
2019-10-30 10:04 ` Peter Zijlstra
2019-10-30 15:35 ` Alexei Starovoitov
2019-10-30 18:39 ` Peter Zijlstra
2019-10-30 18:52 ` Alexei Starovoitov
2019-10-30 17:48 ` Edgecombe, Rick P
2019-10-30 17:58 ` Dave Hansen
2019-10-30 18:01 ` Dave Hansen
2019-10-29 5:43 ` Dan Williams
2019-10-29 6:43 ` Kirill A. Shutemov
2019-10-29 8:56 ` Peter Zijlstra
2019-10-29 11:00 ` Kirill A. Shutemov
2019-10-29 12:39 ` AMD TLB errata, (Was: [PATCH RFC] mm: add MAP_EXCLUSIVE to create exclusive user mappings) Peter Zijlstra
2019-11-15 14:12 ` Tom Lendacky
2019-11-15 14:31 ` Peter Zijlstra
2019-10-29 19:43 ` [PATCH RFC] mm: add MAP_EXCLUSIVE to create exclusive user mappings Dan Williams
2019-10-29 20:07 ` Dave Hansen
2019-10-29 7:08 ` Christopher Lameter
2019-10-29 8:55 ` Mike Rapoport
2019-10-29 10:12 ` Christopher Lameter
2019-10-30 7:11 ` Mike Rapoport
2019-10-30 12:09 ` Christopher Lameter
2019-10-28 14:55 ` David Hildenbrand
2019-10-28 17:12 ` Dave Hansen
2019-10-28 17:32 ` Sean Christopherson
2019-10-28 18:08 ` Matthew Wilcox
2019-10-29 9:28 ` Mike Rapoport
2019-10-29 9:19 ` Mike Rapoport
2019-10-28 18:02 ` Andy Lutomirski
2019-10-29 11:02 ` David Hildenbrand
2019-10-30 8:15 ` Mike Rapoport
2019-10-30 8:19 ` David Hildenbrand
2019-10-31 19:16 ` Mike Rapoport
2019-10-31 21:52 ` Dan Williams
2019-10-27 10:30 ` Florian Weimer
2019-10-27 11:00 ` Mike Rapoport
2019-10-28 20:23 ` Florian Weimer
2019-10-29 9:01 ` Mike Rapoport
2019-10-28 20:44 ` Andy Lutomirski
2019-10-29 9:32 ` Mike Rapoport
2019-10-29 17:00 ` Andy Lutomirski
2019-10-30 8:40 ` Mike Rapoport
2019-10-30 21:28 ` Andy Lutomirski
2019-10-31 7:21 ` Mike Rapoport
2019-12-05 15:34 ` Mike Rapoport
2019-12-08 14:10 ` kbuild test robot [this message]
2019-10-29 11:25 ` Reshetova, Elena
2019-10-29 15:13 ` Tycho Andersen
2019-10-29 17:03 ` Andy Lutomirski
2019-10-29 17:37 ` Alan Cox
2019-10-29 17:43 ` James Bottomley
2019-10-29 18:10 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201912082019.UdtZtXJf%lkp@intel.com \
--to=lkp@intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=alan@linux.intel.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=cl@linux.com \
--cc=dave.hansen@linux.intel.com \
--cc=elena.reshetova@intel.com \
--cc=hpa@zytor.com \
--cc=jejb@linux.ibm.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=rppt@kernel.org \
--cc=rppt@linux.ibm.com \
--cc=tglx@linutronix.de \
--cc=tycho@tycho.ws \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).