linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] twist: allow converting pr_devel()/pr_debug() into printk(KERN_DEBUG)
       [not found] <20200524145034.10697-1-penguin-kernel@I-love.SAKURA.ne.jp>
@ 2020-05-27  9:59 ` kbuild test robot
  2020-05-27 12:37 ` kbuild test robot
  1 sibling, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-05-27  9:59 UTC (permalink / raw)
  To: Tetsuo Handa, Andrew Morton
  Cc: kbuild-all, Linux Memory Management List, linux-kernel,
	Tetsuo Handa, Dmitry Vyukov, Ondrej Mosnacek, Petr Mladek,
	Sergey Senozhatsky, Steven Rostedt

[-- Attachment #1: Type: text/plain, Size: 4433 bytes --]

Hi Tetsuo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20200519]
[cannot apply to linus/master linux/master pmladek/for-next v5.7-rc6 v5.7-rc5 v5.7-rc4 v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tetsuo-Handa/twist-allow-converting-pr_devel-pr_debug-into-printk-KERN_DEBUG/20200524-225318
base:    fb57b1fabcb28f358901b2df90abd2b48abc1ca8
config: powerpc-allmodconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from include/linux/device.h:15,
from include/linux/acpi.h:15,
from include/linux/i2c.h:13,
from drivers/iio/adc/ina2xx-adc.c:24:
drivers/iio/adc/ina2xx-adc.c: In function 'ina2xx_buffer_enable':
include/linux/dev_printk.h:115:2: error: implicit declaration of function 'dynamic_dev_dbg' [-Werror=implicit-function-declaration]
115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
|  ^~~~~~~~~~~~~~~
>> drivers/iio/adc/ina2xx-adc.c:834:2: note: in expansion of macro 'dev_dbg'
834 |  dev_dbg(&indio_dev->dev, "Enabling buffer w/ scan_mask %02x, freq = %d, avg =%un",
|  ^~~~~~~
cc1: some warnings being treated as errors

vim +/dev_dbg +834 drivers/iio/adc/ina2xx-adc.c

c43a102e67db99c Marc Titinger   2015-12-07  827  
c43a102e67db99c Marc Titinger   2015-12-07  828  static int ina2xx_buffer_enable(struct iio_dev *indio_dev)
c43a102e67db99c Marc Titinger   2015-12-07  829  {
c43a102e67db99c Marc Titinger   2015-12-07  830  	struct ina2xx_chip_info *chip = iio_priv(indio_dev);
c43a102e67db99c Marc Titinger   2015-12-07  831  	unsigned int sampling_us = SAMPLING_PERIOD(chip);
7d6cd21d82bacab Akinobu Mita    2018-06-25  832  	struct task_struct *task;
c43a102e67db99c Marc Titinger   2015-12-07  833  
1961bce76452938 Andrew F. Davis 2016-02-24 @834  	dev_dbg(&indio_dev->dev, "Enabling buffer w/ scan_mask %02x, freq = %d, avg =%u\n",
c43a102e67db99c Marc Titinger   2015-12-07  835  		(unsigned int)(*indio_dev->active_scan_mask),
c43a102e67db99c Marc Titinger   2015-12-07  836  		1000000 / sampling_us, chip->avg);
c43a102e67db99c Marc Titinger   2015-12-07  837  
1961bce76452938 Andrew F. Davis 2016-02-24  838  	dev_dbg(&indio_dev->dev, "Expected work period: %u us\n", sampling_us);
1961bce76452938 Andrew F. Davis 2016-02-24  839  	dev_dbg(&indio_dev->dev, "Async readout mode: %d\n",
1961bce76452938 Andrew F. Davis 2016-02-24  840  		chip->allow_async_readout);
c43a102e67db99c Marc Titinger   2015-12-07  841  
7d6cd21d82bacab Akinobu Mita    2018-06-25  842  	task = kthread_create(ina2xx_capture_thread, (void *)indio_dev,
46294cd948d530d Marc Titinger   2015-12-11  843  			      "%s:%d-%uus", indio_dev->name, indio_dev->id,
46294cd948d530d Marc Titinger   2015-12-11  844  			      sampling_us);
7d6cd21d82bacab Akinobu Mita    2018-06-25  845  	if (IS_ERR(task))
7d6cd21d82bacab Akinobu Mita    2018-06-25  846  		return PTR_ERR(task);
7d6cd21d82bacab Akinobu Mita    2018-06-25  847  
7d6cd21d82bacab Akinobu Mita    2018-06-25  848  	get_task_struct(task);
7d6cd21d82bacab Akinobu Mita    2018-06-25  849  	wake_up_process(task);
7d6cd21d82bacab Akinobu Mita    2018-06-25  850  	chip->task = task;
c43a102e67db99c Marc Titinger   2015-12-07  851  
7d6cd21d82bacab Akinobu Mita    2018-06-25  852  	return 0;
c43a102e67db99c Marc Titinger   2015-12-07  853  }
c43a102e67db99c Marc Titinger   2015-12-07  854  

:::::: The code at line 834 was first introduced by commit
:::::: 1961bce76452938eed8f797b7d96ab5f3c611525 iio: ina2xx: Remove trace_printk debug statments

:::::: TO: Andrew F. Davis <afd@ti.com>
:::::: CC: Jonathan Cameron <jic23@kernel.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 68788 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] twist: allow converting pr_devel()/pr_debug() into printk(KERN_DEBUG)
       [not found] <20200524145034.10697-1-penguin-kernel@I-love.SAKURA.ne.jp>
  2020-05-27  9:59 ` [PATCH] twist: allow converting pr_devel()/pr_debug() into printk(KERN_DEBUG) kbuild test robot
@ 2020-05-27 12:37 ` kbuild test robot
  1 sibling, 0 replies; 2+ messages in thread
From: kbuild test robot @ 2020-05-27 12:37 UTC (permalink / raw)
  To: Tetsuo Handa, Andrew Morton
  Cc: kbuild-all, Linux Memory Management List, linux-kernel,
	Tetsuo Handa, Dmitry Vyukov, Ondrej Mosnacek, Petr Mladek,
	Sergey Senozhatsky, Steven Rostedt

[-- Attachment #1: Type: text/plain, Size: 4404 bytes --]

Hi Tetsuo,

I love your patch! Perhaps something to improve:

[auto build test WARNING on next-20200519]
[cannot apply to linus/master linux/master pmladek/for-next v5.7-rc6 v5.7-rc5 v5.7-rc4 v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Tetsuo-Handa/twist-allow-converting-pr_devel-pr_debug-into-printk-KERN_DEBUG/20200524-225318
base:    fb57b1fabcb28f358901b2df90abd2b48abc1ca8
config: riscv-allyesconfig (attached as .config)
compiler: riscv64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@intel.com>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

In file included from include/linux/device.h:15,
from include/linux/dmaengine.h:8,
from drivers/i2c/busses/i2c-tegra.c:12:
drivers/i2c/busses/i2c-tegra.c: In function 'tegra_i2c_dma_submit':
include/linux/dev_printk.h:115:2: error: implicit declaration of function 'dynamic_dev_dbg' [-Werror=implicit-function-declaration]
115 |  dynamic_dev_dbg(dev, dev_fmt(fmt), ##__VA_ARGS__)
|  ^~~~~~~~~~~~~~~
>> drivers/i2c/busses/i2c-tegra.c:377:2: note: in expansion of macro 'dev_dbg'
377 |  dev_dbg(i2c_dev->dev, "starting DMA for length: %zun", len);
|  ^~~~~~~
cc1: some warnings being treated as errors

vim +/dev_dbg +377 drivers/i2c/busses/i2c-tegra.c

86c92b9965ff175 Sowjanya Komatineni 2019-02-12  370  
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  371  static int tegra_i2c_dma_submit(struct tegra_i2c_dev *i2c_dev, size_t len)
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  372  {
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  373  	struct dma_async_tx_descriptor *dma_desc;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  374  	enum dma_transfer_direction dir;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  375  	struct dma_chan *chan;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  376  
86c92b9965ff175 Sowjanya Komatineni 2019-02-12 @377  	dev_dbg(i2c_dev->dev, "starting DMA for length: %zu\n", len);
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  378  	reinit_completion(&i2c_dev->dma_complete);
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  379  	dir = i2c_dev->msg_read ? DMA_DEV_TO_MEM : DMA_MEM_TO_DEV;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  380  	chan = i2c_dev->msg_read ? i2c_dev->rx_dma_chan : i2c_dev->tx_dma_chan;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  381  	dma_desc = dmaengine_prep_slave_single(chan, i2c_dev->dma_phys,
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  382  					       len, dir, DMA_PREP_INTERRUPT |
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  383  					       DMA_CTRL_ACK);
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  384  	if (!dma_desc) {
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  385  		dev_err(i2c_dev->dev, "failed to get DMA descriptor\n");
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  386  		return -EINVAL;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  387  	}
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  388  
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  389  	dma_desc->callback = tegra_i2c_dma_complete;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  390  	dma_desc->callback_param = i2c_dev;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  391  	dmaengine_submit(dma_desc);
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  392  	dma_async_issue_pending(chan);
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  393  	return 0;
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  394  }
86c92b9965ff175 Sowjanya Komatineni 2019-02-12  395  

:::::: The code at line 377 was first introduced by commit
:::::: 86c92b9965ff1758952cd0d6c5f19eeeef291eea i2c: tegra: Add DMA support

:::::: TO: Sowjanya Komatineni <skomatineni@nvidia.com>
:::::: CC: Wolfram Sang <wsa@the-dreams.de>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 64291 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-05-27 12:37 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200524145034.10697-1-penguin-kernel@I-love.SAKURA.ne.jp>
2020-05-27  9:59 ` [PATCH] twist: allow converting pr_devel()/pr_debug() into printk(KERN_DEBUG) kbuild test robot
2020-05-27 12:37 ` kbuild test robot

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).