From: Axel Rasmussen <axelrasmussen@google.com>
To: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michel Lespinasse <walken@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
Axel Rasmussen <axelrasmussen@google.com>,
Jann Horn <jannh@google.com>,
Chinwen Chang <chinwen.chang@mediatek.com>
Cc: Yafang Shao <laoar.shao@gmail.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH v2 0/2] Add tracepoints around mmap_lock acquisition
Date: Wed, 7 Oct 2020 11:44:01 -0700 [thread overview]
Message-ID: <20201007184403.1902111-1-axelrasmussen@google.com> (raw)
This patchset adds tracepoints around mmap_lock acquisition. This is useful so
we can measure the latency of lock acquisition, in order to detect contention.
This version is based upon linux-next (since it depends on some recently-merged
patches [1] [2]), and incorporates feedback from the review of the previous
version:
- Functions renamed to reserve the "trace_" prefix for actual tracepoints.
- We no longer measure the duration directly. Instead, users are expected to
construct a synthetic event which computes the interval between "start
locking" and "acquire returned".
- The new helper for checking if tracepoints are enabled in a header is used to
avoid un-inlining any of the lock wrappers. This yields ~zero overhead if the
tracepoints aren't enabled, and therefore obviates the need for a Kconfig for
this change.
[1] https://lore.kernel.org/patchwork/patch/1316922/
[2] https://lore.kernel.org/patchwork/patch/1311996/
Axel Rasmussen (2):
tracing: support "bool" type in synthetic trace events
mmap_lock: add tracepoints around lock acquisition
include/linux/mmap_lock.h | 112 +++++++++++++++++++++++++++---
include/trace/events/mmap_lock.h | 70 +++++++++++++++++++
kernel/trace/trace_events_synth.c | 4 ++
mm/Makefile | 2 +-
mm/mmap_lock.c | 87 +++++++++++++++++++++++
5 files changed, 265 insertions(+), 10 deletions(-)
create mode 100644 include/trace/events/mmap_lock.h
create mode 100644 mm/mmap_lock.c
--
2.28.0.806.g8561365e88-goog
next reply other threads:[~2020-10-07 18:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 18:44 Axel Rasmussen [this message]
2020-10-07 18:44 ` [PATCH v2 1/2] tracing: support "bool" type in synthetic trace events Axel Rasmussen
2020-10-08 7:22 ` Michel Lespinasse
2020-10-07 18:44 ` [PATCH v2 2/2] mmap_lock: add tracepoints around lock acquisition Axel Rasmussen
2020-10-08 7:40 ` Michel Lespinasse
2020-10-08 18:04 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201007184403.1902111-1-axelrasmussen@google.com \
--to=axelrasmussen@google.com \
--cc=akpm@linux-foundation.org \
--cc=chinwen.chang@mediatek.com \
--cc=daniel.m.jordan@oracle.com \
--cc=jannh@google.com \
--cc=laoar.shao@gmail.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).