From: Michel Lespinasse <walken@google.com>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>,
Daniel Jordan <daniel.m.jordan@oracle.com>,
Laurent Dufour <ldufour@linux.ibm.com>,
Jann Horn <jannh@google.com>,
Chinwen Chang <chinwen.chang@mediatek.com>,
Yafang Shao <laoar.shao@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH v2 1/2] tracing: support "bool" type in synthetic trace events
Date: Thu, 8 Oct 2020 00:22:21 -0700 [thread overview]
Message-ID: <CANN689E_uE3MosPqVJwG71Trwo15CGNJB2H5+U_Gg47FtPLbxA@mail.gmail.com> (raw)
In-Reply-To: <20201007184403.1902111-2-axelrasmussen@google.com>
On Wed, Oct 7, 2020 at 11:44 AM Axel Rasmussen <axelrasmussen@google.com> wrote:
> It's common [1] to define tracepoint fields as "bool" when they contain
> a true / false value. Currently, defining a synthetic event with a
> "bool" field yields EINVAL. It's possible to work around this by using
> e.g. u8 (assuming sizeof(bool) is 1, and bool is unsigned; if either of
> these properties don't match, you get EINVAL [2]).
>
> Supporting "bool" explicitly makes hooking this up easier and more
> portable for userspace.
Acked-by: Michel Lespinasse <walken@google.com>
Looks fine to me, but you really want to get Steven's opinion over mine here :)
next prev parent reply other threads:[~2020-10-08 7:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-07 18:44 [PATCH v2 0/2] Add tracepoints around mmap_lock acquisition Axel Rasmussen
2020-10-07 18:44 ` [PATCH v2 1/2] tracing: support "bool" type in synthetic trace events Axel Rasmussen
2020-10-08 7:22 ` Michel Lespinasse [this message]
2020-10-07 18:44 ` [PATCH v2 2/2] mmap_lock: add tracepoints around lock acquisition Axel Rasmussen
2020-10-08 7:40 ` Michel Lespinasse
2020-10-08 18:04 ` Axel Rasmussen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANN689E_uE3MosPqVJwG71Trwo15CGNJB2H5+U_Gg47FtPLbxA@mail.gmail.com \
--to=walken@google.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chinwen.chang@mediatek.com \
--cc=daniel.m.jordan@oracle.com \
--cc=jannh@google.com \
--cc=laoar.shao@gmail.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).