* [PATCH] memblock: Remove unused io.h include
@ 2022-01-31 12:17 Karolina Drobnik
2022-02-01 15:26 ` Mike Rapoport
2022-02-02 14:06 ` Christoph Hellwig
0 siblings, 2 replies; 4+ messages in thread
From: Karolina Drobnik @ 2022-01-31 12:17 UTC (permalink / raw)
To: linux-mm; +Cc: rppt, linux-kernel, Karolina Drobnik, Matthew Wilcox
Memblock does not use anything from io.h, remove the include.
Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com>
---
mm/memblock.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/memblock.c b/mm/memblock.c
index 1018e50566f3..4ee190b3f026 100644
--- a/mm/memblock.c
+++ b/mm/memblock.c
@@ -18,7 +18,6 @@
#include <linux/memblock.h>
#include <asm/sections.h>
-#include <linux/io.h>
#include "internal.h"
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] memblock: Remove unused io.h include
2022-01-31 12:17 [PATCH] memblock: Remove unused io.h include Karolina Drobnik
@ 2022-02-01 15:26 ` Mike Rapoport
2022-02-02 8:43 ` Karolina Drobnik
2022-02-02 14:06 ` Christoph Hellwig
1 sibling, 1 reply; 4+ messages in thread
From: Mike Rapoport @ 2022-02-01 15:26 UTC (permalink / raw)
To: Karolina Drobnik; +Cc: linux-mm, linux-kernel, Matthew Wilcox
Hi Karolina,
On Mon, Jan 31, 2022 at 01:17:23PM +0100, Karolina Drobnik wrote:
> Memblock does not use anything from io.h, remove the include.
As Matthew pointed out [1], many architectures put their definition of
virt_to_phys() in asm/io.h, e.g.
arch/powerpc/include/asm/io.h:#define virt_to_phys virt_to_phys
arch/sh/include/asm/io.h:#define virt_to_phys(address) ((unsigned long)(address))
arch/x86/include/asm/io.h:#define virt_to_phys virt_to_phys
which means memblock needs this header for declaration of virt_to_phys().
Although it is included indirectly, let's keep it for now.
[1] https://lore.kernel.org/all/YfbQlMyohx31FhSW@casper.infradead.org/
> Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com>
> ---
> mm/memblock.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/memblock.c b/mm/memblock.c
> index 1018e50566f3..4ee190b3f026 100644
> --- a/mm/memblock.c
> +++ b/mm/memblock.c
> @@ -18,7 +18,6 @@
> #include <linux/memblock.h>
>
> #include <asm/sections.h>
> -#include <linux/io.h>
>
> #include "internal.h"
>
> --
> 2.30.2
>
--
Sincerely yours,
Mike.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] memblock: Remove unused io.h include
2022-02-01 15:26 ` Mike Rapoport
@ 2022-02-02 8:43 ` Karolina Drobnik
0 siblings, 0 replies; 4+ messages in thread
From: Karolina Drobnik @ 2022-02-02 8:43 UTC (permalink / raw)
To: Mike Rapoport; +Cc: linux-mm, linux-kernel, Matthew Wilcox
Hi Mike,
Thanks for taking a look at my patch.
On Tue, 2022-02-01 at 17:26 +0200, Mike Rapoport wrote:
> As Matthew pointed out [1], many architectures put their definition
> of virt_to_phys() in asm/io.h, e.g.
>
> arch/powerpc/include/asm/io.h:#define virt_to_phys virt_to_phys
> arch/sh/include/asm/io.h:#define virt_to_phys(address) ((unsigned
> long)(address))
> arch/x86/include/asm/io.h:#define virt_to_phys virt_to_phys
>
> which means memblock needs this header for declaration of
> virt_to_phys().
>
> Although it is included indirectly, let's keep it for now.
OK, will leave it as it is then.
Many thanks,
Karolina
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] memblock: Remove unused io.h include
2022-01-31 12:17 [PATCH] memblock: Remove unused io.h include Karolina Drobnik
2022-02-01 15:26 ` Mike Rapoport
@ 2022-02-02 14:06 ` Christoph Hellwig
1 sibling, 0 replies; 4+ messages in thread
From: Christoph Hellwig @ 2022-02-02 14:06 UTC (permalink / raw)
To: Karolina Drobnik; +Cc: linux-mm, rppt, linux-kernel, Matthew Wilcox
On Mon, Jan 31, 2022 at 01:17:23PM +0100, Karolina Drobnik wrote:
> Memblock does not use anything from io.h, remove the include.
>
> Suggested-by: Matthew Wilcox (Oracle) <willy@infradead.org>
> Signed-off-by: Karolina Drobnik <karolinadrobnik@gmail.com>
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-02-02 14:06 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-31 12:17 [PATCH] memblock: Remove unused io.h include Karolina Drobnik
2022-02-01 15:26 ` Mike Rapoport
2022-02-02 8:43 ` Karolina Drobnik
2022-02-02 14:06 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).