From: Andrew Morton <akpm@linux-foundation.org>
To: wenyang.linux@foxmail.com
Cc: Mel Gorman <mgorman@techsingularity.net>,
Oscar Salvador <osalvador@suse.de>,
William Lam <william.lam@bytedance.com>, Fu Wei <wefu@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: compaction: optimize compact_memory to comply with the admin-guide
Date: Tue, 11 Apr 2023 13:48:01 -0700 [thread overview]
Message-ID: <20230411134801.a4aadef5aba0f51e0d44bb7a@linux-foundation.org> (raw)
In-Reply-To: <tencent_FD958236269FD3A7996FFCF29E9BAA4EA809@qq.com>
On Wed, 12 Apr 2023 02:24:26 +0800 wenyang.linux@foxmail.com wrote:
> For the /proc/sys/vm/compact_memory file, the admin-guide states:
> When 1 is written to the file, all zones are compacted such that free
> memory is available in contiguous blocks where possible. This can be
> important for example in the allocation of huge pages although processes
> will also directly compact memory as required
>
> But it was not strictly followed, writing any value would cause all
> zones to be compacted. In some critical scenarios, some applications
> operating it, such as echo 0, have caused serious problems.
Really? You mean someone actually did this and didn't observe the
effect during their testing?
> It has been slightly optimized to comply with the admin-guide.
next prev parent reply other threads:[~2023-04-11 20:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 18:24 [PATCH] mm: compaction: optimize compact_memory to comply with the admin-guide wenyang.linux
2023-04-11 20:48 ` Andrew Morton [this message]
2023-04-12 16:54 ` Wen Yang
2023-04-15 17:42 ` Wen Yang
2023-04-17 11:13 ` Mel Gorman
2023-04-18 14:10 ` Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411134801.a4aadef5aba0f51e0d44bb7a@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=wefu@redhat.com \
--cc=wenyang.linux@foxmail.com \
--cc=william.lam@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).