From: Wen Yang <wenyang.linux@foxmail.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Mel Gorman <mgorman@techsingularity.net>,
Oscar Salvador <osalvador@suse.de>,
William Lam <william.lam@bytedance.com>, Fu Wei <wefu@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: compaction: optimize compact_memory to comply with the admin-guide
Date: Sun, 16 Apr 2023 01:42:44 +0800 [thread overview]
Message-ID: <tencent_100BD2639951FD669FA1AA40A89983202709@qq.com> (raw)
In-Reply-To: <tencent_C3E900CCD37EF2CF49553BD4AC4120932B08@qq.com>
在 2023/4/13 00:54, Wen Yang 写道:
>
> 在 2023/4/12 04:48, Andrew Morton 写道:
>> On Wed, 12 Apr 2023 02:24:26 +0800 wenyang.linux@foxmail.com wrote:
>>
>>> For the /proc/sys/vm/compact_memory file, the admin-guide states:
>>> When 1 is written to the file, all zones are compacted such that free
>>> memory is available in contiguous blocks where possible. This can be
>>> important for example in the allocation of huge pages although
>>> processes
>>> will also directly compact memory as required
>>>
>>> But it was not strictly followed, writing any value would cause all
>>> zones to be compacted. In some critical scenarios, some applications
>>> operating it, such as echo 0, have caused serious problems.
>> Really? You mean someone actually did this and didn't observe the
>> effect during their testing?
>
> Thanks for your reply.
>
> Since /proc/sys/vm/compact_memory has been well documented for over a
> decade:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/Documentation/admin-guide/sysctl/vm.rst#n109
>
>
> it is believed that only writing 1 will trigger trigger all zones to
> be compacted.
>
> Especially for those who write applications, they may only focus on
> documentation and generally do not read kernel code. Moreover, such
> problems are not easily detected through testing on low pressure
> machines.
>
> Writing any meaningful or meaningless values will trigger it and
> affect the entire server:
>
> # echo 1 > /proc/sys/vm/compact_memory
> # echo 0 > /proc/sys/vm/compact_memory
> # echo dead > /proc/sys/vm/compact_memory
> # echo "hello world" > /proc/sys/vm/compact_memory
>
> The implementation of this high-risk operation may require following
> the admin-guides.
>
> --
>
> Best wishes,
>
> Wen
>
>
Hello, do you think it's better to optimize the
sysctl_compaction_handler code or update the admin-guide document?
--
Best wishes,
Wen
>>> It has been slightly optimized to comply with the admin-guide.
>
next prev parent reply other threads:[~2023-04-15 17:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 18:24 [PATCH] mm: compaction: optimize compact_memory to comply with the admin-guide wenyang.linux
2023-04-11 20:48 ` Andrew Morton
2023-04-12 16:54 ` Wen Yang
2023-04-15 17:42 ` Wen Yang [this message]
2023-04-17 11:13 ` Mel Gorman
2023-04-18 14:10 ` Wen Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=tencent_100BD2639951FD669FA1AA40A89983202709@qq.com \
--to=wenyang.linux@foxmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=osalvador@suse.de \
--cc=wefu@redhat.com \
--cc=william.lam@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).