From: Catalin Marinas <catalin.marinas@arm.com>
To: Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@lst.de>,
Robin Murphy <robin.murphy@arm.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Will Deacon <will@kernel.org>, Marc Zyngier <maz@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Ard Biesheuvel <ardb@kernel.org>,
Isaac Manjarres <isaacmanjarres@google.com>,
Saravana Kannan <saravanak@google.com>,
Alasdair Kergon <agk@redhat.com>, Daniel Vetter <daniel@ffwll.ch>,
Joerg Roedel <joro@8bytes.org>, Mark Brown <broonie@kernel.org>,
Mike Snitzer <snitzer@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
linux-mm@kvack.org, iommu@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 00/15] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8
Date: Wed, 24 May 2023 18:18:49 +0100 [thread overview]
Message-ID: <20230524171904.3967031-1-catalin.marinas@arm.com> (raw)
Hi,
Another version of the series reducing the kmalloc() minimum alignment
on arm64 to 8 (from 128). Other architectures can easily opt in by
defining ARCH_KMALLOC_MINALIGN as 8 and selecting
DMA_BOUNCE_UNALIGNED_KMALLOC.
The first 10 patches decouple ARCH_KMALLOC_MINALIGN from
ARCH_DMA_MINALIGN and, for arm64, limit the kmalloc() caches to those
aligned to the run-time probed cache_line_size(). On arm64 we gain the
kmalloc-{64,192} caches.
The subsequent patches (11 to 15) further reduce the kmalloc() caches to
kmalloc-{8,16,32,96} if the default swiotlb is present by bouncing small
buffers in the DMA API.
Changes since v4:
- Following Robin's suggestions, reworked the iommu handling so that the
buffer size checks are done in the dev_use_swiotlb() and
dev_use_sg_swiotlb() functions (together with dev_is_untrusted()). The
sync operations can now check for the SG_DMA_USE_SWIOTLB flag. Since
this flag is no longer specific to kmalloc() bouncing (covers
dev_is_untrusted() as well), the sg_is_dma_use_swiotlb() and
sg_dma_mark_use_swiotlb() functions are always defined if
CONFIG_SWIOTLB.
- Dropped ARCH_WANT_KMALLOC_DMA_BOUNCE, only left the
DMA_BOUNCE_UNALIGNED_KMALLOC option, selectable by the arch code. The
NEED_SG_DMA_FLAGS is now selected by IOMMU_DMA if SWIOTLB.
- Rather than adding another config option, allow
dma_get_cache_alignment() to be overridden by the arch code
(Christoph's suggestion).
- Added a comment to the dma_kmalloc_needs_bounce() function on the
heuristics behind the bouncing.
- Added acked-by/reviewed-by tags (not adding Ard's tested-by yet as
there were some changes).
The updated patches are also available on this branch:
git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux devel/kmalloc-minalign
Thanks.
Catalin Marinas (14):
mm/slab: Decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN
dma: Allow dma_get_cache_alignment() to be overridden by the arch code
mm/slab: Simplify create_kmalloc_cache() args and make it static
mm/slab: Limit kmalloc() minimum alignment to
dma_get_cache_alignment()
drivers/base: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN
drivers/gpu: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN
drivers/usb: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN
drivers/spi: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN
drivers/md: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN
arm64: Allow kmalloc() caches aligned to the smaller cache_line_size()
dma-mapping: Force bouncing if the kmalloc() size is not
cache-line-aligned
iommu/dma: Force bouncing if the size is not cacheline-aligned
mm: slab: Reduce the kmalloc() minimum alignment if DMA bouncing
possible
arm64: Enable ARCH_WANT_KMALLOC_DMA_BOUNCE for arm64
Robin Murphy (1):
scatterlist: Add dedicated config for DMA flags
arch/arm64/Kconfig | 1 +
arch/arm64/include/asm/cache.h | 3 ++
arch/arm64/mm/init.c | 7 +++-
drivers/base/devres.c | 6 ++--
drivers/gpu/drm/drm_managed.c | 6 ++--
drivers/iommu/Kconfig | 1 +
drivers/iommu/dma-iommu.c | 50 +++++++++++++++++++++++-----
drivers/md/dm-crypt.c | 2 +-
drivers/pci/Kconfig | 1 +
drivers/spi/spidev.c | 2 +-
drivers/usb/core/buffer.c | 8 ++---
include/linux/dma-map-ops.h | 61 ++++++++++++++++++++++++++++++++++
include/linux/dma-mapping.h | 4 ++-
include/linux/scatterlist.h | 29 +++++++++++++---
include/linux/slab.h | 14 ++++++--
kernel/dma/Kconfig | 7 ++++
kernel/dma/direct.h | 3 +-
mm/slab.c | 6 +---
mm/slab.h | 5 ++-
mm/slab_common.c | 46 +++++++++++++++++++------
20 files changed, 213 insertions(+), 49 deletions(-)
next reply other threads:[~2023-05-24 17:19 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 17:18 Catalin Marinas [this message]
2023-05-24 17:18 ` [PATCH v5 01/15] mm/slab: Decouple ARCH_KMALLOC_MINALIGN from ARCH_DMA_MINALIGN Catalin Marinas
2023-05-24 17:18 ` [PATCH v5 02/15] dma: Allow dma_get_cache_alignment() to be overridden by the arch code Catalin Marinas
2023-05-25 13:59 ` Christoph Hellwig
2023-05-24 17:18 ` [PATCH v5 03/15] mm/slab: Simplify create_kmalloc_cache() args and make it static Catalin Marinas
2023-05-24 17:18 ` [PATCH v5 04/15] mm/slab: Limit kmalloc() minimum alignment to dma_get_cache_alignment() Catalin Marinas
2023-05-24 17:18 ` [PATCH v5 05/15] drivers/base: Use ARCH_DMA_MINALIGN instead of ARCH_KMALLOC_MINALIGN Catalin Marinas
2023-05-24 17:18 ` [PATCH v5 06/15] drivers/gpu: " Catalin Marinas
2023-05-24 17:18 ` [PATCH v5 07/15] drivers/usb: " Catalin Marinas
2023-05-24 17:18 ` [PATCH v5 08/15] drivers/spi: " Catalin Marinas
2023-05-24 17:18 ` [PATCH v5 09/15] drivers/md: " Catalin Marinas
2023-05-25 14:00 ` Christoph Hellwig
2023-05-24 17:18 ` [PATCH v5 10/15] arm64: Allow kmalloc() caches aligned to the smaller cache_line_size() Catalin Marinas
2023-05-24 17:19 ` [PATCH v5 11/15] scatterlist: Add dedicated config for DMA flags Catalin Marinas
2023-05-24 17:19 ` [PATCH v5 12/15] dma-mapping: Force bouncing if the kmalloc() size is not cache-line-aligned Catalin Marinas
2023-05-25 15:53 ` Robin Murphy
2023-05-24 17:19 ` [PATCH v5 13/15] iommu/dma: Force bouncing if the size is not cacheline-aligned Catalin Marinas
2023-05-25 15:57 ` Robin Murphy
2023-05-26 16:36 ` Jisheng Zhang
2023-05-26 19:22 ` Catalin Marinas
2023-05-30 13:01 ` Robin Murphy
2023-05-24 17:19 ` [PATCH v5 14/15] mm: slab: Reduce the kmalloc() minimum alignment if DMA bouncing possible Catalin Marinas
2023-05-24 17:19 ` [PATCH v5 15/15] arm64: Enable ARCH_WANT_KMALLOC_DMA_BOUNCE for arm64 Catalin Marinas
2023-05-25 16:12 ` Robin Murphy
2023-05-25 17:08 ` Catalin Marinas
2023-05-25 12:31 ` [PATCH v5 00/15] mm, dma, arm64: Reduce ARCH_KMALLOC_MINALIGN to 8 Jonathan Cameron
2023-05-25 14:31 ` Catalin Marinas
2023-05-26 16:07 ` Jonathan Cameron
2023-05-26 16:29 ` Jonathan Cameron
2023-05-30 13:38 ` Catalin Marinas
2023-05-30 16:31 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230524171904.3967031-1-catalin.marinas@arm.com \
--to=catalin.marinas@arm.com \
--cc=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=herbert@gondor.apana.org.au \
--cc=iommu@lists.linux.dev \
--cc=isaacmanjarres@google.com \
--cc=joro@8bytes.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mm@kvack.org \
--cc=maz@kernel.org \
--cc=rafael@kernel.org \
--cc=robin.murphy@arm.com \
--cc=saravanak@google.com \
--cc=snitzer@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).