From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@infradead.org>,
David Hildenbrand <david@redhat.com>,
Lorenzo Stoakes <lstoakes@gmail.com>
Cc: David Howells <dhowells@redhat.com>, Jens Axboe <axboe@kernel.dk>,
Al Viro <viro@zeniv.linux.org.uk>,
Matthew Wilcox <willy@infradead.org>, Jan Kara <jack@suse.cz>,
Jeff Layton <jlayton@kernel.org>,
Jason Gunthorpe <jgg@nvidia.com>,
Logan Gunthorpe <logang@deltatee.com>,
Hillf Danton <hdanton@sina.com>,
Christian Brauner <brauner@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: [PATCH v4 0/3] block: Make old dio use iov_iter_extract_pages() and page pinning
Date: Fri, 26 May 2023 22:41:39 +0100 [thread overview]
Message-ID: <20230526214142.958751-1-dhowells@redhat.com> (raw)
Hi Christoph, David, Lorenzo,
Here are three patches that go on top of the similar patches for bio
structs now in the block tree that make the old block direct-IO code use
iov_iter_extract_pages() and page pinning.
There are three patches:
(1) Make page pinning neither add nor remove a pin to/from a ZERO_PAGE,
thereby allowing the dio code to insert zero pages in the middle of
dealing with pinned pages. This also mitigates a potential problem
whereby userspace could force the overrun the pin counter of a zero
page.
A pair of functions are provided to wrap the testing of a page or
folio to see if it is a zero page.
(2) Provide a function to allow an additional pin to be taken on a page we
already have pinned (and do nothing for a zero page).
(3) Switch direct-io.c over to using page pinning and to use
iov_iter_extract_pages() so that pages from non-user-backed iterators
aren't pinned.
I've pushed the patches here also:
https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-old-dio
David
Changes
=======
ver #4)
- Use _inc rather than _add ops when we're just adding 1.
ver #3)
- Move is_zero_page() and is_zero_folio() to mm.h for dependency reasons.
- Add more comments and adjust the docs about pinning zero pages.
- Rename page_get_additional_pin() to folio_add_pin().
- Use is_zero_folio() in folio_add_pin().
- Rename need_unpin to is_pinned in struct dio.
ver #2)
- Fix use of ZERO_PAGE().
- Add wrappers for testing if a page is a zero page.
- Return the zero page obtained, not ZERO_PAGE(0) unconditionally.
- Need to set BIO_PAGE_PINNED conditionally, and not BIO_PAGE_REFFED.
Link: https://lore.kernel.org/r/ZGxfrOLZ4aN9/MvE@infradead.org/ [1]
Link: https://lore.kernel.org/r/20230525155102.87353-1-dhowells@redhat.com/ # v1
Link: https://lore.kernel.org/r/20230525223953.225496-1-dhowells@redhat.com/ # v2
Link: https://lore.kernel.org/r/20230526112859.654506-1-dhowells@redhat.com/ # v3
David Howells (3):
mm: Don't pin ZERO_PAGE in pin_user_pages()
mm: Provide a function to get an additional pin on a page
block: Use iov_iter_extract_pages() and page pinning in direct-io.c
Documentation/core-api/pin_user_pages.rst | 6 ++
fs/direct-io.c | 72 ++++++++++++++---------
include/linux/mm.h | 27 ++++++++-
mm/gup.c | 58 +++++++++++++++++-
4 files changed, 131 insertions(+), 32 deletions(-)
next reply other threads:[~2023-05-26 21:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 21:41 David Howells [this message]
2023-05-26 21:41 ` [PATCH v4 1/3] mm: Don't pin ZERO_PAGE in pin_user_pages() David Howells
2023-05-27 19:46 ` Lorenzo Stoakes
2023-05-31 3:57 ` Christoph Hellwig
2023-05-31 7:34 ` David Hildenbrand
2023-05-31 8:35 ` David Howells
2023-05-31 8:46 ` David Hildenbrand
2023-05-31 13:55 ` David Howells
2023-05-31 14:10 ` Lorenzo Stoakes
2023-05-26 21:41 ` [PATCH v4 2/3] mm: Provide a function to get an additional pin on a page David Howells
2023-05-31 3:57 ` Christoph Hellwig
2023-05-31 7:42 ` David Hildenbrand
2023-05-31 8:20 ` David Howells
2023-05-26 21:41 ` [PATCH v4 3/3] block: Use iov_iter_extract_pages() and page pinning in direct-io.c David Howells
2023-05-31 3:58 ` Christoph Hellwig
2023-05-31 15:48 ` [PATCH v4 0/3] block: Make old dio use iov_iter_extract_pages() and page pinning Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526214142.958751-1-dhowells@redhat.com \
--to=dhowells@redhat.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=david@redhat.com \
--cc=hch@infradead.org \
--cc=hdanton@sina.com \
--cc=jack@suse.cz \
--cc=jgg@nvidia.com \
--cc=jlayton@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=logang@deltatee.com \
--cc=lstoakes@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).