* [PATCH] mempool: kvmalloc pool
@ 2024-02-01 12:15 Kent Overstreet
2024-02-02 8:39 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Kent Overstreet @ 2024-02-01 12:15 UTC (permalink / raw)
To: akpm; +Cc: Kent Overstreet, linux-mm
Add mempool_init_kvmalloc_pool() and mempool_create_kvmalloc_pool(),
which wrap kvmalloc() instead of kmalloc() - kmalloc() with a vmalloc()
fallback.
Signed-off-by: Kent Overstreet <kent.overstreet@linux.dev>
Cc: linux-mm@kvack.org
---
include/linux/mempool.h | 13 +++++++++++++
mm/mempool.c | 13 +++++++++++++
2 files changed, 26 insertions(+)
diff --git a/include/linux/mempool.h b/include/linux/mempool.h
index 7be1e32e6d42..16c5cc807ff6 100644
--- a/include/linux/mempool.h
+++ b/include/linux/mempool.h
@@ -95,6 +95,19 @@ static inline mempool_t *mempool_create_kmalloc_pool(int min_nr, size_t size)
(void *) size);
}
+void *mempool_kvmalloc(gfp_t gfp_mask, void *pool_data);
+void mempool_kvfree(void *element, void *pool_data);
+
+static inline int mempool_init_kvmalloc_pool(mempool_t *pool, int min_nr, size_t size)
+{
+ return mempool_init(pool, min_nr, mempool_kvmalloc, mempool_kvfree, (void *) size);
+}
+
+static inline mempool_t *mempool_create_kvmalloc_pool(int min_nr, size_t size)
+{
+ return mempool_create(min_nr, mempool_kvmalloc, mempool_kvfree, (void *) size);
+}
+
/*
* A mempool_alloc_t and mempool_free_t for a simple page allocator that
* allocates pages of the order specified by pool_data
diff --git a/mm/mempool.c b/mm/mempool.c
index dbbf0e9fb424..076c736f5f1f 100644
--- a/mm/mempool.c
+++ b/mm/mempool.c
@@ -590,6 +590,19 @@ void mempool_kfree(void *element, void *pool_data)
}
EXPORT_SYMBOL(mempool_kfree);
+void *mempool_kvmalloc(gfp_t gfp_mask, void *pool_data)
+{
+ size_t size = (size_t)pool_data;
+ return kvmalloc(size, gfp_mask);
+}
+EXPORT_SYMBOL(mempool_kvmalloc);
+
+void mempool_kvfree(void *element, void *pool_data)
+{
+ kvfree(element);
+}
+EXPORT_SYMBOL(mempool_kvfree);
+
/*
* A simple mempool-backed page allocator that allocates pages
* of the order specified by pool_data.
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] mempool: kvmalloc pool
2024-02-01 12:15 [PATCH] mempool: kvmalloc pool Kent Overstreet
@ 2024-02-02 8:39 ` Andrew Morton
2024-02-02 9:44 ` Kent Overstreet
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2024-02-02 8:39 UTC (permalink / raw)
To: Kent Overstreet; +Cc: linux-mm
On Thu, 1 Feb 2024 07:15:44 -0500 Kent Overstreet <kent.overstreet@linux.dev> wrote:
> Add mempool_init_kvmalloc_pool() and mempool_create_kvmalloc_pool(),
> which wrap kvmalloc() instead of kmalloc() - kmalloc() with a vmalloc()
> fallback.
>
Why do we need this?
Can we expect to see users of this?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mempool: kvmalloc pool
2024-02-02 8:39 ` Andrew Morton
@ 2024-02-02 9:44 ` Kent Overstreet
0 siblings, 0 replies; 3+ messages in thread
From: Kent Overstreet @ 2024-02-02 9:44 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-mm
On Fri, Feb 02, 2024 at 12:39:04AM -0800, Andrew Morton wrote:
> On Thu, 1 Feb 2024 07:15:44 -0500 Kent Overstreet <kent.overstreet@linux.dev> wrote:
>
> > Add mempool_init_kvmalloc_pool() and mempool_create_kvmalloc_pool(),
> > which wrap kvmalloc() instead of kmalloc() - kmalloc() with a vmalloc()
> > fallback.
> >
>
> Why do we need this?
>
> Can we expect to see users of this?
Yeah, I should have had that in the commit message - it's replacing
mempool_init_kvpmalloc_pool() in fs/bcachefs/util.c
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-02-02 9:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-02-01 12:15 [PATCH] mempool: kvmalloc pool Kent Overstreet
2024-02-02 8:39 ` Andrew Morton
2024-02-02 9:44 ` Kent Overstreet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).