From: David Hildenbrand <david@redhat.com>
To: Chao Yu <yuchao0@huawei.com>, akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] writeback: remove unused variable
Date: Thu, 28 May 2020 10:35:24 +0200 [thread overview]
Message-ID: <234781ec-4593-c518-f67e-9bbe8a142537@redhat.com> (raw)
In-Reply-To: <20200528033740.17269-1-yuchao0@huawei.com>
On 28.05.20 05:37, Chao Yu wrote:
> Commit 64081362e8ff ("mm/page-writeback.c: fix range_cyclic writeback
> vs writepages deadlock") left unused variable, remove it.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> mm/page-writeback.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index a53f4cfa7628..7e9714d2ce9d 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2160,7 +2160,6 @@ int write_cache_pages(struct address_space *mapping,
> int error;
> struct pagevec pvec;
> int nr_pages;
> - pgoff_t uninitialized_var(writeback_index);
> pgoff_t index;
> pgoff_t end; /* Inclusive */
> pgoff_t done_index;
> @@ -2169,8 +2168,7 @@ int write_cache_pages(struct address_space *mapping,
>
> pagevec_init(&pvec);
> if (wbc->range_cyclic) {
> - writeback_index = mapping->writeback_index; /* prev offset */
> - index = writeback_index;
> + index = mapping->writeback_index; /* prev offset */
> end = -1;
> } else {
> index = wbc->range_start >> PAGE_SHIFT;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
prev parent reply other threads:[~2020-05-28 8:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 3:37 [PATCH] writeback: remove unused variable Chao Yu
2020-05-28 8:35 ` David Hildenbrand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=234781ec-4593-c518-f67e-9bbe8a142537@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).