* [PATCH] writeback: remove unused variable
@ 2020-05-28 3:37 Chao Yu
2020-05-28 8:35 ` David Hildenbrand
0 siblings, 1 reply; 2+ messages in thread
From: Chao Yu @ 2020-05-28 3:37 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Chao Yu
Commit 64081362e8ff ("mm/page-writeback.c: fix range_cyclic writeback
vs writepages deadlock") left unused variable, remove it.
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
mm/page-writeback.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/mm/page-writeback.c b/mm/page-writeback.c
index a53f4cfa7628..7e9714d2ce9d 100644
--- a/mm/page-writeback.c
+++ b/mm/page-writeback.c
@@ -2160,7 +2160,6 @@ int write_cache_pages(struct address_space *mapping,
int error;
struct pagevec pvec;
int nr_pages;
- pgoff_t uninitialized_var(writeback_index);
pgoff_t index;
pgoff_t end; /* Inclusive */
pgoff_t done_index;
@@ -2169,8 +2168,7 @@ int write_cache_pages(struct address_space *mapping,
pagevec_init(&pvec);
if (wbc->range_cyclic) {
- writeback_index = mapping->writeback_index; /* prev offset */
- index = writeback_index;
+ index = mapping->writeback_index; /* prev offset */
end = -1;
} else {
index = wbc->range_start >> PAGE_SHIFT;
--
2.18.0.rc1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] writeback: remove unused variable
2020-05-28 3:37 [PATCH] writeback: remove unused variable Chao Yu
@ 2020-05-28 8:35 ` David Hildenbrand
0 siblings, 0 replies; 2+ messages in thread
From: David Hildenbrand @ 2020-05-28 8:35 UTC (permalink / raw)
To: Chao Yu, akpm; +Cc: linux-mm, linux-kernel
On 28.05.20 05:37, Chao Yu wrote:
> Commit 64081362e8ff ("mm/page-writeback.c: fix range_cyclic writeback
> vs writepages deadlock") left unused variable, remove it.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> mm/page-writeback.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index a53f4cfa7628..7e9714d2ce9d 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -2160,7 +2160,6 @@ int write_cache_pages(struct address_space *mapping,
> int error;
> struct pagevec pvec;
> int nr_pages;
> - pgoff_t uninitialized_var(writeback_index);
> pgoff_t index;
> pgoff_t end; /* Inclusive */
> pgoff_t done_index;
> @@ -2169,8 +2168,7 @@ int write_cache_pages(struct address_space *mapping,
>
> pagevec_init(&pvec);
> if (wbc->range_cyclic) {
> - writeback_index = mapping->writeback_index; /* prev offset */
> - index = writeback_index;
> + index = mapping->writeback_index; /* prev offset */
> end = -1;
> } else {
> index = wbc->range_start >> PAGE_SHIFT;
>
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-28 8:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-28 3:37 [PATCH] writeback: remove unused variable Chao Yu
2020-05-28 8:35 ` David Hildenbrand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).