From: Karolina Drobnik <karolinadrobnik@gmail.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-mm@kvack.org, akpm@linux-foundation.org,
mike.rapoport@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/16] tools: Move gfp.h and slab.h from radix-tree to lib
Date: Fri, 28 Jan 2022 12:02:13 +0100 [thread overview]
Message-ID: <4eee8241e35fac1fa05eee3525a10672396c18ec.camel@gmail.com> (raw)
In-Reply-To: <YfKf74qdUXrPPZHZ@casper.infradead.org>
On Thu, 2022-01-27 at 13:36 +0000, Matthew Wilcox wrote:
> On Thu, Jan 27, 2022 at 02:21:19PM +0100, Karolina Drobnik wrote:
> > diff --git a/tools/testing/radix-tree/linux.c
> > b/tools/testing/radix-tree/linux.c
> > index 2d9c59df60de..81539f543954 100644
> > --- a/tools/testing/radix-tree/linux.c
> > +++ b/tools/testing/radix-tree/linux.c
> > @@ -14,7 +14,6 @@
> >
> > int nr_allocated;
> > int preempt_count;
> > -int kmalloc_verbose;
> > int test_verbose;
> >
> > struct kmem_cache {
> > @@ -78,32 +77,6 @@ void kmem_cache_free(struct kmem_cache *cachep,
> > void *objp)
> > pthread_mutex_unlock(&cachep->lock);
> > }
> >
> > -void *kmalloc(size_t size, gfp_t gfp)
> > -{
> > - void *ret;
> > -
> > - if (!(gfp & __GFP_DIRECT_RECLAIM))
> > - return NULL;
> > -
> > - ret = malloc(size);
> > - uatomic_inc(&nr_allocated);
> > - if (kmalloc_verbose)
> > - printf("Allocating %p from malloc\n", ret);
> > - if (gfp & __GFP_ZERO)
> > - memset(ret, 0, size);
> > - return ret;
> > -}
> > -
> > -void kfree(void *p)
> > -{
> > - if (!p)
> > - return;
> > - uatomic_dec(&nr_allocated);
> > - if (kmalloc_verbose)
> > - printf("Freeing %p to malloc\n", p);
> > - free(p);
> > -}
> > -
> > struct kmem_cache *
> > kmem_cache_create(const char *name, unsigned int size, unsigned
> > int align,
> > unsigned int flags, void (*ctor)(void *))
>
> I don't think it makes much sense to move kmalloc() and not to move
> the kmem_cache* functions. They're all provided by slab in the
> kernel
> proper, so while you don't use them, I think keeping all the memory
> allocation functions together is preferable.
I wasn't sure if these functions would be used by other test suites, so
I left them here. But I can move them if you think it's better to keep
them together.
next prev parent reply other threads:[~2022-01-28 11:02 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 13:21 [PATCH 00/16] Introduce memblock simulator Karolina Drobnik
2022-01-27 13:21 ` [PATCH 01/16] tools: Move gfp.h and slab.h from radix-tree to lib Karolina Drobnik
2022-01-27 13:28 ` Matthew Wilcox
2022-01-28 11:00 ` Karolina Drobnik
2022-01-27 13:36 ` Matthew Wilcox
2022-01-28 11:02 ` Karolina Drobnik [this message]
2022-01-28 17:30 ` Karolina Drobnik
2022-01-27 13:21 ` [PATCH 02/16] tools/include: Add phys_addr_t to types.h Karolina Drobnik
2022-01-27 13:21 ` [PATCH 03/16] tools/include: Add _RET_IP_ and math definitions to kernel.h Karolina Drobnik
2022-01-27 13:54 ` Matthew Wilcox
2022-01-28 11:05 ` Karolina Drobnik
2022-01-27 13:21 ` [PATCH 04/16] tools/include: Update atomic.h header Karolina Drobnik
2022-01-27 13:56 ` Matthew Wilcox
2022-01-28 11:08 ` Karolina Drobnik
2022-01-27 13:21 ` [PATCH 05/16] tools/include: Add mm.h file Karolina Drobnik
2022-01-27 13:21 ` [PATCH 06/16] tools/include: Add cache.h stub Karolina Drobnik
2022-01-27 14:00 ` Matthew Wilcox
2022-01-28 11:13 ` Karolina Drobnik
2022-01-28 13:10 ` Matthew Wilcox
2022-01-27 13:21 ` [PATCH 07/16] tools/include: Add io.h stub Karolina Drobnik
2022-01-27 14:09 ` Matthew Wilcox
2022-01-28 11:21 ` Karolina Drobnik
2022-01-30 16:10 ` Mike Rapoport
2022-01-30 17:53 ` Matthew Wilcox
2022-01-30 19:00 ` Mike Rapoport
2022-01-31 10:55 ` Karolina Drobnik
2022-01-31 13:30 ` Arnd Bergmann
2022-01-31 15:18 ` Mike Rapoport
2022-01-31 16:26 ` Arnd Bergmann
2022-01-31 10:54 ` Karolina Drobnik
2022-01-27 13:21 ` [PATCH 08/16] tools/include: Add pfn.h stub Karolina Drobnik
2022-01-27 13:21 ` [PATCH 09/16] tools/include: Add debugfs.h stub Karolina Drobnik
2022-01-27 13:21 ` [PATCH 10/16] memblock tests: Add skeleton of the memblock simulator Karolina Drobnik
2022-01-27 14:02 ` Matthew Wilcox
2022-01-27 14:06 ` Matthew Wilcox
2022-01-28 11:25 ` Karolina Drobnik
2022-01-28 13:11 ` Matthew Wilcox
2022-01-27 13:21 ` [PATCH 11/16] memblock tests: Add memblock reset function Karolina Drobnik
2022-01-27 13:21 ` [PATCH 12/16] memblock tests: Add memblock_add tests Karolina Drobnik
2022-01-27 13:21 ` [PATCH 13/16] memblock tests: Add memblock_reserve tests Karolina Drobnik
2022-01-27 13:21 ` [PATCH 14/16] memblock tests: Add memblock_remove tests Karolina Drobnik
2022-01-27 13:21 ` [PATCH 15/16] memblock tests: Add memblock_add_node test Karolina Drobnik
2022-01-27 13:21 ` [PATCH 16/16] memblock tests: Add memblock_free tests Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4eee8241e35fac1fa05eee3525a10672396c18ec.camel@gmail.com \
--to=karolinadrobnik@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.rapoport@gmail.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).