From: Arnd Bergmann <arnd@arndb.de>
To: Mike Rapoport <rppt@kernel.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Matthew Wilcox <willy@infradead.org>,
Karolina Drobnik <karolinadrobnik@gmail.com>,
Linux-MM <linux-mm@kvack.org>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Rapoport <mike.rapoport@gmail.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@redhat.com>
Subject: Re: [PATCH 07/16] tools/include: Add io.h stub
Date: Mon, 31 Jan 2022 17:26:51 +0100 [thread overview]
Message-ID: <CAK8P3a3O4gdZZA_ON1efO7hp+3KskpdX68MHW5P=6n8ZTXj0SQ@mail.gmail.com> (raw)
In-Reply-To: <Yff9r+NdshpNKRk8@kernel.org>
On Mon, Jan 31, 2022 at 4:18 PM Mike Rapoport <rppt@kernel.org> wrote:
> On Mon, Jan 31, 2022 at 02:30:32PM +0100, Arnd Bergmann wrote:
> > On Sun, Jan 30, 2022 at 6:53 PM Matthew Wilcox <willy@infradead.org> wrote:
> I actually liked m68k's name for a header with virt_to_phys/phys_to_virt
> definitions - virtconvert.h.
>
> As an experiment I pulled out address translations from
> arch/arm/include/memory.h to arch/arm/include/virtconvert.h, it wasn't that
> bad:
>
> arch/arm/include/asm/dma-mapping.h | 2 +
> arch/arm/include/asm/io.h | 1 +
> arch/arm/include/asm/memory.h | 244 ----------------------------------
> arch/arm/include/asm/pgtable.h | 1 +
> arch/arm/include/asm/virtconvert.h | 264 +++++++++++++++++++++++++++++++++++++
> arch/arm/kernel/psci_smp.c | 1 +
> 6 files changed, 269 insertions(+), 244 deletions(-)
>
> (https://git.kernel.org/rppt/linux/c/4c34ec16319fc85280aad89d7a74df845c1614fc)
Right, that doesn't look too bad, especially since it seems you managed to avoid
any further indirect inlcudes. Doing the same consistently for all architectures
may end up a bit harder but would be a great help.
Arnd
next prev parent reply other threads:[~2022-01-31 16:27 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-27 13:21 [PATCH 00/16] Introduce memblock simulator Karolina Drobnik
2022-01-27 13:21 ` [PATCH 01/16] tools: Move gfp.h and slab.h from radix-tree to lib Karolina Drobnik
2022-01-27 13:28 ` Matthew Wilcox
2022-01-28 11:00 ` Karolina Drobnik
2022-01-27 13:36 ` Matthew Wilcox
2022-01-28 11:02 ` Karolina Drobnik
2022-01-28 17:30 ` Karolina Drobnik
2022-01-27 13:21 ` [PATCH 02/16] tools/include: Add phys_addr_t to types.h Karolina Drobnik
2022-01-27 13:21 ` [PATCH 03/16] tools/include: Add _RET_IP_ and math definitions to kernel.h Karolina Drobnik
2022-01-27 13:54 ` Matthew Wilcox
2022-01-28 11:05 ` Karolina Drobnik
2022-01-27 13:21 ` [PATCH 04/16] tools/include: Update atomic.h header Karolina Drobnik
2022-01-27 13:56 ` Matthew Wilcox
2022-01-28 11:08 ` Karolina Drobnik
2022-01-27 13:21 ` [PATCH 05/16] tools/include: Add mm.h file Karolina Drobnik
2022-01-27 13:21 ` [PATCH 06/16] tools/include: Add cache.h stub Karolina Drobnik
2022-01-27 14:00 ` Matthew Wilcox
2022-01-28 11:13 ` Karolina Drobnik
2022-01-28 13:10 ` Matthew Wilcox
2022-01-27 13:21 ` [PATCH 07/16] tools/include: Add io.h stub Karolina Drobnik
2022-01-27 14:09 ` Matthew Wilcox
2022-01-28 11:21 ` Karolina Drobnik
2022-01-30 16:10 ` Mike Rapoport
2022-01-30 17:53 ` Matthew Wilcox
2022-01-30 19:00 ` Mike Rapoport
2022-01-31 10:55 ` Karolina Drobnik
2022-01-31 13:30 ` Arnd Bergmann
2022-01-31 15:18 ` Mike Rapoport
2022-01-31 16:26 ` Arnd Bergmann [this message]
2022-01-31 10:54 ` Karolina Drobnik
2022-01-27 13:21 ` [PATCH 08/16] tools/include: Add pfn.h stub Karolina Drobnik
2022-01-27 13:21 ` [PATCH 09/16] tools/include: Add debugfs.h stub Karolina Drobnik
2022-01-27 13:21 ` [PATCH 10/16] memblock tests: Add skeleton of the memblock simulator Karolina Drobnik
2022-01-27 14:02 ` Matthew Wilcox
2022-01-27 14:06 ` Matthew Wilcox
2022-01-28 11:25 ` Karolina Drobnik
2022-01-28 13:11 ` Matthew Wilcox
2022-01-27 13:21 ` [PATCH 11/16] memblock tests: Add memblock reset function Karolina Drobnik
2022-01-27 13:21 ` [PATCH 12/16] memblock tests: Add memblock_add tests Karolina Drobnik
2022-01-27 13:21 ` [PATCH 13/16] memblock tests: Add memblock_reserve tests Karolina Drobnik
2022-01-27 13:21 ` [PATCH 14/16] memblock tests: Add memblock_remove tests Karolina Drobnik
2022-01-27 13:21 ` [PATCH 15/16] memblock tests: Add memblock_add_node test Karolina Drobnik
2022-01-27 13:21 ` [PATCH 16/16] memblock tests: Add memblock_free tests Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAK8P3a3O4gdZZA_ON1efO7hp+3KskpdX68MHW5P=6n8ZTXj0SQ@mail.gmail.com' \
--to=arnd@arndb.de \
--cc=akpm@linux-foundation.org \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.rapoport@gmail.com \
--cc=mingo@redhat.com \
--cc=rppt@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).